Re: [PR] LogListener: remove no-arg convenience methods [solr]
dsmiley merged PR #3202: URL: https://github.com/apache/solr/pull/3202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] LogListener: remove no-arg convenience methods [solr]
hossman commented on PR #3202: URL: https://github.com/apache/solr/pull/3202#issuecomment-2672823452 > For the hazard, see what I linked to. Houston agrees. Ah ok -- yeah, sorry i didn't notice that jira link. The crux of the problem being that in order to listen to the logs at a particular level, we must enable the logs at that level, and enabling something like DEBUG at the ROOT level can really slow things down. Totally valid point. > Maybe we remove the debug (and info?) no-arg versions, leave a comment why, and leave the warn and error versions around? We could, but that functionality is still available by referring to the root level logger by `""` (which is already mentioned as possible in the jdocs) for the rare case where it's useful ... I agree with David: we should "Make the common/safe thing easy, Make the rare/scary thing hard" BTW David: skimming the code i see an out of date TODO that should also be removed.. ``` // TODO: no-arg factory variants that use "" -- simpler syntax for ROOT logger? ``` (don't want to leave a TODO suggesting someone re-add the thing you're removing) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] LogListener: remove no-arg convenience methods [solr]
madrob commented on PR #3202: URL: https://github.com/apache/solr/pull/3202#issuecomment-2672807785 Maybe we remove the debug (and info?) no-arg versions, leave a comment why, and leave the warn and error versions around? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] LogListener: remove no-arg convenience methods [solr]
dsmiley commented on PR #3202: URL: https://github.com/apache/solr/pull/3202#issuecomment-2672795343 For the hazard, see what I linked to. Houston agrees. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] LogListener: remove no-arg convenience methods [solr]
hossman commented on PR #3202:
URL: https://github.com/apache/solr/pull/3202#issuecomment-2672710644
Not really sure i understand why you consider them hazardous?
FWIW: The intent of these was to make it as easy as possible for folks to
write tests asserting that "No code run in this block should cause any code,
anywhere, to log an ERROR (WARN, etc...)" but see no great loss in making
people write `LogListener.error("")` instead of `LogListener.error()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
