Re: [PR] Remove some dead code from distributed updater [solr]

2025-09-20 Thread via GitHub 


psalagnac commented on PR #3610:
URL: https://github.com/apache/solr/pull/3610#issuecomment-3270474454

   Thanks for the review.
   I reverted the logging changes since they don't really belong to this PR. I 
may open another one that fixes the logger calls with wrong pattern.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] Remove some dead code from distributed updater [solr]

2025-09-09 Thread via GitHub 


psalagnac merged PR #3610:
URL: https://github.com/apache/solr/pull/3610


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] Remove some dead code from distributed updater [solr]

2025-09-06 Thread via GitHub 


murblanc commented on PR #3610:
URL: https://github.com/apache/solr/pull/3610#issuecomment-3258412166

   > > murblanc is the initial author of most the this change (I'm not adding 
an entry in change log, so just mentioning this here).
   > 
   > In the commit message at the end, after a blank line separation, add this 
line:
   > 
   > ```
   > Co-authored-by: Ilan Ginzburg 
   > ```
   
   The cleanup is Pierre's own work, so no need to update the commit message.
   He meant I wrote most of the original code (and left over dead code).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] Remove some dead code from distributed updater [solr]

2025-09-05 Thread via GitHub 


dsmiley commented on PR #3610:
URL: https://github.com/apache/solr/pull/3610#issuecomment-3258374272

   > murblanc is the initial author of most the this change (I'm not adding an 
entry in change log, so just mentioning this here).
   
   In the commit message at the end, after a blank line separation, add this 
line:
   
   Co-authored-by: Ilan Ginzburg 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] Remove some dead code from distributed updater [solr]

2025-09-03 Thread via GitHub 


dsmiley commented on code in PR #3610:
URL: https://github.com/apache/solr/pull/3610#discussion_r2320340119


##
solr/core/src/java/org/apache/solr/cloud/DistributedClusterStateUpdater.java:
##
@@ -94,11 +83,9 @@ public DistributedClusterStateUpdater(boolean 
useDistributedStateUpdate) {
 this.useDistributedStateUpdate = useDistributedStateUpdate;
 if (log.isInfoEnabled()) {
   log.info(
-  "Creating DistributedClusterStateUpdater with 
useDistributedStateUpdate="
-  + useDistributedStateUpdate
-  + ". Solr will be using "
-  + (useDistributedStateUpdate ? "distributed" : "Overseer based")
-  + " cluster state updates."); // nowarn
+  "Creating DistributedClusterStateUpdater with 
useDistributedStateUpdate={}. Solr will be using {} cluster state updates.",

Review Comment:
   I suggest we log nothing _here_.  Instead log in ZkController initialization 
to say whether the Overseer is enabled or disabled.  Don't bother doing so in 
this PR; it better belongs in #3524 in ZkController when `overseerEnabled` is 
determined.  I'll do that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]