Re: [PR] SOLR-16470: Include IOException in logs when DirectoryFileStream fails [solr]
mlbiscoc merged PR #3373: URL: https://github.com/apache/solr/pull/3373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-16470: Include IOException in logs when DirectoryFileStream fails [solr]
mlbiscoc commented on PR #3373: URL: https://github.com/apache/solr/pull/3373#issuecomment-2930849382 > I wonder why these logs are warnings. The fact that they are warnings is probably intentionally why the exception wasn't appended. The exception used to be appended but when doing the v2 migration for this API, exception was missed for logging. Here it was [before the v2](https://github.com/apache/solr/blob/a4eb7aa123dc53f8dac74d80b66a490f2d6b4a26/solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java#L1731) migration -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-16470: Include IOException in logs when DirectoryFileStream fails [solr]
dsmiley commented on PR #3373: URL: https://github.com/apache/solr/pull/3373#issuecomment-2928624158 This is too minor to warrant a CHANGES.txt -- see https://cwiki.apache.org/confluence/display/SOLR/Commit+Process+Guidelines#CommitProcessGuidelines-ExceptionsforMinorChanges I wonder why these logs are warnings. The fact that they are warnings is probably intentionally why the exception wasn't appended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-16470: Include IOException in logs when DirectoryFileStream fails [solr]
mlbiscoc commented on PR #3373: URL: https://github.com/apache/solr/pull/3373#issuecomment-2916551153 Thanks Jude for adding this. Could you also update [here as well](https://github.com/apache/solr/blob/72499dd5e753868e0779f3222c8db6bdf72dea3b/solr/core/src/java/org/apache/solr/handler/admin/api/ReplicationAPIBase.java#L519)? @gerlowskija SOLR-16470 was from a migration v2 migration. Do we still need `CHANGES.txt` entry for small changes like this and do we still want to reference the old SOLR-16470 v2 Jira for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-16470: Include IOException in logs when DirectoryFileStream fails [solr]
jkmuriithi commented on PR #3373: URL: https://github.com/apache/solr/pull/3373#issuecomment-2913898368 @mlbiscoc You're probably the best equipped to take a look at this, since you made the original PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
