Re: [PR] SOLR-16903: Switch CoreContainer#getSolrHome to return Path instead of String [solr]

[via GitHub]

dsmiley merged PR #3204:
URL: https://github.com/apache/solr/pull/3204


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Re: [PR] SOLR-16903: Switch CoreContainer#getSolrHome to return Path instead of String [solr]

[via GitHub]

dsmiley commented on PR #3204:
URL: https://github.com/apache/solr/pull/3204#issuecomment-2678884231

   I plan to merge this tonight; it's very straightforward


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Re: [PR] SOLR-16903: Switch CoreContainer#getSolrHome to return Path instead of String [solr]

[via GitHub]

AndreyBozhko commented on code in PR #3204:
URL: https://github.com/apache/solr/pull/3204#discussion_r1967834442


##
solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java:
##
@@ -145,7 +145,7 @@ public void handleRequestBody(SolrQueryRequest req, 
SolrQueryResponse rsp) throw
   rsp.add("zkHost", 
getCoreContainer(req).getZkController().getZkServerAddress());
 }
 if (cc != null) {
-  rsp.add("solr_home", cc.getSolrHome());
+  rsp.add("solr_home", cc.getSolrHome().toString());

Review Comment:
   Makes sense - the JavaBinCodec looks to be doing the same thing. 
https://github.com/apache/solr/blob/76c09a35dba42913a6bcb281b52b00f87564624a/solr/solrj/src/java/org/apache/solr/common/util/JavaBinCodec.java#L411-L413



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Re: [PR] SOLR-16903: Switch CoreContainer#getSolrHome to return Path instead of String [solr]

[via GitHub]

dsmiley commented on code in PR #3204:
URL: https://github.com/apache/solr/pull/3204#discussion_r1966904872


##
solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java:
##
@@ -145,7 +145,7 @@ public void handleRequestBody(SolrQueryRequest req, 
SolrQueryResponse rsp) throw
   rsp.add("zkHost", 
getCoreContainer(req).getZkController().getZkServerAddress());
 }
 if (cc != null) {
-  rsp.add("solr_home", cc.getSolrHome());
+  rsp.add("solr_home", cc.getSolrHome().toString());

Review Comment:
   Good eye!  I agree with removing toString here.  Whether toAbsolutePath 
should be called or not is another question from this PR; I'm ambivalent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Re: [PR] SOLR-16903: Switch CoreContainer#getSolrHome to return Path instead of String [solr]

[via GitHub]

AndreyBozhko commented on PR #3204:
URL: https://github.com/apache/solr/pull/3204#issuecomment-2676985912

   Sounds good, I updated the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org