Re: [PR] SOLR-17637: Fix LBHttpSolrClient & HttpShardHandler bug [solr]

2025-01-30 Thread via GitHub


HoustonPutman merged PR #3147:
URL: https://github.com/apache/solr/pull/3147


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] SOLR-17637: Fix LBHttpSolrClient & HttpShardHandler bug [solr]

2025-01-30 Thread via GitHub


gus-asf commented on PR #3147:
URL: https://github.com/apache/solr/pull/3147#issuecomment-2625307927

   Nice catch! thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] SOLR-17637: Fix LBHttpSolrClient & HttpShardHandler bug [solr]

2025-01-29 Thread via GitHub


HoustonPutman commented on PR #3147:
URL: https://github.com/apache/solr/pull/3147#issuecomment-2623621771

   > Just curious; I suppose this bug might show as an NPE?
   
   It doesnt show at all. The thread thats running the async request fails, and 
since its not in the catch, it doesnt pass the exception to the completion 
step. So the thread just goes away without logging anything. Took a while to 
pin it down because of this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] SOLR-17637: Fix LBHttpSolrClient & HttpShardHandler bug [solr]

2025-01-29 Thread via GitHub


dsmiley commented on PR #3147:
URL: https://github.com/apache/solr/pull/3147#issuecomment-2623522751

   Just curious; I suppose this bug might show as an NPE?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] SOLR-17637: Fix LBHttpSolrClient & HttpShardHandler bug [solr]

2025-01-29 Thread via GitHub


markrmiller commented on PR #3147:
URL: https://github.com/apache/solr/pull/3147#issuecomment-2623245074

   Nice catch. Patch looks good. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]