Re: [PR] SOLR-17673: Disable multithreaded search at the node level by default [solr]
dsmiley commented on code in PR #3183: URL: https://github.com/apache/solr/pull/3183#discussion_r1980230626 ## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc: ## @@ -67,6 +67,12 @@ It is always strongly recommended that you fully reindex your documents after a In Solr 8, it was possible to add docValues to a schema without re-indexing via `UninvertDocValuesMergePolicy`, an advanced/expert utility. Due to changes in Lucene 9, that isn't possible any more. +== Solr 9.8.1 +=== Configuration +In solrconfig.xml, the `indexSearcherExecutorThreads` now defaults to 0. Review Comment: No; in solr.xml. I wish this had a default using an EnvUtils read so we needn't edit a config file to manipulate it. Env vars are more convenient for random/standalone toggles/configurables. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17673: Disable multithreaded search at the node level by default [solr]
HoustonPutman merged PR #3183: URL: https://github.com/apache/solr/pull/3183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17673: Disable multithreaded search at the node level by default [solr]
HoustonPutman commented on PR #3183: URL: https://github.com/apache/solr/pull/3183#issuecomment-2659998104 Ok, yeah, I was a bit lazy with the solution. But I agree that it should be possible. Though from my (probably bad) viewpoint, `0` would sound like "disabled" to me, and `-1` would sound more like "unlimited" kind of like `rows=0` vs `rows=-1`. Let me come up with something for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17673: Disable multithreaded search at the node level by default [solr]
risdenk commented on PR #3183: URL: https://github.com/apache/solr/pull/3183#issuecomment-2659988149 I know I missed reviewing this - but this completely removes the ability to have it figure out number of processors right? I wonder if it would make sense to set the default to -1 in the solr.xml we ship if the value is 0 - set to num processors, its its -1 disable, if anything else use that value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17673: Disable multithreaded search at the node level by default [solr]
HoustonPutman commented on PR #3183: URL: https://github.com/apache/solr/pull/3183#issuecomment-2657959260 > What's Varun's relation here? He did a lot of debugging for the first calling out of this: https://issues.apache.org/jira/browse/SOLR-17642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
