Re: [PR] SOLR-17677: Ensure DBQ is safe before running [solr]

2025-02-22 Thread via GitHub


dsmiley commented on PR #3203:
URL: https://github.com/apache/solr/pull/3203#issuecomment-2676413619

   It is trivial to ensure HashRangeQuery doesn't NEED SolrIndexSearcher: #3206


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] SOLR-17677: Ensure DBQ is safe before running [solr]

2025-02-21 Thread via GitHub


gerlowskija merged PR #3203:
URL: https://github.com/apache/solr/pull/3203


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] SOLR-17677: Ensure DBQ is safe before running [solr]

2025-02-21 Thread via GitHub


gerlowskija commented on PR #3203:
URL: https://github.com/apache/solr/pull/3203#issuecomment-2675454565

   Alright - looks like that was a problem on the 'main' I was based on - there 
was a revert on main and I've rebased on that now.
   
   Should be good to go.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] SOLR-17677: Ensure DBQ is safe before running [solr]

2025-02-21 Thread via GitHub


gerlowskija commented on PR #3203:
URL: https://github.com/apache/solr/pull/3203#issuecomment-2674963541

   Check and tests pass for me locally.
   
   The `precommit` PR check fails with the error below, but this is almost 
certainly unrelated to the PR.  Will investigate a bit though to see if I can 
resolve...
   
   ```
   
/home/runner/work/solr/solr/solr/core/src/java/org/apache/solr/cloud/OverseerTaskProcessor.java:505:
 error: cannot find symbol
   } catch (AlreadyClosedException ignored) {
^
 symbol:   class AlreadyClosedException
 location: class OverseerTaskProcessor
   > Task :solr:core:compileJava
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]