Re: [PR] SOLR-17677: HashRangeQuery doesn't NEED SolrIndexSearcher [solr]
dsmiley commented on code in PR #3206:
URL: https://github.com/apache/solr/pull/3206#discussion_r1967881072
##
solr/core/src/java/org/apache/solr/search/join/HashRangeQuery.java:
##
@@ -91,6 +96,9 @@ private int[] getCache(LeafReaderContext context) throws
IOException {
if (cacheHelper == null) {
return null;
}
+if (!(searcher instanceof SolrIndexSearcher)) { // e.g. delete-by-query
Review Comment:
It's telling that the cache this thing uses is completely optional. You
have to go out of your way to register it in your solrconfig.xml. So this
query definitely doesn't need it, and it's likely people are using this query
without this cache given how easy it would be to forget to configure it or even
know about it.
There's no degraded performance concern since it hasn't been working at all
in a DBQ :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17677: HashRangeQuery doesn't NEED SolrIndexSearcher [solr]
dsmiley merged PR #3206: URL: https://github.com/apache/solr/pull/3206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17677: HashRangeQuery doesn't NEED SolrIndexSearcher [solr]
gerlowskija commented on code in PR #3206:
URL: https://github.com/apache/solr/pull/3206#discussion_r1967557670
##
solr/core/src/java/org/apache/solr/search/join/HashRangeQuery.java:
##
@@ -91,6 +96,9 @@ private int[] getCache(LeafReaderContext context) throws
IOException {
if (cacheHelper == null) {
return null;
}
+if (!(searcher instanceof SolrIndexSearcher)) { // e.g. delete-by-query
Review Comment:
[Q] How important is the caching, do you know? Is it enough of a change
that it's worth documenting the degraded performance when run as a DBQ?
(Not implying it is, just asking from a due-diligence perspective.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17677: HashRangeQuery doesn't NEED SolrIndexSearcher [solr]
dsmiley commented on PR #3206: URL: https://github.com/apache/solr/pull/3206#issuecomment-2676422679 Tests pass (GHA for Crave is still out-of-commission) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
