Re: [PR] SOLR-17698: Remove deprecated EnumField [solr]
HoustonPutman commented on PR #3256: URL: https://github.com/apache/solr/pull/3256#issuecomment-2977374703 @epugh this has broken `TestUseDocValuesAsStored.testDuplicateMultiValued` and `TestUseDocValuesAsStored. testRandomSingleAndMultiValued ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17698: Remove deprecated EnumField [solr]
epugh merged PR #3256: URL: https://github.com/apache/solr/pull/3256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17698: Remove deprecated EnumField [solr]
epugh commented on PR #3256: URL: https://github.com/apache/solr/pull/3256#issuecomment-2777891064 @dsmiley in https://github.com/apache/solr/pull/3256/commits/50743bd2d9b2c4e62e41c35f66d0325ad409 I figured out we need docvalues for EnumFieldType to work. In searching, I see lots of EnumFieldType's in lots of test schemas, and no docvalues specified, but the tests appear to pass... Should I go through and remove EnumFieldType from schemas that dont' appear to need it? I think it's in places as part of a lot of copy n paste over the years... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17698: Remove deprecated EnumField [solr]
dsmiley commented on PR #3256: URL: https://github.com/apache/solr/pull/3256#issuecomment-2778648557 Fixed it. You replaced org.apache.solr.schema.EnumFieldType#getSortField with that of the base class. If you remove an intermediate class in the hierarchy inline to a subclass, don't replace the methods of the subclass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17698: Remove deprecated EnumField [solr]
epugh commented on PR #3256: URL: https://github.com/apache/solr/pull/3256#issuecomment-2778017080 On re-reading refguide it appears that "SORTED_NUMERIC" is actually correct for the `EnumFieldType`. Not sure how to handle this test... Maybe the test assumed EnumField only? And never tested EnumFieldType? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17698: Remove deprecated EnumField [solr]
epugh commented on PR #3256: URL: https://github.com/apache/solr/pull/3256#issuecomment-2778011765 Eric, don't forget to edit https://solr.apache.org/guide/solr/latest/indexing-guide/docvalues.html and remove `EnumField` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17698: Remove deprecated EnumField [solr]
epugh commented on PR #3256: URL: https://github.com/apache/solr/pull/3256#issuecomment-2778002263 Going to need some help! I am getting this error: ``` 10746 ERROR (TEST-TestMinMaxOnMultiValuedField.testExpectedSortMissingOrderings-seed#[48FFD9DEBAEFAB26]) [n: c: s: r: x: t:] o.a.s.h.RequestHandlerBase Server exception => java.lang.IllegalStateException: unexpected docvalues type SORTED_NUMERIC for field 'val_enum_missf_s_dv' (expected one of [SORTED, SORTED_SET]). Re-index with correct docvalues type. at org.apache.lucene.index.DocValues.checkField(DocValues.java:218) java.lang.IllegalStateException: unexpected docvalues type SORTED_NUMERIC for field 'val_enum_missf_s_dv' (expected one of [SORTED, SORTED_SET]). Re-index with correct docvalues type. at org.apache.lucene.index.DocValues.checkField(DocValues.java:218) ~[lucene-core-9.12.1.jar:9.12.1 7a97a05a239d6fb9f1f347aa09bfa52e875be092 - 2024-12-09 16:47:48] ``` This is despite `schema11.xml` being set up with `multiValued=true`, which according to https://solr.apache.org/guide/solr/latest/indexing-guide/docvalues.html means we should be using SORTED_SET. Reproduce with: ``` ./gradlew :solr:core:test --tests "org.apache.solr.search.function.TestMinMaxOnMultiValuedField.testExpectedSortMissingOrderings" "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=3508D580E8F3D51C -Ptests.useSecurityManager=true -Ptests.file.encoding=UTF-8 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17698: Remove deprecated EnumField [solr]
epugh commented on PR #3256: URL: https://github.com/apache/solr/pull/3256#issuecomment-2715392532 Looks like we could eliminate `AbstractEnumField` now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
