Re: [PR] SOLR-17738: DocTransformer, remove deprecated methods [solr]
HoustonPutman commented on PR #3320: URL: https://github.com/apache/solr/pull/3320#issuecomment-2831393359 Thanks for the contribution @abumarjikar ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17738: DocTransformer, remove deprecated methods [solr]
HoustonPutman merged PR #3320: URL: https://github.com/apache/solr/pull/3320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17738: DocTransformer, remove deprecated methods [solr]
abumarjikar commented on PR #3320: URL: https://github.com/apache/solr/pull/3320#issuecomment-2800552888 @HoustonPutman Are we good to close this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17738: DocTransformer, remove deprecated methods [solr]
abumarjikar commented on PR #3320: URL: https://github.com/apache/solr/pull/3320#issuecomment-2798364889 @HoustonPutman This makes more sense, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17738: DocTransformer, remove deprecated methods [solr]
HoustonPutman commented on PR #3320: URL: https://github.com/apache/solr/pull/3320#issuecomment-2798195297 This looks great, I made it so that `null` is not expected, so we don't have to check for that. And now, `DocStreamer` does not check if scores exist before passing `docInfo`. This makes it so that in the future, non-score information can be used in `DocIterationInfo`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
