Re: [PR] SOLR-17742: remove handleSelect requestDispatcher option [solr]
dsmiley merged PR #3409: URL: https://github.com/apache/solr/pull/3409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17742: remove handleSelect requestDispatcher option [solr]
dsmiley commented on code in PR #3409:
URL: https://github.com/apache/solr/pull/3409#discussion_r2283959339
##
solr/core/src/resources/EditableSolrConfigAttributes.json:
##
@@ -1,14 +1,4 @@
{
-//---legend--
Review Comment:
yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17742: remove handleSelect requestDispatcher option [solr]
wildtusker commented on code in PR #3409:
URL: https://github.com/apache/solr/pull/3409#discussion_r2283970239
##
solr/core/src/resources/EditableSolrConfigAttributes.json:
##
@@ -1,14 +1,4 @@
{
-//---legend--
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17742: remove handleSelect requestDispatcher option [solr]
wildtusker commented on code in PR #3409:
URL: https://github.com/apache/solr/pull/3409#discussion_r2283829110
##
solr/core/src/resources/EditableSolrConfigAttributes.json:
##
@@ -1,14 +1,4 @@
{
-//---legend--
Review Comment:
Should i go ahead and commit anyway and push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17742: remove handleSelect requestDispatcher option [solr]
wildtusker commented on code in PR #3409:
URL: https://github.com/apache/solr/pull/3409#discussion_r2283825522
##
solr/core/src/resources/EditableSolrConfigAttributes.json:
##
@@ -1,14 +1,4 @@
{
-//---legend--
Review Comment:
Removed in config-api.adoc . EditableSolrConfigAttributes.json was showing
comments as error .This made me remove it.Not aware of the legends .When i
commit it says Commit and push checks failed . Shared the screen shot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17742: remove handleSelect requestDispatcher option [solr]
dsmiley commented on code in PR #3409:
URL: https://github.com/apache/solr/pull/3409#discussion_r2283094108
##
solr/core/src/resources/EditableSolrConfigAttributes.json:
##
@@ -1,14 +1,4 @@
{
-//---legend--
Review Comment:
why did you remove this useful legend?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17742: remove handleSelect requestDispatcher option [solr]
wildtusker commented on PR #3409: URL: https://github.com/apache/solr/pull/3409#issuecomment-3197726671 > I pushed one change to remove an obsolete comment. > > The asciidoc (`.adoc` files) is all that remains. The doc is updated .Handle Select removed from the document. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17742: remove handleSelect requestDispatcher option [solr]
dsmiley commented on PR #3409: URL: https://github.com/apache/solr/pull/3409#issuecomment-3186892839 I pushed one change to remove an obsolete comment. The asciidoc (`.adoc` files) is all that remains. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17742: remove handleSelect requestDispatcher option [solr]
wildtusker commented on PR #3409: URL: https://github.com/apache/solr/pull/3409#issuecomment-3175953169 > @wildtusker your comment is referring to files you supposedly did something to and are thus "Done"... yet this PR isn't showing such changes. I suspect you simply didn't push changes. Pushed the changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17742: remove handleSelect requestDispatcher option [solr]
dsmiley commented on PR #3409: URL: https://github.com/apache/solr/pull/3409#issuecomment-3175157187 @wildtusker your comment is referring to files you supposedly did something to and are thus "Done"... yet this PR isn't showing such changes. I suspect you simply didn't push changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17742: remove handleSelect requestDispatcher option [solr]
wildtusker commented on PR #3409:
URL: https://github.com/apache/solr/pull/3409#issuecomment-3172344898
In some files changes have been made and test cases pass.In some files
handleselect is mentioned but clarity is not there what needs to be removed.
[6:34](https://apachesolr.slack.com/archives/D08S18704UT/p1754744681250969)
List of files : TestConfigOverlay Done
TestRemoteStreaming Done
EditableSolrConfigAttributes Done
Query.js Done
schema-designer.js Done
SolrTable.java ( Handle Select tuple is there in the file .The instance gets
created when metricslist and buckets is empty. )
requestDispathcher.adoc (Documentation for handleselect needs to be removed
) (edited)
if (metricPairs.isEmpty() && buckets.isEmpty()) {
tupleStream = handleSelect(zk, collection, q, fields, orders, limit,
offset);
}
> Please search for "handleSelect" more thoroughly. Your changes here are
good but incomplete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17742: remove handleSelect requestDispatcher option [solr]
epugh commented on PR #3409: URL: https://github.com/apache/solr/pull/3409#issuecomment-3073366927 > Wondering if ref-guide references could be removed too: https://github.com/search?q=repo%3Aapache%2Fsolr+handleSelect+language%3AAsciiDoc&type=code&l=AsciiDoc this seems like it makes sense! Nice example of using github search by the way! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17742: remove handleSelect requestDispatcher option [solr]
cpoerschke commented on PR #3409: URL: https://github.com/apache/solr/pull/3409#issuecomment-3062990795 Wondering if ref-guide references could be removed too: https://github.com/search?q=repo%3Aapache%2Fsolr+handleSelect+language%3AAsciiDoc&type=code&l=AsciiDoc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
