Re: [PR] SOLR-17789: Fix Internode Authorization not working for external roles [solr]
dsmiley merged PR #3397: URL: https://github.com/apache/solr/pull/3397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17789: Fix Internode Authorization not working for external roles [solr]
bct-timo-crabbe commented on PR #3397: URL: https://github.com/apache/solr/pull/3397#issuecomment-3073387416 Can we still merge this in the upcoming 9.9 release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17789: Fix Internode Authorization not working for external roles [solr]
bct-timo-crabbe commented on code in PR #3397:
URL: https://github.com/apache/solr/pull/3397#discussion_r2160806373
##
solr/modules/jwt-auth/src/test/org/apache/solr/security/jwt/JWTAuthPluginIntegrationTest.java:
##
@@ -290,6 +291,53 @@ public void testMetrics() throws Exception {
HttpClientUtil.close(cl);
}
+ /**
+ * Test if JWTPrincipal is passed correctly on internode communication.
Setup a cluster with more
+ * nodes using jwtAuth for both authentication and authorization.Add a
private collection with
Review Comment:
A private collection is a collection that is not publicly available i.e., a
collection where access has been restricted to certain user role(s). See the
authorization section in the `security.json` the new test is using:
`solr/modules/jwt-auth/src/test-files/solr/security/jwt_plugin_jwk_security_with_authorization.json`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17789: Fix Internode Authorization not working for external roles [solr]
dsmiley commented on code in PR #3397:
URL: https://github.com/apache/solr/pull/3397#discussion_r2159645849
##
solr/modules/jwt-auth/src/test/org/apache/solr/security/jwt/JWTAuthPluginIntegrationTest.java:
##
@@ -290,6 +291,53 @@ public void testMetrics() throws Exception {
HttpClientUtil.close(cl);
}
+ /**
+ * Test if JWTPrincipal is passed correctly on internode communication.
Setup a cluster with more
+ * nodes using jwtAuth for both authentication and authorization.Add a
private collection with
Review Comment:
```suggestion
* nodes using jwtAuth for both authentication and authorization. Add a
private collection with
```
What is a "private" collection?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
