Re: [PR] SOLR-18077: Fix incorrect request reuse, fix unit tests. [solr]
sigram merged PR #4396: URL: https://github.com/apache/solr/pull/4396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18077: Fix incorrect request reuse, fix unit tests. [solr]
sigram commented on code in PR #4396:
URL: https://github.com/apache/solr/pull/4396#discussion_r3190614196
##
solr/cross-dc-manager/src/java/org/apache/solr/crossdc/manager/consumer/KafkaCrossDcConsumer.java:
##
@@ -75,6 +75,8 @@
public class KafkaCrossDcConsumer extends Consumer.CrossDcConsumer {
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
Review Comment:
This exposes a really low-level info that IMHO is useful only for verifying
the key / partition assignments, so it makes sense for a developer but unlikely
useful to an ops person.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] SOLR-18077: Fix incorrect request reuse, fix unit tests. [solr]
epugh commented on code in PR #4396:
URL: https://github.com/apache/solr/pull/4396#discussion_r3190206081
##
solr/cross-dc-manager/src/java/org/apache/solr/crossdc/manager/consumer/KafkaCrossDcConsumer.java:
##
@@ -75,6 +75,8 @@
public class KafkaCrossDcConsumer extends Consumer.CrossDcConsumer {
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
Review Comment:
is this option so specific to a developer that no user would ever
concievable want to enable it? If it might be neabled by a user, it would be
nice to add it to our `solr-properties.adoc` file to explain what it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
