Re: [PR] Update enabling-ssl.adoc - fix minor typo in example [solr]

2025-02-15 Thread via GitHub


epugh commented on PR #3175:
URL: https://github.com/apache/solr/pull/3175#issuecomment-2661128777

   thank you for the fix!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



Re: [PR] Update enabling-ssl.adoc - fix minor typo in example [solr]

2025-02-15 Thread via GitHub


epugh merged PR #3175:
URL: https://github.com/apache/solr/pull/3175


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



Re: [PR] Update enabling-ssl.adoc - fix minor typo in example [solr]

2025-02-12 Thread via GitHub


epugh commented on PR #3175:
URL: https://github.com/apache/solr/pull/3175#issuecomment-2654043373

   I searched our ref guide for "solrcli" and yeah, the main page, the "Solr 
Control Script" page doesn't come up!:
   
   https://github.com/user-attachments/assets/a4bd3597-a972-4b84-a77d-8b1b888dd0b5";
 />
   
   
   We should add a "aka SolrCLI" on that page so it comes up!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



Re: [PR] Update enabling-ssl.adoc - fix minor typo in example [solr]

2025-02-12 Thread via GitHub


epugh commented on PR #3175:
URL: https://github.com/apache/solr/pull/3175#issuecomment-2654044758

   I just triggered the builds, and then this looks ready to merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



Re: [PR] Update enabling-ssl.adoc - fix minor typo in example [solr]

2025-02-12 Thread via GitHub


Kordishal commented on code in PR #3175:
URL: https://github.com/apache/solr/pull/3175#discussion_r1952792666


##
solr/solr-ref-guide/modules/deployment-guide/pages/enabling-ssl.adoc:
##
@@ -245,7 +245,7 @@ Windows::
 
 [source,powershell]
 
-C:\> bin/solr.cmd --property urlSchema --value https --zk-host 
server1:2181,server2:2181,server3:2181

Review Comment:
   I did not notice that. As I don't have a windows system I can't really 
confirm this. The script is running the cluster command with the solrcli class. 
So probably would be documented there.
   
   
https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/cli/SolrCLI.java
   
   and then uses:
   
   
https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/cli/ClusterTool.java
   
   SolrCli has a cluster command so probably this needs cluster too, but I have 
found no documentation of SolrCLI at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



Re: [PR] Update enabling-ssl.adoc - fix minor typo in example [solr]

2025-02-11 Thread via GitHub


epugh commented on PR #3175:
URL: https://github.com/apache/solr/pull/3175#issuecomment-2652190465

   And after reviewing, I opened 
https://issues.apache.org/jira/browse/SOLR-17668...   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



Re: [PR] Update enabling-ssl.adoc - fix minor typo in example [solr]

2025-02-11 Thread via GitHub


epugh commented on PR #3175:
URL: https://github.com/apache/solr/pull/3175#issuecomment-2652066509

   Okay, one thing to confirm, and then this looks good.   One shame is that 
this page 
https://solr.apache.org/guide/solr/latest/deployment-guide/solr-control-script-reference.html
 never mentions the "cluster" tool ;-(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



Re: [PR] Update enabling-ssl.adoc - fix minor typo in example [solr]

2025-02-11 Thread via GitHub


epugh commented on code in PR #3175:
URL: https://github.com/apache/solr/pull/3175#discussion_r1951584516


##
solr/solr-ref-guide/modules/deployment-guide/pages/enabling-ssl.adoc:
##
@@ -245,7 +245,7 @@ Windows::
 
 [source,powershell]
 
-C:\> bin/solr.cmd --property urlSchema --value https --zk-host 
server1:2181,server2:2181,server3:2181

Review Comment:
   Does this need a `bin/solr cluster` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org