Re: [PR] Upgrade Log4j to `2.25.1` [solr]
ppkarwasz commented on PR #3603: URL: https://github.com/apache/solr/pull/3603#issuecomment-3255314131 I switched this PR to draft, since we have scheduled a release `2.25.2` for next Monday, so I see no reason to upgrade twice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Upgrade Log4j to `2.25.1` [solr]
ppkarwasz commented on code in PR #3603: URL: https://github.com/apache/solr/pull/3603#discussion_r2319952721 ## solr/licenses/org.osgi.annotation.bundle-LICENSE-ASL.txt: ## @@ -0,0 +1,202 @@ + + Apache License + Version 2.0, January 2004 +http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION Review Comment: All artifacts that start with `org.osgi` come from the same repo and have the same `NOTICE` file. The current `validateJarLicenses` Gradle task only splits artifact names on `-`, not on `.`, but I can improve it in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Upgrade Log4j to `2.25.1` [solr]
risdenk commented on code in PR #3603:
URL: https://github.com/apache/solr/pull/3603#discussion_r2319657591
##
solr/modules/extraction/build.gradle:
##
@@ -19,6 +19,13 @@ apply plugin: 'java-library'
description = 'Solr Integration with Tika for extracting content from binary
file formats such as Microsoft Word and Adobe PDF'
+configurations.configureEach {
Review Comment:
Why was this added? Seems unrelated to this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] Upgrade Log4j to `2.25.1` [solr]
risdenk commented on PR #3603: URL: https://github.com/apache/solr/pull/3603#issuecomment-3250084988 FYI https://github.com/apache/solr/pull/2895 was another attempt prior to this. There was a comment about licenses needing to be reviewed as well. https://github.com/apache/solr/pull/2895?new_mergebox=true#pullrequestreview-2485195979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Upgrade Log4j to `2.25.1` [solr]
janhoy commented on code in PR #3603: URL: https://github.com/apache/solr/pull/3603#discussion_r2317351907 ## solr/licenses/org.osgi.annotation.bundle-LICENSE-ASL.txt: ## @@ -0,0 +1,202 @@ + + Apache License + Version 2.0, January 2004 +http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION Review Comment: If the LICENSE and NOTICE files are the same for these two osgi artifacts, it is sufficient with one named `org.osgi.annotation-LICENSE-ASL.txt` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
