Re: [PR] feat: support specifying the configuration of the checkpoint collection [solr]
1995chen closed pull request #3278: feat: support specifying the configuration of the checkpoint collection URL: https://github.com/apache/solr/pull/3278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] feat: support specifying the configuration of the checkpoint collection [solr]
epugh commented on PR #3278: URL: https://github.com/apache/solr/pull/3278#issuecomment-2810099575 @1995chen looks like you have some precommit errors to fix? Also, for this change, I don't see a unit test, do we have that already covered? I also would like some updates to the Reference Guide to cover these changes! We need to communicate how to use this new feature so it get's adopted and isn't a hidden thing! What is prompting the need to make these configurable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] feat: support specifying the configuration of the checkpoint collection [solr]
cpoerschke commented on PR #3278: URL: https://github.com/apache/solr/pull/3278#issuecomment-2808856754 > @cpoerschke could you please help me review this pr again Unfortunately I'm not sufficiently familiar with this functionality to meaningfully review. Based on https://issues.apache.org/jira/browse/SOLR-11127 history tagging @sigram @janhoy @dsmiley @chatman as potential reviewers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] feat: support specifying the configuration of the checkpoint collection [solr]
1995chen commented on PR #3278: URL: https://github.com/apache/solr/pull/3278#issuecomment-2803504386 @cpoerschke could you please help me review this pr again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] feat: support specifying the configuration of the checkpoint collection [solr]
1995chen commented on code in PR #3278:
URL: https://github.com/apache/solr/pull/3278#discussion_r2041403245
##
solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java:
##
@@ -590,6 +590,7 @@ public enum CollectionOperation implements CollectionOp {
CREATE_NODE_SET,
CREATE_NODE_SET_SHUFFLE,
"shards",
+ "chkConfigName",
Review Comment:
yeah, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] feat: support specifying the configuration of the checkpoint collection [solr]
cpoerschke commented on code in PR #3278:
URL: https://github.com/apache/solr/pull/3278#discussion_r2039393284
##
solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java:
##
@@ -590,6 +590,7 @@ public enum CollectionOperation implements CollectionOp {
CREATE_NODE_SET,
CREATE_NODE_SET_SHUFFLE,
"shards",
+ "chkConfigName",
Review Comment:
maybe use a constant similar to lines 584-586 above
```suggestion
ReindexCollectionCmd.CHK_CONFIG_NAME,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] feat: support specifying the configuration of the checkpoint collection [solr]
1995chen commented on PR #3278: URL: https://github.com/apache/solr/pull/3278#issuecomment-2742418907 @HoustonPutman can you help me review this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
