hgeraldino commented on code in PR #14663:
URL: https://github.com/apache/kafka/pull/14663#discussion_r1477107060
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java:
##
@@ -1994,53 +1616,6 @@ private void expectInitializeTask() {
P
gharris1727 commented on code in PR #14663:
URL: https://github.com/apache/kafka/pull/14663#discussion_r1473603606
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java:
##
@@ -1994,53 +1616,6 @@ private void expectInitializeTask() {
hgeraldino commented on PR #14663:
URL: https://github.com/apache/kafka/pull/14663#issuecomment-1913670929
Thanks @gharris1727 for your thorough review. I've addressed most of yours
(and @C0urante's) comments. One thing I didn't address was refactoring the
`testErrorInRebalance*` tests, th
hgeraldino commented on code in PR #14663:
URL: https://github.com/apache/kafka/pull/14663#discussion_r1468904434
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskMockitoTest.java:
##
@@ -0,0 +1,763 @@
+/*
+ * Licensed to the Apache Software Founda
hgeraldino commented on code in PR #14663:
URL: https://github.com/apache/kafka/pull/14663#discussion_r1468902115
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskMockitoTest.java:
##
@@ -0,0 +1,763 @@
+/*
+ * Licensed to the Apache Software Founda
hgeraldino commented on code in PR #14663:
URL: https://github.com/apache/kafka/pull/14663#discussion_r1468901352
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskMockitoTest.java:
##
@@ -0,0 +1,763 @@
+/*
+ * Licensed to the Apache Software Founda
hgeraldino commented on code in PR #14663:
URL: https://github.com/apache/kafka/pull/14663#discussion_r1468900996
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskMockitoTest.java:
##
@@ -0,0 +1,763 @@
+/*
+ * Licensed to the Apache Software Founda
hgeraldino commented on code in PR #14663:
URL: https://github.com/apache/kafka/pull/14663#discussion_r1468126514
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskMockitoTest.java:
##
@@ -0,0 +1,763 @@
+/*
+ * Licensed to the Apache Software Founda
C0urante commented on code in PR #14663:
URL: https://github.com/apache/kafka/pull/14663#discussion_r1462683025
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskMockitoTest.java:
##
@@ -0,0 +1,763 @@
+/*
+ * Licensed to the Apache Software Foundati
hgeraldino commented on code in PR #14663:
URL: https://github.com/apache/kafka/pull/14663#discussion_r1462636635
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskMockitoTest.java:
##
@@ -0,0 +1,763 @@
+/*
+ * Licensed to the Apache Software Founda
C0urante commented on code in PR #14663:
URL: https://github.com/apache/kafka/pull/14663#discussion_r1462026178
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskMockitoTest.java:
##
@@ -0,0 +1,763 @@
+/*
+ * Licensed to the Apache Software Foundati
hgeraldino commented on PR #14663:
URL: https://github.com/apache/kafka/pull/14663#issuecomment-1891034358
> > Hi @hgeraldino Thanks for taking on the migration!
> > I understand the idea behind your refactor-then-deduplicate strategy,
but I think the excessive duplication is making it di
hgeraldino commented on PR #14663:
URL: https://github.com/apache/kafka/pull/14663#issuecomment-1887674876
> Hi @hgeraldino Thanks for taking on the migration!
>
> I understand the idea behind your refactor-then-deduplicate strategy, but
I think the excessive duplication is making it
gharris1727 commented on PR #14663:
URL: https://github.com/apache/kafka/pull/14663#issuecomment-1883616431
Hi @hgeraldino Thanks for taking on the migration!
I understand the idea behind your refactor-then-deduplicate strategy, but I
think the excessive duplication is making it diffi
mimaison commented on PR #14663:
URL: https://github.com/apache/kafka/pull/14663#issuecomment-1880869214
It would be good to get @gharris1727 / @C0urante to take a look too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
hgeraldino commented on PR #14663:
URL: https://github.com/apache/kafka/pull/14663#issuecomment-1879789295
Ok here's the first batch which includes 7 migrated tests.
There is a lot of code duplication as I tried to keep all the mocks local to
each test, the expectation is that once a
ijuma commented on PR #14663:
URL: https://github.com/apache/kafka/pull/14663#issuecomment-1840644028
I think 7-8 tests at a time (4-5 PRs overall) is probably a reasonable
balance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
hgeraldino commented on PR #14663:
URL: https://github.com/apache/kafka/pull/14663#issuecomment-1806906866
One thing I'd like to know is if this approach of multiple bite-sized PRs
seems reasonable or not.
Future PRs might include refactor of more than one method, but I'll try my
be
mimaison commented on PR #14663:
URL: https://github.com/apache/kafka/pull/14663#issuecomment-1802170828
It's such a big file that doing it incrementally may make the reviews
easier. That said a lot of changes should be mechanical and similar across all
tests so we probably don't want to do
hgeraldino commented on PR #14663:
URL: https://github.com/apache/kafka/pull/14663#issuecomment-1800971956
One thing I'd like to know is if this approach of multiple bite-sized PRs
seems reasonable or not.
Future PRs might include refactor of more than one method, but I'll try my
be
divijvaidya commented on PR #14663:
URL: https://github.com/apache/kafka/pull/14663#issuecomment-1788790638
@clolov would you like to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hgeraldino opened a new pull request, #14663:
URL: https://github.com/apache/kafka/pull/14663
Instead of having a single big bang PR to migrate
[WorkerSinkTaskTest](https://github.com/apache/kafka/blob/trunk/connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.ja
22 matches
Mail list logo
