mjsax merged PR #14907:
URL: https://github.com/apache/kafka/pull/14907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mjsax commented on code in PR #14907:
URL: https://github.com/apache/kafka/pull/14907#discussion_r1419763796
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##
@@ -254,12 +255,12 @@ private QueryResult runRangeQuery(final Query
quer
mjsax commented on code in PR #14907:
URL: https://github.com/apache/kafka/pull/14907#discussion_r1419762701
##
streams/src/main/java/org/apache/kafka/streams/query/TimestampedRangeQuery.java:
##
@@ -100,17 +99,25 @@ public boolean isKeyAscending() {
* @return a new RangeQ
hanyuzheng7 commented on code in PR #14907:
URL: https://github.com/apache/kafka/pull/14907#discussion_r1416485410
##
streams/src/main/java/org/apache/kafka/streams/query/RangeQuery.java:
##
@@ -59,25 +58,25 @@ private RangeQuery(final Optional lower, final
Optional upper, fina
hanyuzheng7 commented on code in PR #14907:
URL: https://github.com/apache/kafka/pull/14907#discussion_r1416484369
##
streams/src/main/java/org/apache/kafka/streams/query/RangeQuery.java:
##
@@ -59,25 +58,25 @@ private RangeQuery(final Optional lower, final
Optional upper, fina
hanyuzheng7 commented on code in PR #14907:
URL: https://github.com/apache/kafka/pull/14907#discussion_r1416484212
##
streams/src/main/java/org/apache/kafka/streams/query/RangeQuery.java:
##
@@ -59,25 +58,25 @@ private RangeQuery(final Optional lower, final
Optional upper, fina
hanyuzheng7 commented on code in PR #14907:
URL: https://github.com/apache/kafka/pull/14907#discussion_r1416481880
##
streams/src/main/java/org/apache/kafka/streams/query/TimestampedRangeQuery.java:
##
@@ -82,25 +81,25 @@ public static TimestampedRangeQuery
withUpperBound(fina
hanyuzheng7 commented on code in PR #14907:
URL: https://github.com/apache/kafka/pull/14907#discussion_r1416481604
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java:
##
@@ -205,12 +206,12 @@ private QueryResult runTimestamped
hanyuzheng7 commented on code in PR #14907:
URL: https://github.com/apache/kafka/pull/14907#discussion_r1416481443
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##
@@ -254,12 +255,12 @@ private QueryResult runRangeQuery(final Query
mjsax commented on code in PR #14907:
URL: https://github.com/apache/kafka/pull/14907#discussion_r1414425643
##
streams/src/main/java/org/apache/kafka/streams/query/TimestampedRangeQuery.java:
##
@@ -82,25 +81,25 @@ public static TimestampedRangeQuery
withUpperBound(final K up
mjsax commented on code in PR #14907:
URL: https://github.com/apache/kafka/pull/14907#discussion_r1414426924
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java:
##
@@ -268,12 +269,12 @@ private QueryResult runRangeQuery(final
mjsax commented on code in PR #14907:
URL: https://github.com/apache/kafka/pull/14907#discussion_r1414425445
##
streams/src/main/java/org/apache/kafka/streams/query/TimestampedRangeQuery.java:
##
@@ -82,25 +81,25 @@ public static TimestampedRangeQuery
withUpperBound(final K up
mjsax commented on code in PR #14907:
URL: https://github.com/apache/kafka/pull/14907#discussion_r1414426563
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java:
##
@@ -205,12 +206,12 @@ private QueryResult runTimestampedRangeQ
mjsax commented on code in PR #14907:
URL: https://github.com/apache/kafka/pull/14907#discussion_r1414426281
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##
@@ -254,12 +255,12 @@ private QueryResult runRangeQuery(final Query
quer
mjsax commented on code in PR #14907:
URL: https://github.com/apache/kafka/pull/14907#discussion_r1414424741
##
streams/src/main/java/org/apache/kafka/streams/query/RangeQuery.java:
##
@@ -59,25 +58,25 @@ private RangeQuery(final Optional lower, final
Optional upper, final bool
mjsax commented on code in PR #14907:
URL: https://github.com/apache/kafka/pull/14907#discussion_r1414424355
##
streams/src/main/java/org/apache/kafka/streams/query/RangeQuery.java:
##
@@ -59,25 +58,25 @@ private RangeQuery(final Optional lower, final
Optional upper, final bool
hanyuzheng7 opened a new pull request, #14907:
URL: https://github.com/apache/kafka/pull/14907
Support `ResultOrder` to `TimestampedRangeQuery`.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build stat
17 matches
Mail list logo