[GH] (airflow/fix/eks-pod-operator-credential-refresh-issue-57585): Workflow run "Tests" failed!
The GitHub Actions job "Tests" on airflow.git/fix/eks-pod-operator-credential-refresh-issue-57585 has failed. Run started by GitHub user aviralgarg05 (triggered by eladkal). Head commit for run: 9098954f44b643412ffaf3abd88b5222fb508b64 / aviralgarg05 Fix EKS provider CI failures in ruff and waiter tests Report URL: https://github.com/apache/airflow/actions/runs/21897769712 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[GH] (airflow/fix/eks-pod-operator-credential-refresh-issue-57585): Workflow run "Tests" failed!
The GitHub Actions job "Tests" on airflow.git/fix/eks-pod-operator-credential-refresh-issue-57585 has failed. Run started by GitHub user eladkal (triggered by eladkal). Head commit for run: 545f65888fb0cc42aad7bb0d9cae87b4acad04f2 / aviralgarg05 Fix: Initialize result variable in extract_xcom_json to prevent NameError The result variable was only assigned inside the with block, but was referenced outside it. If kubernetes_stream() or any operation inside the with block raised an exception before result was assigned, accessing result at line 920 would cause a NameError. Initialize result = None before the with block to ensure it's always defined. Report URL: https://github.com/apache/airflow/actions/runs/21703888165 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[GH] (airflow/fix/eks-pod-operator-credential-refresh-issue-57585): Workflow run "Tests" failed!
The GitHub Actions job "Tests" on airflow.git/fix/eks-pod-operator-credential-refresh-issue-57585 has failed. Run started by GitHub user aviralgarg05 (triggered by eladkal). Head commit for run: 1ae781a7b7d9897cb41ee2cf965280cccb698daf / Aviral Garg Merge branch 'main' into fix/eks-pod-operator-credential-refresh-issue-57585 Report URL: https://github.com/apache/airflow/actions/runs/21285234106 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[GH] (airflow/fix/eks-pod-operator-credential-refresh-issue-57585): Workflow run "Tests" failed!
The GitHub Actions job "Tests" on airflow.git/fix/eks-pod-operator-credential-refresh-issue-57585 has failed. Run started by GitHub user aviralgarg05 (triggered by potiuk). Head commit for run: 912eafa134e6c2b826ec396ac3acca7ce038875e / aviralgarg05 Fix test_pod_manager.py mock error Report URL: https://github.com/apache/airflow/actions/runs/21073018619 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[GH] (airflow/fix/eks-pod-operator-credential-refresh-issue-57585): Workflow run "Tests" failed!
The GitHub Actions job "Tests" on airflow.git/fix/eks-pod-operator-credential-refresh-issue-57585 has failed. Run started by GitHub user aviralgarg05 (triggered by eladkal). Head commit for run: 5a96f509b15f826c595d474b57d07c77c8ed4ead / aviralgarg05 Fix failures in MyPy, Static checks and Provider tests - Fix NameError in type hint in pod_manager.py - Handle missing resource_version_match in older kubernetes clients in pod_manager.py - Add assertions in eks.py to satisfy MyPy type narrowing Report URL: https://github.com/apache/airflow/actions/runs/21068135895 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[GH] (airflow/fix/eks-pod-operator-credential-refresh-issue-57585): Workflow run "Tests" failed!
The GitHub Actions job "Tests" on airflow.git/fix/eks-pod-operator-credential-refresh-issue-57585 has failed. Run started by GitHub user aviralgarg05 (triggered by vincbeck). Head commit for run: 94c974d68b9e7e5aa45753a815bd5bcdda6c273b / Aviral Garg Merge branch 'main' into fix/eks-pod-operator-credential-refresh-issue-57585 Report URL: https://github.com/apache/airflow/actions/runs/20843254685 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[GH] (airflow/fix/eks-pod-operator-credential-refresh-issue-57585): Workflow run "Tests" failed!
The GitHub Actions job "Tests" on airflow.git/fix/eks-pod-operator-credential-refresh-issue-57585 has failed. Run started by GitHub user aviralgarg05 (triggered by o-nikolas). Head commit for run: 211edfbc0d7245e98421fbfa19e4ecfa491d63db / aviralgarg05 Fix static type error in container_log_times assignment Add None check before assigning to container_log_times dictionary to satisfy mypy type checking. The dictionary is typed as dict[tuple[str, str, str], DateTime], so we must ensure we don't assign None values. Fixes the error: providers/cncf/kubernetes/.../pod_manager.py:495: error: Incompatible types in assignment (expression has type 'DateTime | None', target has type 'DateTime') Report URL: https://github.com/apache/airflow/actions/runs/20378590182 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[GH] (airflow/fix/eks-pod-operator-credential-refresh-issue-57585): Workflow run "Tests" failed!
The GitHub Actions job "Tests" on airflow.git/fix/eks-pod-operator-credential-refresh-issue-57585 has failed. Run started by GitHub user aviralgarg05 (triggered by vincbeck). Head commit for run: 0900bbd2ec5e0ea55a32ef37e5eaa4af871fa4b6 / Aviral Garg Merge branch 'main' into fix/eks-pod-operator-credential-refresh-issue-57585 Report URL: https://github.com/apache/airflow/actions/runs/19974951498 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[GH] (airflow/fix/eks-pod-operator-credential-refresh-issue-57585): Workflow run "Tests" failed!
The GitHub Actions job "Tests" on airflow.git/fix/eks-pod-operator-credential-refresh-issue-57585 has failed. Run started by GitHub user aviralgarg05 (triggered by vincbeck). Head commit for run: 3e2fcfd25640c00c44e4a4658db1a3ebaf59c002 / aviralgarg05 Address PR review feedback: improve security and documentation 1. Fix CodeQL security alert for clear-text credential storage: - Use os.open with O_WRONLY|O_TRUNC and restrictive permissions (0600) - Use os.fdopen to properly handle file descriptor - Add proper exception handling for file descriptor cleanup - Match the same security pattern used in EksHook._secure_credential_context 2. Address vincbeck's review question about where 401 handling occurs: - Updated _refresh_cached_properties docstring with detailed call chain - Documents that KubernetesPodOperator._handle_api_exception triggers refresh - References the exact file path: providers/cncf/kubernetes/operators/pod.py - Explains the complete flow from 401 error to credential refresh 3. Move os and stat imports to module level for consistency with codebase style Report URL: https://github.com/apache/airflow/actions/runs/19969022093 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[GH] (airflow/fix/eks-pod-operator-credential-refresh-issue-57585): Workflow run "Tests" failed!
The GitHub Actions job "Tests" on airflow.git/fix/eks-pod-operator-credential-refresh-issue-57585 has failed. Run started by GitHub user aviralgarg05 (triggered by vincbeck). Head commit for run: 220f77bc8e26b56f532c235ea314b6e09e0ec03d / aviralgarg05 Fix EksPodOperator credential refresh for long-running tasks When EKS pods run longer than STS token lifetime (~15 minutes for assumed roles), the Kubernetes API returns 401 errors. The existing _refresh_cached_properties() method only resets the hook/client/pod_manager but doesn't refresh the AWS credentials file that the kubeconfig exec credential plugin reads from. This commit adds proper credential refresh by: 1. Storing the credentials file path during execute() and trigger_reentry() so it can be updated during reconnection attempts 2. Overriding _refresh_cached_properties() in EksPodOperator to: - Get fresh credentials from AWS via EksHook session - Write the new credentials to the existing credentials file - Call the parent implementation to reset Kubernetes clients 3. Adding _write_credentials_to_file() helper method to update the credentials file that the exec credential plugin sources This ensures that when a 401 error triggers _refresh_cached_properties(), the kubeconfig will use fresh credentials for subsequent authentication attempts. Fixes #57585 Report URL: https://github.com/apache/airflow/actions/runs/19887655941 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[GH] (airflow/fix/eks-pod-operator-credential-refresh-issue-57585): Workflow run "Tests" failed!
The GitHub Actions job "Tests" on airflow.git/fix/eks-pod-operator-credential-refresh-issue-57585 has failed. Run started by GitHub user aviralgarg05 (triggered by o-nikolas). Head commit for run: 8fd41b7a27753e2affccb530fc7c92eaee13a2ce / aviralgarg05 Fix log duplication in KubernetesPodOperator during retries When KubernetesPodOperator retries due to credential expiration (or other reasons), it restarts log fetching from the beginning, causing duplicated logs. This change updates PodManager to track the last captured log timestamp for each container. When fetch_requested_container_logs is called again (during retry), it resumes fetching logs from the last recorded timestamp. Changes: - Add container_log_times to PodManager to track progress - Update fetch_container_logs to save the last timestamp - Update fetch_requested_container_logs and fetch_requested_init_container_logs to use the saved timestamp as 'since_time' This ensures seamless log streaming even across retries. Report URL: https://github.com/apache/airflow/actions/runs/19730417185 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[GH] (airflow/fix/eks-pod-operator-credential-refresh-issue-57585): Workflow run "Tests" failed!
The GitHub Actions job "Tests" on airflow.git/fix/eks-pod-operator-credential-refresh-issue-57585 has failed. Run started by GitHub user aviralgarg05 (triggered by vincbeck). Head commit for run: 7ceac243b8a706a2f8cbf604e9ca0e908e9dbdeb / aviralgarg05 Fix EKSPodOperator credential refresh errors and improve error handling (#57585) This commit fixes the issue where long-running EKS Pod tasks fail with 'NoneType' object has no attribute 'groups' error during AWS credential refresh and where logs get duplicated after reconnection. Changes: 1. Enhanced COMMAND template in eks.py to validate token generation output - Added validation to ensure last_line is not empty - Added validation to ensure timestamp and token are successfully parsed - Provides clear error messages when token parsing fails - Prevents NoneType errors from bash script failures 2. Improved error handling in pod.py _handle_api_exception method - Added try-except block around credential refresh logic - Logs detailed error information when credential refresh fails - Helps diagnose the root cause of credential refresh failures These changes prevent cryptic NoneType errors and provide better visibility into credential refresh failures for EKS Pod operators. Fixes #57585 Report URL: https://github.com/apache/airflow/actions/runs/19718242211 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
