[GH] (airflow/refs/pull/64770/head): Workflow run "Copilot code review" failed!

2026-04-10 Thread GitBox


The GitHub Actions job "Copilot code review" on 
airflow.git/refs/pull/64770/head has failed.
Run started by GitHub user Copilot (triggered by Copilot).

Head commit for run:
93f95a9036eebd95016164ea5bcf20ad9a2359a1 / Rana Aurangzaib 

Remove redundant AirflowException handler and duplicate test

- Merge except AirflowException and except Exception into single
  except Exception handler since both yield identical error events
- Remove test_serialization_includes_cancel_on_kill since the existing
  test_serialization already covers cancel_on_kill=True default
- Remove unused AirflowException import from triggers/emr.py

Report URL: https://github.com/apache/airflow/actions/runs/24273369106

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[GH] (airflow/refs/pull/64770/head): Workflow run "Copilot code review" failed!

2026-04-10 Thread GitBox


The GitHub Actions job "Copilot code review" on 
airflow.git/refs/pull/64770/head has failed.
Run started by GitHub user Copilot (triggered by Copilot).

Head commit for run:
ce76a50306ac528f47792ae92468669fd7bbb4df / Rana Aurangzaib 

Fix hook missing virtual_cluster_id and use event job_id in execute_complete

- Pass virtual_cluster_id to EmrContainerHook in hook() so stop_query()
  can call cancel_job_run with the correct cluster ID
- Use validated_event.get("job_id") in execute_complete() as primary
  source since self.job_id may be None after deferral reconstruction

Report URL: https://github.com/apache/airflow/actions/runs/24268089792

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[GH] (airflow/refs/pull/64770/head): Workflow run "Copilot code review" failed!

2026-04-10 Thread GitBox


The GitHub Actions job "Copilot code review" on 
airflow.git/refs/pull/64770/head has failed.
Run started by GitHub user Copilot (triggered by Copilot).

Head commit for run:
7a97cd49fa3208f558521b84c387159b58b94adf / Rana Aurangzaib 

Address review feedback on cancel-on-kill implementation

- Add except Exception fallback in trigger run() to match base class
  behavior for non-AirflowException errors
- Wrap sync get_task_instance() and stop_query() with sync_to_async to
  avoid blocking the triggerer event loop
- Add cancel_on_kill parameter to EmrContainerOperator for user opt-out
- Add test verifying original error is preserved when stop_query fails

Report URL: https://github.com/apache/airflow/actions/runs/24267881400

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[GH] (airflow/refs/pull/64770/head): Workflow run "Copilot code review" failed!

2026-04-10 Thread GitBox


The GitHub Actions job "Copilot code review" on 
airflow.git/refs/pull/64770/head has failed.
Run started by GitHub user Copilot (triggered by Copilot).

Head commit for run:
7a97cd49fa3208f558521b84c387159b58b94adf / Rana Aurangzaib 

Address review feedback on cancel-on-kill implementation

- Add except Exception fallback in trigger run() to match base class
  behavior for non-AirflowException errors
- Wrap sync get_task_instance() and stop_query() with sync_to_async to
  avoid blocking the triggerer event loop
- Add cancel_on_kill parameter to EmrContainerOperator for user opt-out
- Add test verifying original error is preserved when stop_query fails

Report URL: https://github.com/apache/airflow/actions/runs/24267708040

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



[GH] (airflow/refs/pull/64770/head): Workflow run "Copilot code review" failed!

2026-04-10 Thread GitBox


The GitHub Actions job "Copilot code review" on 
airflow.git/refs/pull/64770/head has failed.
Run started by GitHub user Copilot (triggered by Copilot).

Head commit for run:
37aab08a1aed8e9b3bf01a43fdb3e926a80d1ef9 / Rana Aurangzaib 

Fix mypy: type hint hook as EmrContainerHook in run()

The base class hook() method is typed to return AwsGenericHook[Any],
which does not expose the stop_query() method specific to
EmrContainerHook. Add an explicit type annotation with a type ignore
to satisfy mypy.

Report URL: https://github.com/apache/airflow/actions/runs/24261441058

With regards,
GitHub Actions via GitBox


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]