[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style

2025-02-11 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=488195

--- Comment #21 from Tobias Leupold  ---
I create a PR with the patch fixing this:
https://invent.kde.org/plasma/breeze/-/merge_requests/520

Please review! This is really an annoying bug, as it visually breaks everything
explicitly requestig a styled panel frame, and also some other widgets …

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style

2025-01-31 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=488195

--- Comment #20 from Tobias Leupold  ---
Btw patching this commit away also fixes the missing frame I wrote about in Bug
#499131! Imho this behavior is definitely a bug. Why should a QListWidget being
the only widget inside a layout get no frame drawn, but one with a label
besides should get one?!

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style

2025-01-31 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=488195

--- Comment #19 from Tobias Leupold  ---
I just tested it. I couldn't revert c3dde54df6ffdb149d1e4ae223bc409756622d18
automatically via git revert, so I did manually create a patch to revert this
very change. This brought back e.g. drawing frames around a QLabel if
explicitely requested (via setFrameStyle(QFrame::StyledPanel |
QFrame::Sunken)).

Carl, would you be so nice to explain what's the intention of this? And why
this was added this way This does break existing functionality … one can't
request to draw a frame around anything that doesn't have one by default
anymore – and I think we should be able to do this, no?!

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style

2025-01-31 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=488195

--- Comment #18 from Tobias Leupold  ---
Huh? But why!? If this was really, for some reason I don't get at the moment,
intentional: Could someone explain why I shouldn't be able to draw a frame
around a label anymore if I want to? And: Can I work around this somehow?!

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style

2025-01-31 Thread David Redondo
https://bugs.kde.org/show_bug.cgi?id=488195

David Redondo  changed:

   What|Removed |Added

 CC||c...@carlschwan.eu,
   ||k...@david-redondo.de

--- Comment #17 from David Redondo  ---
Looks like it was intentional
https://invent.kde.org/plasma/breeze/-/commit/c3dde54df6ffdb149d1e4ae223bc409756622d18

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style

2025-01-27 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=488195

--- Comment #16 from Tobias Leupold  ---
https://bugs.kde.org/show_bug.cgi?id=499131 could maybe be another implication
of this?!

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style

2024-12-06 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=488195

--- Comment #15 from Tobias Leupold  ---
After some investigation, I found that not only QLabel is affected, but also
QFrame as a base class.

QLabel inherits QFrame, and the paintEvent calls drawFrame(), which calls
style()->drawControl(QStyle::CE_ShapedFrame, &opt, p, this).

Looking at qcommonstyle.cpp, for QFrame::Box and QFrame::Panel, direct Qt
functions seem to be called (qDrawPlainRect(), qDrawShadeRect() or
qDrawShadePanel()), whereas for QFrame::StyledPanel,
style()->drawPrimitive(QStyle::PE_Frame, ...) is invoked. QFrame::Box and
QFrame::Panel frame shapes are visible, both if set for a plain QFrame as well
as for a QLabel.

Looking at breezestyle.cpp, in drawControl(), drawPrimitive() is called and
from there drawFramePrimitive(). And here, I'm out of ideas, because
drawFramePrimitive() is char by char identical with the KF5/Qt5 version, where
the QFrame::StyledPanel shape (combined with the Raised or Sunken state) still
was displayed correctly.

I fear somebody with more insight of this would have to look into this :-(

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style

2024-12-06 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=488195

Tobias Leupold  changed:

   What|Removed |Added

Summary|Breeze on Plasma 6 doesn't  |Breeze on Plasma 6 doesn't
   |render the  |render the
   |QFrame::StyledPanel frame   |QFrame::StyledPanel frame
   |style for a QLabel  |style

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style for a QLabel

2024-12-05 Thread Friedrich W. H. Kossebau
https://bugs.kde.org/show_bug.cgi?id=488195

Friedrich W. H. Kossebau  changed:

   What|Removed |Added

 CC|kosse...@kde.org|

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style for a QLabel

2024-12-05 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=488195

--- Comment #14 from Tobias Leupold  ---
Is there something I can do to help here? I'm still seeing this with Breeze
6.2.4, and I'd really like to get StyledPanel frame styles for QLabels back ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style for a QLabel

2024-06-10 Thread Friedrich W. H. Kossebau
https://bugs.kde.org/show_bug.cgi?id=488195

Friedrich W. H. Kossebau  changed:

   What|Removed |Added

  Component|general |QStyle
   Assignee|cf...@kde.org   |plasma-b...@kde.org
Version|unspecified |6.0.5
Product|frameworks-kwidgetsaddons   |Breeze

--- Comment #13 from Friedrich W. H. Kossebau  ---
That MR/change in KWidgetsAddons was about KTitleWidget no longer using a
QLabel with that style, so unrelated.

This is an implementation issue of the Breeze style (BTW Oxygen similarly does
not render a frame for that), so moving over to Breeze.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style for a QLabel

2024-06-08 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=488195

--- Comment #11 from Tobias Leupold  ---
Created attachment 170261
  --> https://bugs.kde.org/attachment.cgi?id=170261&action=edit
plasma6_qt6_fusion.png

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style for a QLabel

2024-06-08 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=488195

--- Comment #10 from Tobias Leupold  ---
Created attachment 170260
  --> https://bugs.kde.org/attachment.cgi?id=170260&action=edit
plasma6_qt6_breeze.png

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style for a QLabel

2024-06-08 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=488195

--- Comment #9 from Tobias Leupold  ---
Created attachment 170259
  --> https://bugs.kde.org/attachment.cgi?id=170259&action=edit
plasma6_qt5_fusion.png

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style for a QLabel

2024-06-08 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=488195

--- Comment #8 from Tobias Leupold  ---
Created attachment 170258
  --> https://bugs.kde.org/attachment.cgi?id=170258&action=edit
plasma5_qt6_fusion.png

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style for a QLabel

2024-06-08 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=488195

--- Comment #7 from Tobias Leupold  ---
Created attachment 170257
  --> https://bugs.kde.org/attachment.cgi?id=170257&action=edit
plasma5_qt5_fusion.png

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style for a QLabel

2024-06-08 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=488195

--- Comment #6 from Tobias Leupold  ---
Created attachment 170256
  --> https://bugs.kde.org/attachment.cgi?id=170256&action=edit
plasma5_qt5_breeze.png

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style for a QLabel

2024-06-08 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=488195

--- Comment #5 from Tobias Leupold  ---
Created attachment 170255
  --> https://bugs.kde.org/attachment.cgi?id=170255&action=edit
MainWindow.h

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style for a QLabel

2024-06-08 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=488195

--- Comment #4 from Tobias Leupold  ---
Created attachment 170254
  --> https://bugs.kde.org/attachment.cgi?id=170254&action=edit
MainWindow.cpp

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style for a QLabel

2024-06-08 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=488195

--- Comment #3 from Tobias Leupold  ---
Created attachment 170253
  --> https://bugs.kde.org/attachment.cgi?id=170253&action=edit
main.cpp

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style for a QLabel

2024-06-08 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=488195

--- Comment #2 from Tobias Leupold  ---
Created attachment 170252
  --> https://bugs.kde.org/attachment.cgi?id=170252&action=edit
CMakeLists_qt6.txt

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 488195] Breeze on Plasma 6 doesn't render the QFrame::StyledPanel frame style for a QLabel

2024-06-08 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=488195

Tobias Leupold  changed:

   What|Removed |Added

 CC||t...@stonemx.de

--- Comment #1 from Tobias Leupold  ---
Created attachment 170251
  --> https://bugs.kde.org/attachment.cgi?id=170251&action=edit
CMakeLists_qt5.txt

-- 
You are receiving this mail because:
You are watching all bug changes.