[digikam] [Bug 495722] Assigning rating via keyboard shortcut doesnt work as expected (toggling vs assigning rating)

2024-11-26 Thread Michael Fuchs
https://bugs.kde.org/show_bug.cgi?id=495722

--- Comment #14 from Michael Fuchs  ---
Thank you very much!

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 495722] Assigning rating via keyboard shortcut doesnt work as expected (toggling vs assigning rating)

2024-11-26 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=495722

Maik Qualmann  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/digikam/-/commit/00a3d
   ||dd2e9dcd14eba45a4d5af63f8e3
   ||55b8ccb3
   Version Fixed In||8.6.0

--- Comment #13 from Maik Qualmann  ---
Git commit 00a3ddd2e9dcd14eba45a4d5af63f8e355b8ccb3 by Maik Qualmann.
Committed on 26/11/2024 at 18:12.
Pushed by mqualmann into branch 'master'.

polish merge request #324
FIXED-IN: 8.6.0

M  +1-1NEWS
M  +3-4core/app/views/stack/itemiconview.h
M  +8-14   core/app/views/stack/itemiconview_tags.cpp
M  +21   -11   core/libs/tags/engine/tagsactionmngr.cpp

https://invent.kde.org/graphics/digikam/-/commit/00a3ddd2e9dcd14eba45a4d5af63f8e355b8ccb3

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 495722] Assigning rating via keyboard shortcut doesnt work as expected (toggling vs assigning rating)

2024-11-08 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=495722

--- Comment #12 from caulier.gil...@gmail.com ---
I experienced WSL under Windows, and it's a waste of time. Uses a VM instead
(here VirtualBox)...

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 495722] Assigning rating via keyboard shortcut doesnt work as expected (toggling vs assigning rating)

2024-11-08 Thread Michael Fuchs
https://bugs.kde.org/show_bug.cgi?id=495722

--- Comment #11 from Michael Fuchs  ---
I just can't get this thing running.

Release 8.4. doesn't compile on Arch. Master HEAD compiles but crashes at
startup. I tried setting up an ubuntu WSL on a windows machine, but the scripts
Gilles provided fail at some point.

I gues I'll just wait for the next release on Arch, coz then it should be easy
to recompile it with my patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 495722] Assigning rating via keyboard shortcut doesnt work as expected (toggling vs assigning rating)

2024-11-05 Thread Michael Fuchs
https://bugs.kde.org/show_bug.cgi?id=495722

--- Comment #9 from Michael Fuchs  ---
Ok, thanks again. The git master code compiles now with the instructions in
PKGBUILD.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 495722] Assigning rating via keyboard shortcut doesnt work as expected (toggling vs assigning rating)

2024-11-05 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=495722

--- Comment #10 from caulier.gil...@gmail.com ---
Cool, 

Well we wait your MR... (:=))

Gilles

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 495722] Assigning rating via keyboard shortcut doesnt work as expected (toggling vs assigning rating)

2024-11-05 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=495722

--- Comment #8 from caulier.gil...@gmail.com ---
This is a problem introduced with Qt 6.8.0 that i fixed in git master code
(next 8.5.0). Look my commit:

https://invent.kde.org/graphics/digikam/-/commit/a8b49ed8df676cae0f48b3369831edde2b74903e

I think there is another one somewhere in the whole digiKam code about this
QUrl API problem

Best

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 495722] Assigning rating via keyboard shortcut doesnt work as expected (toggling vs assigning rating)

2024-11-05 Thread Michael Fuchs
https://bugs.kde.org/show_bug.cgi?id=495722

--- Comment #7 from Michael Fuchs  ---
Thank you. For now I'm still trying to just rebuild the original package. I
downloaded the PKGBUILD and compiled it in a clean chroot with `pkgctl build`
but I get an error which seems odd to me:

> [  7%] Building CXX object 
> core/libs/database/CMakeFiles/digikamdatabase_obj.dir/coredb/coredburl.cpp.o
> /build/digikam/src/digikam-8.4.0/core/libs/database/coredb/coredburl.cpp: In 
> member function ‘bool Digikam::CoreDbUrl::operator==(const QUrl&) const’:
> /build/digikam/src/digikam-8.4.0/core/libs/database/coredb/coredburl.cpp:251:19:
>  error: ‘operator==’ is not a member of ‘QUrl’
>   251 | return (QUrl::operator==(digikamalbumsUrl));
>   |   ^~
> make[2]: *** 
> [core/libs/database/CMakeFiles/digikamdatabase_obj.dir/build.make:404: 
> core/libs/database/CMakeFiles/digikamdatabase_obj.dir/coredb/coredburl.cpp.o] 
> Error 1
> make[1]: *** [CMakeFiles/Makefile2:6998: 
> core/libs/database/CMakeFiles/digikamdatabase_obj.dir/all] Error 2
> make: *** [Makefile:136: all] Error 2

Anyway, as this isn't about this bug i'll ask for help in arch forums.
I can still setup a VM (or WSL) with ubuntu and use your scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 495722] Assigning rating via keyboard shortcut doesnt work as expected (toggling vs assigning rating)

2024-11-04 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=495722

--- Comment #6 from caulier.gil...@gmail.com ---
Hi Michael,

For Ubuntu, not Arch, a script to install all dependencies exists, if it can
help :

https://invent.kde.org/graphics/digikam/-/blob/master/project/scripts/installdeps-ubuntu.sh?ref_type=heads

It use all system dependencies.

Another scripts in github that i written for Ubuntu, install system based
dependencies too, but compile and install all the most important, eg KDE
frameworks 6, Qt6, etc :

https://github.com/cgilles/digikam-install-deps

For this one, the compiled dependencies are placed in /opt.

Best.

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 495722] Assigning rating via keyboard shortcut doesnt work as expected (toggling vs assigning rating)

2024-11-04 Thread Michael Fuchs
https://bugs.kde.org/show_bug.cgi?id=495722

--- Comment #5 from Michael Fuchs  ---
Ok, I found the code and there are several ways to enhance it. I will provide
some PRs. 

But I didn't manage to compile digikam on Arch Linux yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 495722] Assigning rating via keyboard shortcut doesnt work as expected (toggling vs assigning rating)

2024-11-02 Thread Michael Fuchs
https://bugs.kde.org/show_bug.cgi?id=495722

Michael Fuchs  changed:

   What|Removed |Added

Version|unspecified |8.4.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 495722] Assigning rating via keyboard shortcut doesnt work as expected (toggling vs assigning rating)

2024-11-02 Thread Michael Fuchs
https://bugs.kde.org/show_bug.cgi?id=495722

--- Comment #4 from Michael Fuchs  ---
> Otherwise there would have to be an additional key function to delete ratings.

Isn't this already Ctrl+0?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 495722] Assigning rating via keyboard shortcut doesnt work as expected (toggling vs assigning rating)

2024-11-02 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=495722

Maik Qualmann  changed:

   What|Removed |Added

 CC||metzping...@gmail.com

--- Comment #3 from Maik Qualmann  ---
Personally, I think this behavior is good, probably because I've been used to
it for years. Otherwise there would have to be an additional key function to
delete ratings. In principle, setting with the mouse is also a toggle function.

Maik

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 495722] Assigning rating via keyboard shortcut doesnt work as expected (toggling vs assigning rating)

2024-11-02 Thread Michael Fuchs
https://bugs.kde.org/show_bug.cgi?id=495722

Michael Fuchs  changed:

   What|Removed |Added

 OS|All |Linux
   Platform|unspecified |Arch Linux

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 495722] Assigning rating via keyboard shortcut doesnt work as expected (toggling vs assigning rating)

2024-11-02 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=495722

--- Comment #2 from caulier.gil...@gmail.com ---
Which Operating system ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 495722] Assigning rating via keyboard shortcut doesnt work as expected (toggling vs assigning rating)

2024-11-02 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=495722

caulier.gil...@gmail.com changed:

   What|Removed |Added

 CC||caulier.gil...@gmail.com

--- Comment #1 from caulier.gil...@gmail.com ---
Which digiKam version ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[digikam] [Bug 495722] Assigning rating via keyboard shortcut doesnt work as expected (toggling vs assigning rating)

2024-11-02 Thread Michael Fuchs
https://bugs.kde.org/show_bug.cgi?id=495722

Michael Fuchs  changed:

   What|Removed |Added

 CC||fo...@posteo.at

-- 
You are receiving this mail because:
You are watching all bug changes.