[kate] [Bug 506911] Show (Git) Diff: Poor readability compared to editor

2025-07-13 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=506911

Christoph Cullmann  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/util |https://invent.kde.org/util
   |ities/kate/-/commit/5a269d6 |ities/kate/-/commit/693c88e
   |d5d0b6596989c170b1f9f7bfdf4 |51285b5663de3c06461d4452fa0
   |8c8126  |3d200f

--- Comment #10 from Christoph Cullmann  ---
Git commit 693c88e51285b5663de3c06461d4452fa03d200f by Christoph Cullmann.
Committed on 13/07/2025 at 17:23.
Pushed by cullmann into branch 'release/25.08'.

Use darkRed/darkGreen in light mode

It has better contrast


(cherry picked from commit 5b1dab7918fe887281d1fd8358ef45b6081dfe74)

Co-authored-by: Waqar Ahmed 

M  +2-2apps/lib/diff/diffeditor.cpp
M  +2-2apps/lib/diff/difflinenumarea.cpp

https://invent.kde.org/utilities/kate/-/commit/693c88e51285b5663de3c06461d4452fa03d200f

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 506911] Show (Git) Diff: Poor readability compared to editor

2025-07-13 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=506911

Christoph Cullmann  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/util |https://invent.kde.org/util
   |ities/kate/-/commit/5b1dab7 |ities/kate/-/commit/5a269d6
   |918fe887281d1fd8358ef45b608 |d5d0b6596989c170b1f9f7bfdf4
   |1dfe74  |8c8126

--- Comment #9 from Christoph Cullmann  ---
Git commit 5a269d6d5d0b6596989c170b1f9f7bfdf48c8126 by Christoph Cullmann.
Committed on 13/07/2025 at 17:22.
Pushed by cullmann into branch 'release/25.08'.

Rehighlight diff when editor theme changes


(cherry picked from commit 4c5df53a65eb1de837e4364d7097a2889b1bb625)

Co-authored-by: Waqar Ahmed 

M  +11   -0apps/lib/diff/diffwidget.cpp
M  +2-2apps/lib/diff/diffwidget.h

https://invent.kde.org/utilities/kate/-/commit/5a269d6d5d0b6596989c170b1f9f7bfdf48c8126

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 506911] Show (Git) Diff: Poor readability compared to editor

2025-07-12 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=506911

Waqar Ahmed  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/util
   ||ities/kate/-/commit/4c5df53
   ||a65eb1de837e4364d7097a2889b
   ||1bb625

--- Comment #7 from Waqar Ahmed  ---
Git commit 4c5df53a65eb1de837e4364d7097a2889b1bb625 by Waqar Ahmed.
Committed on 12/07/2025 at 10:48.
Pushed by waqar into branch 'master'.

Rehighlight diff when editor theme changes

M  +11   -0apps/lib/diff/diffwidget.cpp
M  +2-2apps/lib/diff/diffwidget.h

https://invent.kde.org/utilities/kate/-/commit/4c5df53a65eb1de837e4364d7097a2889b1bb625

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 506911] Show (Git) Diff: Poor readability compared to editor

2025-07-12 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=506911

Waqar Ahmed  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/util |https://invent.kde.org/util
   |ities/kate/-/commit/4c5df53 |ities/kate/-/commit/5b1dab7
   |a65eb1de837e4364d7097a2889b |918fe887281d1fd8358ef45b608
   |1bb625  |1dfe74

--- Comment #8 from Waqar Ahmed  ---
Git commit 5b1dab7918fe887281d1fd8358ef45b6081dfe74 by Waqar Ahmed.
Committed on 12/07/2025 at 11:08.
Pushed by waqar into branch 'master'.

Use darkRed/darkGreen in light mode

It has better contrast

M  +2-2apps/lib/diff/diffeditor.cpp
M  +2-2apps/lib/diff/difflinenumarea.cpp

https://invent.kde.org/utilities/kate/-/commit/5b1dab7918fe887281d1fd8358ef45b6081dfe74

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 506911] Show (Git) Diff: Poor readability compared to editor

2025-07-12 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=506911

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1

--- Comment #6 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/utilities/kate/-/merge_requests/1811

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 506911] Show (Git) Diff: Poor readability compared to editor

2025-07-12 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=506911

--- Comment #5 from Waqar Ahmed  ---
Breeze dark issue seems to be that you changed the color theme while the "diff"
was open. It doesn't react to that. Reopening the diff would work better I
guess. Can fix that.

Breeze light does have a readability issue it seems.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 506911] Show (Git) Diff: Poor readability compared to editor

2025-07-12 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=506911

--- Comment #4 from Waqar Ahmed  ---
Created attachment 183181
  --> https://bugs.kde.org/attachment.cgi?id=183181&action=edit
Breeze_dark_diff_view_not_reproduced

- Explicitly selected Breeze Dark theme in the settings dialog.
- Breeze Light theme is set in System settings.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 506911] Show (Git) Diff: Poor readability compared to editor

2025-07-12 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=506911

Waqar Ahmed  changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #3 from Waqar Ahmed  ---
Can't reproduce

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 506911] Show (Git) Diff: Poor readability compared to editor

2025-07-11 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=506911

--- Comment #2 from [email protected] ---
Created attachment 183160
  --> https://bugs.kde.org/attachment.cgi?id=183160&action=edit
Showcase of git diff, using Breeze Light.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 506911] Show (Git) Diff: Poor readability compared to editor

2025-07-11 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=506911

--- Comment #1 from [email protected] ---
Created attachment 183159
  --> https://bugs.kde.org/attachment.cgi?id=183159&action=edit
Showcase of git diff, using Breeze Dark.

-- 
You are receiving this mail because:
You are watching all bug changes.