[krita] [Bug 450857] Deselecting should not delete locked selection layer.
https://bugs.kde.org/show_bug.cgi?id=450857 --- Comment #6 from [email protected] --- Created attachment 192205 --> https://bugs.kde.org/attachment.cgi?id=192205&action=edit Video showing global locked selection masks being deleted Maybe a video would help? Perhaps what I'm seeing is not 100% the same as what was originally reported, but it still seems wrong to me. When you have a local selection mask attached to a paint layer, you can lock it and then select, deselect, do whatever, and it behaves as expected. But if you copy that selection mask to the root layer and make it a global selection mask, then suddenly deselecting it with Ctrl-D just deletes the entire layer, whether it's locked or not. My uneducated guess is that it's happening in the code somewhere here? https://invent.kde.org/graphics/krita/-/blob/master/libs/image/commands/kis_deselect_global_selection_command.cpp?ref_type=heads#L35 Either this code needs to be updated to simply check if the returned selection mask is locked before deleting, or else the call to image->rootLayer()->selectionMask() needs to be handle the possibility that there may be multiple selection masks attached to the root layer. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450857] Deselecting should not delete locked selection layer.
https://bugs.kde.org/show_bug.cgi?id=450857 --- Comment #5 from [email protected] --- (In reply to ricky.ringler from comment #4) > I can reproduce on the master branch, on Arch Linux with KDE. > > I will open a merge request to fix. Actually - I misinterpreted this. I believe everything is working, running Krita 6.x+. The layer doesn't get deleted. Looking at the source code, nothing is "off"; I don't see anything that implies a bug. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450857] Deselecting should not delete locked selection layer.
https://bugs.kde.org/show_bug.cgi?id=450857 [email protected] changed: What|Removed |Added CC||[email protected] --- Comment #4 from [email protected] --- I can reproduce on the master branch, on Arch Linux with KDE. I will open a merge request to fix. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450857] Deselecting should not delete locked selection layer.
https://bugs.kde.org/show_bug.cgi?id=450857 [email protected] changed: What|Removed |Added CC||[email protected] --- Comment #2 from [email protected] --- I still see this happening in 5.3.1, and I think my case is generally tied to the use of "global" selection layers. That is, I make local selection layers on my main flat-color drawing layer to represent different segments of the drawing, and then I drag those selection layers to the top of the layer stack so they're not linked to any particular layer or group, and if "Show Global Selection Mask" is active, they appear next to that global selection mask. Is this a feature? Am I supposed to be able to put them up there? What I want to do is be able to block out different parts of the drawing into selection masks (like from a colorize mask -> split layer -> convert into selection masks) and then have those apply globally with an easy toggle, that way I can use those same masks whether I'm working on a lighting layer, transparency mask, etc. It would make layer management a lot more convenient for me. As it is, I drag the local selection layers into the "global" space, and they work for a while, but pressing Deselect at any time deletes those layers even if they are locked. And, if I manually make a different selection with a lasso, that global selection layer interferes with my custom ones. I assume this bug is happening because the logic is getting confused by the presence of multiple global selection masks and has an override to "delete the global selection mask no matter what when deselect is pressed" -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450857] Deselecting should not delete locked selection layer.
https://bugs.kde.org/show_bug.cgi?id=450857 --- Comment #3 from [email protected] --- Created attachment 191959 --> https://bugs.kde.org/attachment.cgi?id=191959&action=edit This is the selection mask setup I would like to be able to use -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450857] Deselecting should not delete locked selection layer.
https://bugs.kde.org/show_bug.cgi?id=450857 Reinold Rojas changed: What|Removed |Added CC||[email protected] --- Comment #1 from Reinold Rojas --- Reconfirming for 5.2.6. It seems like the selection layer actually turns inactive instead of being removed if the layer is locked. If the layer isn't locked deselection does not modify the layer active status. Reproduce steps: 1. In the layer docker click on "Add local Selection" in the add layer dropdown 2. Create a selection using any selection tool (I used elliptical selection tool) 3. Lock the selection layer using the lock icon in the layer docker 4. Deselect selection via menu: Select->Deselect Observed Result: Hover over the selection layer and observe the popup says "Active: No". Hitting the button next to the lock button brings re-enables the selection. Expected result: I wouldn't expect deselection to make the layer inactive. No modification of the selection layer should happen. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450857] Deselecting should not delete locked selection layer.
https://bugs.kde.org/show_bug.cgi?id=450857 Halla Rempt changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 CC||[email protected] -- You are receiving this mail because: You are watching all bug changes.
