[kwin] [Bug 493607] Unexpected quick tiling behavior

2024-12-06 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=493607

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||6.3.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 493607] Unexpected quick tiling behavior

2024-12-04 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=493607

Vlad Zahorodnii  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/plas
   ||ma/kwin/-/commit/596ce0b3a0
   ||8b2fd304b809d923ff21267e25d
   ||c65

--- Comment #9 from Vlad Zahorodnii  ---
Git commit 596ce0b3a08b2fd304b809d923ff21267e25dc65 by Vlad Zahorodnii.
Committed on 04/12/2024 at 16:42.
Pushed by vladz into branch 'master'.

Tweak quick tile shortcut combination algorithm

This attempts to provide a compromise between the old and the new quick
tiling behavior.

With the proposed changes, if a window is tiled so it occupies the left
half of the screen and Meta+Right is pressed, the window will occupy the
right half of the screen. Quarter tiled windows are tiled as before. If
the window is migrated to another screen, it won't be untiled.

M  +4-4autotests/integration/quick_tiling_test.cpp
M  +5-0src/effect/globals.h
M  +51   -34   src/window.cpp

https://invent.kde.org/plasma/kwin/-/commit/596ce0b3a08b2fd304b809d923ff21267e25dc65

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 493607] Unexpected quick tiling behavior

2024-12-03 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=493607

--- Comment #8 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/kwin/-/merge_requests/6857

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 493607] Unexpected quick tiling behavior

2024-09-27 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=493607

Nate Graham  changed:

   What|Removed |Added

Version|6.1.90  |git master

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 493607] Unexpected quick tiling behavior

2024-09-27 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=493607

Nate Graham  changed:

   What|Removed |Added

Version|master  |6.1.90

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 493607] Unexpected quick tiling behavior

2024-09-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=493607

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
   Keywords||multiscreen, regression
   Priority|NOR |HI

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 493607] Unexpected quick tiling behavior

2024-09-24 Thread Jin Liu
https://bugs.kde.org/show_bug.cgi?id=493607

Jin Liu  changed:

   What|Removed |Added

 CC||ad.liu@gmail.com

--- Comment #7 from Jin Liu  ---
I think it's caused by the window being restored to its original position
(before tiling) in the other screen.

We can fix it by "restoring" it to a new position in the current screen, or we
can do https://invent.kde.org/plasma/kwin/-/merge_requests/6489 so we don't
bother with "restoring" at all. IIRC Vlad said "restoring to a new screen" is
messy (when discussing launching apps in their previous positions regarding
screen layout change), so I'd somewhat prefer the latter.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 493607] Unexpected quick tiling behavior

2024-09-24 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=493607

Bug Janitor Service  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED

--- Comment #6 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/kwin/-/merge_requests/6489

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 493607] Unexpected quick tiling behavior

2024-09-24 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=493607

--- Comment #5 from Vlad Zahorodnii  ---
> Not sure what you mean by "the other point"

"3. Not possible to tile window to the right"

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 493607] Unexpected quick tiling behavior

2024-09-24 Thread Natalie Clarius
https://bugs.kde.org/show_bug.cgi?id=493607

--- Comment #4 from Natalie Clarius  ---
Not sure what you mean by "the other point"; I think I raised three:  
1. Window getting untitled unintuitive (debatable)  
2. Window getting moved to screen in the opposite direction unintuitive (maybe
again debatable but I find it hard to see how it could be expected)  
3. Not possible to tile window to the right, this is clearly a loss of
previously working functionality imo

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 493607] Unexpected quick tiling behavior

2024-09-24 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=493607

--- Comment #3 from Vlad Zahorodnii  ---
> 1. untiled on left half of left screen (weird)

If a window is already tiled left and you combine (in master/6.3, the semantics
are slightly different) it with the opposite action, the result would be no
tiling. It's different from 6.2, but I don't think it's weird and there's no
definite "this is right" or "this is wrong" in this case.

Regarding the other point in this bug report, yes, we need to fix that.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 493607] Unexpected quick tiling behavior

2024-09-24 Thread Natalie Clarius
https://bugs.kde.org/show_bug.cgi?id=493607

--- Comment #2 from Natalie Clarius  ---
The result of step 4 is more unexpected than that of step 1 because the window
also jumps screens, in the opposite direction of the shortcut pressed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 493607] Unexpected quick tiling behavior

2024-09-24 Thread Natalie Clarius
https://bugs.kde.org/show_bug.cgi?id=493607

Natalie Clarius  changed:

   What|Removed |Added

 CC||m.liu@gmail.com

--- Comment #1 from Natalie Clarius  ---
Commit cb86a084 seems relevant, though I haven't yet tested reverting it

-- 
You are receiving this mail because:
You are watching all bug changes.