[kwin] [Bug 504367] Tiling manager doesn't layout only has one "tile"

2025-05-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=504367

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||6.4.0
 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 504367] Tiling manager doesn't layout only has one "tile"

2025-05-19 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=504367

Vlad Zahorodnii  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/plas
   ||ma/kwin/-/commit/9b0fd06e14
   ||e30c8fa39271fe6b1c0faaee381
   ||588

--- Comment #3 from Vlad Zahorodnii  ---
Git commit 9b0fd06e14e30c8fa39271fe6b1c0faaee381588 by Vlad Zahorodnii.
Committed on 19/05/2025 at 08:33.
Pushed by vladz into branch 'master'.

tiles: Fix CustomTile::remove() collapsing tile tree too much

When a tile is removed and its sibling is empty, the parent tile will
be converted in a leaf tile.

The problem is that CustomTile::remove() can attempt to convert the
root tile in a leaf tile, but we expect the root tile to contain at
least one child at all times.

This change adds a relevant guard. Note that CustomTile::remove() can
be still used to purge all children of the RootTile. This is mainly
used by the tiles editor. Window::quickTileGeometry() was also adjusted
so it doesn't report a misleading geometry if the window can't be
custom tiled.

M  +1-1src/tiles/customtile.cpp
M  +5-0src/tiles/tile.cpp
M  +1-0src/tiles/tile.h
M  +2-0src/window.cpp

https://invent.kde.org/plasma/kwin/-/commit/9b0fd06e14e30c8fa39271fe6b1c0faaee381588

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 504367] Tiling manager doesn't layout only has one "tile"

2025-05-19 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=504367

Vlad Zahorodnii  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/kwin/-/commit/9b0fd06e14 |ma/kwin/-/commit/613a1afbff
   |e30c8fa39271fe6b1c0faaee381 |4b44a0b8c8ad41bdc8bbd484ff4
   |588 |872

--- Comment #4 from Vlad Zahorodnii  ---
Git commit 613a1afbff4b44a0b8c8ad41bdc8bbd484ff4872 by Vlad Zahorodnii.
Committed on 19/05/2025 at 08:47.
Pushed by vladz into branch 'Plasma/6.4'.

tiles: Fix CustomTile::remove() collapsing tile tree too much

When a tile is removed and its sibling is empty, the parent tile will
be converted in a leaf tile.

The problem is that CustomTile::remove() can attempt to convert the
root tile in a leaf tile, but we expect the root tile to contain at
least one child at all times.

This change adds a relevant guard. Note that CustomTile::remove() can
be still used to purge all children of the RootTile. This is mainly
used by the tiles editor. Window::quickTileGeometry() was also adjusted
so it doesn't report a misleading geometry if the window can't be
custom tiled.


(cherry picked from commit 9b0fd06e14e30c8fa39271fe6b1c0faaee381588)

Co-authored-by: Vlad Zahorodnii 

M  +1-1src/tiles/customtile.cpp
M  +5-0src/tiles/tile.cpp
M  +1-0src/tiles/tile.h
M  +2-0src/window.cpp

https://invent.kde.org/plasma/kwin/-/commit/613a1afbff4b44a0b8c8ad41bdc8bbd484ff4872

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 504367] Tiling manager doesn't layout only has one "tile"

2025-05-19 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=504367

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #2 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/kwin/-/merge_requests/7632

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 504367] Tiling manager doesn't layout only has one "tile"

2025-05-19 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=504367

--- Comment #1 from Vlad Zahorodnii  ---
This also happens in 6.3, right?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 504367] Tiling manager doesn't layout only has one "tile"

2025-05-19 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=504367

Vlad Zahorodnii  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.