[partitionmanager] [Bug 503932] Menubar missing icons and misalignment
https://bugs.kde.org/show_bug.cgi?id=503932 --- Comment #16 from hottog --- I think I'll start with some easier code contributions (this c++ code is quite difficult to understand just by looking at it) and I'll let this one be done by someone with more experince than me. Tomorrow I'll create a proper bug report for KTorrent as you recommended. I'll keep this bug report open because the missing icons part is still vaild. -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 503932] Menubar missing icons and misalignment
https://bugs.kde.org/show_bug.cgi?id=503932 --- Comment #15 from Andrius Štikonas --- Anyway, probably best to have a separate ticket there, it's another application... -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 503932] Menubar missing icons and misalignment
https://bugs.kde.org/show_bug.cgi?id=503932 --- Comment #14 from Andrius Štikonas --- (In reply to hottog from comment #13) > (In reply to Andrius Štikonas from comment #12) > > Well, you have an example commit of reordering menu items in > > partitionmanager. Instead of opening wishlist report, just open a merge > > request :) > > Could you point me to the file I need to edit? I've created a KDE Identity > account and checked the ktorrent repository, but I have trouble > understanding how it all works (I've never done any software development > before). > > But if I know where to look I'll probably be able to figure out what I need > to do :) Hmm, I briefly looked at it now, and it is somewhat confusing, I don't fully understand it... Anyway, it seems that these files are relevant: https://invent.kde.org/network/ktorrent/-/blob/master/ktorrent/gui.cpp?ref_type=heads#L373 (here the icon for "Show statusbar" is being set, but I guess it's an invalid icon name...) (some of the menu structure is also in .rc files, e.g. in https://invent.kde.org/network/ktorrent/-/blob/master/ktorrent/ktorrentui.rc?ref_type=heads) -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 503932] Menubar missing icons and misalignment
https://bugs.kde.org/show_bug.cgi?id=503932 --- Comment #13 from hottog --- (In reply to Andrius Štikonas from comment #12) > Well, you have an example commit of reordering menu items in > partitionmanager. Instead of opening wishlist report, just open a merge > request :) Could you point me to the file I need to edit? I've created a KDE Identity account and checked the ktorrent repository, but I have trouble understanding how it all works (I've never done any software development before). But if I know where to look I'll probably be able to figure out what I need to do :) -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 503932] Menubar missing icons and misalignment
https://bugs.kde.org/show_bug.cgi?id=503932 --- Comment #12 from Andrius Štikonas --- (In reply to hottog from comment #10) > Should I open a new bug/wishlist report for that as well? Well, you have an example commit of reordering menu items in partitionmanager. Instead of opening wishlist report, just open a merge request :) -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 503932] Menubar missing icons and misalignment
https://bugs.kde.org/show_bug.cgi?id=503932 --- Comment #11 from hottog --- Dolphin has a similar settings entry as the "Panels/Toolbars Shown" entry in Partition Manager/KTorrent, and it uses the "view-sidetree-symbolic" icon for it. So perhaps that icon could be used in Partition Manager/KTorrent as well. And other possible icons where there's currently no icons in Partition Manager: - "drive-symbolic" for Device/SMART Status - "edit-symbolic" for Partition/Edit Mount Point - "media-mount-symbolic" for Partition/Mount - "info-symbolic" for Tools/File System Support I know these are generic icons but in my opinion it's better to have a generic icon than no icon at all. -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 503932] Menubar missing icons and misalignment
https://bugs.kde.org/show_bug.cgi?id=503932 --- Comment #10 from hottog --- I've noticed that KTorrent has the same kind of settings menu as what partition manager had. Should I open a new bug/wishlist report for that as well? -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 503932] Menubar missing icons and misalignment
https://bugs.kde.org/show_bug.cgi?id=503932 --- Comment #9 from Andrius Štikonas --- Git commit ef7b4081aee82965f2dba6778373153d3e64c541 by Andrius Štikonas. Committed on 09/05/2025 at 01:28. Pushed by stikonas into branch 'master'. Re-order settings menu. M +1-2src/gui/partitionmanagerui.rc https://invent.kde.org/system/partitionmanager/-/commit/ef7b4081aee82965f2dba6778373153d3e64c541 -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 503932] Menubar missing icons and misalignment
https://bugs.kde.org/show_bug.cgi?id=503932 --- Comment #8 from hottog --- I see. I think adding a few icons (if there are available icons for these actions) would go a long way. And perhaps if the two checkboxes were next to each other, maybe that would make the Settings menu look a bit tidier. Anyway, thanks for the quick responses and for this application! -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 503932] Menubar missing icons and misalignment
https://bugs.kde.org/show_bug.cgi?id=503932 --- Comment #7 from Andrius Štikonas --- (In reply to hottog from comment #6) > I feel like this could be improved. Right now the the Settings section > (dialog? context menu?) looks a bit odd with the empty spaces. I don't think partition manager has any control over that. It probably comes from Qt. So besides adding some icons, to hide the issue, there isn't anything I can do regarding alignment. -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 503932] Menubar missing icons and misalignment
https://bugs.kde.org/show_bug.cgi?id=503932 --- Comment #6 from hottog --- If I understand correctly, here's what causes the "misalignment": 1. The space between the checkbox and its text is for a (currently not used) icon 2. the text in the bottom half of the Settings section is aligned to those at the top 3. therefore an empty space is created before the text in the bottom half of the Settings section I feel like this could be improved. Right now the the Settings section (dialog? context menu?) looks a bit odd with the empty spaces. -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 503932] Menubar missing icons and misalignment
https://bugs.kde.org/show_bug.cgi?id=503932 Andrius Štikonas changed: What|Removed |Added Priority|NOR |LO Severity|normal |wishlist --- Comment #5 from Andrius Štikonas --- We never had icons there, I guess because it's hard to pick a suitable icon for those actions... Perhaps we could add mount icon though to the same one as Dolphin uses. There is no misalignment in the settings menu though. Checkboxes and (missing) icons are not meant to be aligned (theoretically you could have both checkbox and an icon). -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 503932] Menubar missing icons and misalignment
https://bugs.kde.org/show_bug.cgi?id=503932 --- Comment #4 from hottog --- Created attachment 181077 --> https://bugs.kde.org/attachment.cgi?id=181077&action=edit Misalignment and missing icon in Settings section -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 503932] Menubar missing icons and misalignment
https://bugs.kde.org/show_bug.cgi?id=503932 --- Comment #3 from hottog --- Created attachment 181074 --> https://bugs.kde.org/attachment.cgi?id=181074&action=edit Missing icon in Tools section -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 503932] Menubar missing icons and misalignment
https://bugs.kde.org/show_bug.cgi?id=503932 --- Comment #2 from hottog --- Created attachment 181073 --> https://bugs.kde.org/attachment.cgi?id=181073&action=edit Missing icons in Partition section -- You are receiving this mail because: You are watching all bug changes.
[partitionmanager] [Bug 503932] Menubar missing icons and misalignment
https://bugs.kde.org/show_bug.cgi?id=503932 --- Comment #1 from hottog --- Created attachment 181072 --> https://bugs.kde.org/attachment.cgi?id=181072&action=edit Missing icons in Device section -- You are receiving this mail because: You are watching all bug changes.
