[plasma-systemmonitor] [Bug 504455] Unable to remove "Old Version" of a System Monitor page

2025-05-20 Thread Arjen Hiemstra
https://bugs.kde.org/show_bug.cgi?id=504455

Arjen Hiemstra  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Arjen Hiemstra  ---
I couldn't reproduce the original issue so I didn't mark it as resolved
originally, but since the reporter also fixed it on their end, I think we can
close this now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-systemmonitor] [Bug 504455] Unable to remove "Old Version" of a System Monitor page

2025-05-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=504455

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
 CC||n...@kde.org

--- Comment #8 from Nate Graham  ---
So is this fixed now, Arjen? Or is there more to do?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-systemmonitor] [Bug 504455] Unable to remove "Old Version" of a System Monitor page

2025-05-19 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=504455

--- Comment #5 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/362

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-systemmonitor] [Bug 504455] Unable to remove "Old Version" of a System Monitor page

2025-05-19 Thread Arjen Hiemstra
https://bugs.kde.org/show_bug.cgi?id=504455

--- Comment #7 from Arjen Hiemstra  ---
(In reply to Schlaefer from comment #2)
> But I noticed some serious GUI stutter, like something is choking in the
> background. So I thought let's check if something throws and error on the
> CLI, and also record it. So that got me something interesting: It failed for
> another 2 times and worked after the 3rd try. 
> 
> Now `~/.local/share/plasma-systemmonitor/old-overview.page` is gone too.
> This was the content before it got removed: https://pastebin.com/uuMRDH27

One possibility is that without the above changes, the in-memory version of the
page would still be written to disk on application quit, which would mean the
old page would return on next startup. With the changes above it should now
disappear as soon as you reset the page, which should also mean it no longer
exists in memory and won't return.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-systemmonitor] [Bug 504455] Unable to remove "Old Version" of a System Monitor page

2025-05-19 Thread Arjen Hiemstra
https://bugs.kde.org/show_bug.cgi?id=504455

--- Comment #6 from Arjen Hiemstra  ---
Git commit 0ed144e25cd5c355e956121b81a54a83359b715e by Arjen Hiemstra.
Committed on 19/05/2025 at 14:38.
Pushed by ahiemstra into branch 'Plasma/6.4'.

page: When resetting a page that we have a new version for, remove the old one

We don't show these pages if they have no local changes, so we should
also hide them if the local changes are being removed. Otherwise one can
still have the "old" page visible until restart.


(cherry picked from commit 4479f05626fe3470fe82e0e29334aeed4d12b422)

Co-authored-by: Arjen Hiemstra 

M  +5-1src/page/PageManager.cpp

https://invent.kde.org/plasma/plasma-systemmonitor/-/commit/0ed144e25cd5c355e956121b81a54a83359b715e

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-systemmonitor] [Bug 504455] Unable to remove "Old Version" of a System Monitor page

2025-05-19 Thread Arjen Hiemstra
https://bugs.kde.org/show_bug.cgi?id=504455

--- Comment #4 from Arjen Hiemstra  ---
Git commit 4479f05626fe3470fe82e0e29334aeed4d12b422 by Arjen Hiemstra.
Committed on 19/05/2025 at 14:13.
Pushed by ahiemstra into branch 'master'.

page: When resetting a page that we have a new version for, remove the old one

We don't show these pages if they have no local changes, so we should
also hide them if the local changes are being removed. Otherwise one can
still have the "old" page visible until restart.

M  +5-1src/page/PageManager.cpp

https://invent.kde.org/plasma/plasma-systemmonitor/-/commit/4479f05626fe3470fe82e0e29334aeed4d12b422

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-systemmonitor] [Bug 504455] Unable to remove "Old Version" of a System Monitor page

2025-05-19 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=504455

--- Comment #3 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/359

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-systemmonitor] [Bug 504455] Unable to remove "Old Version" of a System Monitor page

2025-05-19 Thread Schlaefer
https://bugs.kde.org/show_bug.cgi?id=504455

--- Comment #2 from Schlaefer  ---
Created attachment 181505
  --> https://bugs.kde.org/attachment.cgi?id=181505&action=edit
Resetting and hidding worked after trying a few times

(In reply to Arjen Hiemstra from comment #1)
> `sudo find / -name old-overview.page`?

This is from a different machine than the original report, but it showed the
same symptoms:

~/.local/share/plasma-systemmonitor/old-overview.page
/usr/share/plasma-systemmonitor/old-overview.page

> Can you check if it still shows up if you restart system monitor?

Happened after restarting the app and full reboots.

But I noticed some serious GUI stutter, like something is choking in the
background. So I thought let's check if something throws and error on the CLI,
and also record it. So that got me something interesting: It failed for another
2 times and worked after the 3rd try. 

Now `~/.local/share/plasma-systemmonitor/old-overview.page` is gone too. This
was the content before it got removed: https://pastebin.com/uuMRDH27

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-systemmonitor] [Bug 504455] Unable to remove "Old Version" of a System Monitor page

2025-05-19 Thread Arjen Hiemstra
https://bugs.kde.org/show_bug.cgi?id=504455

--- Comment #1 from Arjen Hiemstra  ---
The base files cannot be removed because they are in a location that cannot be
written to. However, they should be hidden if you have no local changes
anymore. Can you share the output of `sudo find / -name old-overview.page`?

One thing I did notice is that we don't properly hide the page after it has
been reset while the application is still running. Can you check if it still
shows up if you restart system monitor?

-- 
You are receiving this mail because:
You are watching all bug changes.