[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-12-04 Thread John Kizer
https://bugs.kde.org/show_bug.cgi?id=481113

John Kizer  changed:

   What|Removed |Added

 CC||e...@horse64.org

--- Comment #70 from John Kizer  ---
*** Bug 496827 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-07-30 Thread cwo
https://bugs.kde.org/show_bug.cgi?id=481113

cwo  changed:

   What|Removed |Added

 CC||song...@foxmail.com

--- Comment #69 from cwo  ---
*** Bug 486113 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-07-16 Thread cwo
https://bugs.kde.org/show_bug.cgi?id=481113

cwo  changed:

   What|Removed |Added

 CC||emrekara42bu...@gmail.com

--- Comment #68 from cwo  ---
*** Bug 490359 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-06-15 Thread Cruz Enrique
https://bugs.kde.org/show_bug.cgi?id=481113

Cruz Enrique  changed:

   What|Removed |Added

 CC||cruzki...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-06-14 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=481113

Nate Graham  changed:

   What|Removed |Added

 CC||chadster...@gmail.com

--- Comment #67 from Nate Graham  ---
*** Bug 488469 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-06-12 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=481113

--- Comment #66 from ollil...@unitybox.de ---
Created attachment 170421
  --> https://bugs.kde.org/attachment.cgi?id=170421&action=edit
Patch for libplasma-6.0.90

I have made a patch for libplasma-6.0.90. And what should i say the bug is
solved, now pining and unpining apps to the task manager works.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-06-12 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=481113

Nate Graham  changed:

   What|Removed |Added

 CC||tobi.goerg...@gmail.com

--- Comment #65 from Nate Graham  ---
*** Bug 481085 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-06-12 Thread Andreas Sturmlechner
https://bugs.kde.org/show_bug.cgi?id=481113

Andreas Sturmlechner  changed:

   What|Removed |Added

   Version Fixed In||6.1.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-06-12 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=481113

Marco Martin  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/libplasma/-/commit/3bc19 |ma/libplasma/-/commit/1f3f9
   |9d92402e316541d6dec00af9fee |84c02bcf6719fb96182e47546ce
   |66afc341|62dbef73

--- Comment #64 from Marco Martin  ---
Git commit 1f3f984c02bcf6719fb96182e47546ce62dbef73 by Marco Martin, on behalf
of David Edmundson.
Committed on 12/06/2024 at 09:51.
Pushed by mart into branch 'Plasma/6.1'.

Applet: run full Applet::save when a config value changes

Plasma had two timers for configuration saving:
 - One applet specific, which eventually calls Applet::save
 - One at a corona level, which eventually calls KConfig::save

The former was incorrectly removed because it wasn't hooked up to
anything useful, but the real bug is that it should have been.

When a value changes in the KConfigPropertyMap we need to run through
Applet::save to sync that config loader with our main config. This
implicitly emits the configNeedsSaving which will trigger corona to sync
to disk.

M  +3-1src/plasma/applet.cpp

https://invent.kde.org/plasma/libplasma/-/commit/1f3f984c02bcf6719fb96182e47546ce62dbef73

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-06-12 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=481113

Marco Martin  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/libplasma/-/commit/f7b3e |ma/libplasma/-/commit/3bc19
   |98bd5c777a8c7510ec0edaaba64 |9d92402e316541d6dec00af9fee
   |12cac474|66afc341
 Status|ASSIGNED|RESOLVED

--- Comment #63 from Marco Martin  ---
Git commit 3bc199d92402e316541d6dec00af9fee66afc341 by Marco Martin, on behalf
of David Edmundson.
Committed on 12/06/2024 at 09:16.
Pushed by mart into branch 'master'.

Applet: run full Applet::save when a config value changes

Plasma had two timers for configuration saving:
 - One applet specific, which eventually calls Applet::save
 - One at a corona level, which eventually calls KConfig::save

The former was incorrectly removed because it wasn't hooked up to
anything useful, but the real bug is that it should have been.

When a value changes in the KConfigPropertyMap we need to run through
Applet::save to sync that config loader with our main config. This
implicitly emits the configNeedsSaving which will trigger corona to sync
to disk.

M  +3-1src/plasma/applet.cpp

https://invent.kde.org/plasma/libplasma/-/commit/3bc199d92402e316541d6dec00af9fee66afc341

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-06-11 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=481113

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #62 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/libplasma/-/merge_requests/1144

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-06-11 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=481113

Nate Graham  changed:

   What|Removed |Added

 CC||hiph...@posteo.de

--- Comment #61 from Nate Graham  ---
*** Bug 487705 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-06-11 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=481113

Nate Graham  changed:

   What|Removed |Added

 CC||shourya.h.vard...@gmail.com

--- Comment #60 from Nate Graham  ---
*** Bug 488337 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-06-08 Thread postix
https://bugs.kde.org/show_bug.cgi?id=481113

postix  changed:

   What|Removed |Added

 CC||pos...@posteo.eu

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-06-08 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=481113

--- Comment #59 from David Edmundson  ---
Edit: I *think* the old code was meant to be:

 - on change start a applet-wide timer and save to the kconfig instance
 - that emits a signal that tells us to sync, which starts a global timer to do
a  sync to disk

I removed the former with e08eb3caf329df648d39de8db5182bb862569ef5 as it was
clearly broken and not hooked up to anything, but I think the problem was that
it should have been.

I'm I'm right I should revert that, and change:

+connect(d->configPropertyMap, &KConfigPropertyMap::valueChanged, this,
&Applet::configNeedsSaving);

to call 

connect(d->configPropertyMap, &KConfigPropertyMap::valueChanged, this,
[this](){ d->scheduleModificationNotification()});

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-06-08 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=481113

--- Comment #58 from David Edmundson  ---
Doing it on shutdown *as well* is fine, it not syncing when a change happens
isn't design, it's a bug in the code somewhere.

Identified. 

On config change, the signal propagates up to CoronaPrivate::syncConfig  but
no-one is ever calling Applet::save().
We're writing the config to disk, but without syncing between the KConfigLoader
and the KConfig.

Adding saveLayout(q->config()); to CoronaPrivate::syncConfig  before the
config()->sync() seems to resolve it.



but it's definitely not a right fix as saveConfig is also emitting
propagateConfigChanged, which is semantically what triggers a sync to disk.
I don't understand what this current code is trying to do, will need to do some
archeology first.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-06-08 Thread Eriwin Iosef
https://bugs.kde.org/show_bug.cgi?id=481113

--- Comment #57 from Eriwin Iosef  ---
(In reply to David Edmundson from comment #55)
> There's two bugs at play here:
> 
>  - 1) we should be saving when a change happens not just on shutdown
> 
>  - 2) plasmashell isn't being shut down cleanly when systemd isn't managing
> it
> 
> I shall follow up on 1. 
> 
> We've seen that in other places, that I fixed with libplasma +
> c37a224bc7a33c6bd5ba7c546fec74880ad463b4, but clearly there's more.

I support 1) as well. Doing it on shutdown is just improper I feel, unless
there's a good reason why it's kept that way in the first place. It also
possibly removes it's dependency of systemd's shutdown phases, if that makes
sense.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-06-08 Thread Eriwin Iosef
https://bugs.kde.org/show_bug.cgi?id=481113

--- Comment #56 from Eriwin Iosef  ---
(In reply to kaffeefilter from comment #54)
> (In reply to Eriwin Iosef from comment #53)
> > kaffeefil...@s70.org's workaround works!!
> > If I may ask, how did you find it?
> 
> i'm not a developer, but my internet research pointed to plasmashell, that
> saves the icon list on close.
> Try and error, nothing more

I see. Thanks. And I thought naively doing an strace would have somehow pointed
out the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-06-08 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=481113

David Edmundson  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Priority|NOR |HI
 CC||k...@davidedmundson.co.uk
 Status|REPORTED|CONFIRMED

--- Comment #55 from David Edmundson  ---
There's two bugs at play here:

 - 1) we should be saving when a change happens not just on shutdown

 - 2) plasmashell isn't being shut down cleanly when systemd isn't managing it

I shall follow up on 1. 

We've seen that in other places, that I fixed with libplasma +
c37a224bc7a33c6bd5ba7c546fec74880ad463b4, but clearly there's more.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-06-08 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=481113

--- Comment #54 from kaffeefil...@s70.org ---
(In reply to Eriwin Iosef from comment #53)
> kaffeefil...@s70.org's workaround works!!
> If I may ask, how did you find it?

i'm not a developer, but my internet research pointed to plasmashell, that
saves the icon list on close.
Try and error, nothing more

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-06-07 Thread Eriwin Iosef
https://bugs.kde.org/show_bug.cgi?id=481113

--- Comment #53 from Eriwin Iosef  ---
kaffeefil...@s70.org's workaround works!!
If I may ask, how did you find it?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-06-07 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=481113

yam...@yamagi.org changed:

   What|Removed |Added

 CC|yam...@yamagi.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-06-07 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=481113

kaffeefil...@s70.org changed:

   What|Removed |Added

 CC||kaffeefil...@s70.org

--- Comment #52 from kaffeefil...@s70.org ---
workaround:

Pin the icons in taskbar then go to shell

kquitapp6 plasmashell && plasmashell

and reboot icons saved

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-06-05 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=481113

andrey.lastove...@gmail.com changed:

   What|Removed |Added

 CC||andrey.lastove...@gmail.com

--- Comment #51 from andrey.lastove...@gmail.com ---
I am facing the same problem using the plasma-meta metapackage on Arch Linux.
None of the solutions helps, I don't know what to do.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-05-30 Thread Randall Winkhart
https://bugs.kde.org/show_bug.cgi?id=481113

--- Comment #50 from Randall Winkhart  ---
I can also confirm this affects Alpine Linux. 

Doing a fresh install on Alpine 3.20 using "setup-alpine" followed by
"setup-desktop" leads to this behavior under both the Wayland and X11 sessions
(which is odd, because on my Artix Linux system with 6.0.5, this bug only
affects the Wayland session).

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-05-30 Thread Bart Ribbers
https://bugs.kde.org/show_bug.cgi?id=481113

Bart Ribbers  changed:

   What|Removed |Added

 CC||bribb...@disroot.org

--- Comment #49 from Bart Ribbers  ---
I can currently reproduce this on Alpine Linux using Plasma 6.0.5 with KDE
Frameworks 6.2.0, but only on one of 3 machines (a new laptop).
My desktop and previous laptop have been upgraded from Plasma 5 before and do
not experience this issue, but my new laptop that has only ever had Plasma 6
resets on every login.

No systemd, just OpenRC.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-05-28 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=481113

--- Comment #48 from ollil...@unitybox.de ---
I updated to:
KDE Plasma Version: 6.0.90
KDE Frameworks Version: 6.2.0
Qt Version: 6.7.1

and can confirm that the bug is still present.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-05-27 Thread Andreas Sturmlechner
https://bugs.kde.org/show_bug.cgi?id=481113

--- Comment #47 from Andreas Sturmlechner  ---
(In reply to Nate Graham from comment #37)
> Apparently in some distros, kbuildsycoca is run frequently/repeatedly, and
> there was previously an issue that could cause some things to not get saved
> properly.
We do nothing of that kind in Gentoo ourselves unless this is somehow triggered
in rare KDE Plasma non-systemd code paths. Please note this bug means that
Plasma 6 remains masked in Gentoo for the time being, so most users still get
Plasma 5.27.11 unless taking additional steps to upgrade.

Not fixed in 6.0.90 either.

KDE Plasma Version: 6.0.90
KDE Frameworks Version: 6.2.0
Qt Version: 6.7.1

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-05-27 Thread smow
https://bugs.kde.org/show_bug.cgi?id=481113

smow  changed:

   What|Removed |Added

 CC|smowten...@protonmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-05-27 Thread Eriwin Iosef
https://bugs.kde.org/show_bug.cgi?id=481113

Eriwin Iosef  changed:

   What|Removed |Added

 CC||rblade...@gmail.com

--- Comment #46 from Eriwin Iosef  ---
Hello, I'm facing the same issue here ever since plasma 6 in Artix Linux using
dinit, and also on Arch(systemd), no changes seen in 6.0.5 release:

KDE Plasma Version: 6.0.5
KDE Frameworks Version: 6.2.0
Qt Version: 6.7.1

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-05-24 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=481113

--- Comment #45 from ollil...@unitybox.de ---
(In reply to Nate Graham from comment #40)
> Ok, thanks.
> 
> Is there anyone here who's affected and uses BOTH systemd as their init
> system and ALSO Plasma's systemd boot integration
> (https://blog.davidedmundson.co.uk/blog/plasma-and-the-systemd-startup/)?
> 
> Or is everyone affected using either something other than systemd, or has
> disabled the Plasma systemd boot integration?

For a while i tried to setup a system with openrc, but there the bug is
present, too.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 481113] When not using Systemd or Plasma's Systemd session launch integration, changes to pinned apps are not saved when Plasmashell quits

2024-05-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=481113

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |REPORTED
Summary|When not using Systemd or   |When not using Systemd or
   |Plasma's Systemd boot   |Plasma's Systemd session
   |integration, changes to |launch integration, changes
   |pinned apps are not saved   |to pinned apps are not
   |when Plasmashell quits  |saved when Plasmashell
   ||quits

--- Comment #44 from Nate Graham  ---
Thanks folks.

-- 
You are receiving this mail because:
You are watching all bug changes.