[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #138 from Gautier --- (In reply to Gautier from comment #137) > I still have the issue: > > Operating System: NixOS 25.11 > KDE Plasma Version: 6.4.4 > KDE Frameworks Version: 6.16.0 > Qt Version: 6.9.1 > Kernel Version: 6.12.41 (64-bit) > Graphics Platform: X11 > Processors: 20 × Intel® Core™ i9-10850K CPU @ 3.60GHz > Memory: 128 GiB of RAM (125,6 GiB usable) > Graphics Processor: Intel® UHD Graphics 630 > Manufacturer: ASUS Never-mind, it's another issue, sure. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 Gautier changed: What|Removed |Added CC||[email protected] ||om --- Comment #137 from Gautier --- I still have the issue: Operating System: NixOS 25.11 KDE Plasma Version: 6.4.4 KDE Frameworks Version: 6.16.0 Qt Version: 6.9.1 Kernel Version: 6.12.41 (64-bit) Graphics Platform: X11 Processors: 20 × Intel® Core™ i9-10850K CPU @ 3.60GHz Memory: 128 GiB of RAM (125,6 GiB usable) Graphics Processor: Intel® UHD Graphics 630 Manufacturer: ASUS -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 Vlad Zahorodnii changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/kwin/-/commit/f3452076a7 |ma/kwin-x11/-/commit/94b33d |e710e1d165ed3d759a2cb17bad1 |380a0cf3e39f3cecd9069c660d1 |366 |0446cac --- Comment #136 from Vlad Zahorodnii --- Git commit 94b33d380a0cf3e39f3cecd9069c660d10446cac by Vlad Zahorodnii, on behalf of David Edmundson. Committed on 06/03/2025 at 15:13. Pushed by vladz into branch 'master'. x11: Update XStacking order when adding override-redirect windows Kwin uses it's own stacking order for managed windows and X11's stacking order directly for unmanaged windows. The X11 stacking order is updated only in resonse to XCB_CONFIGURE_NOTIFY on the root window, but if this fires before the window is mapped by kwin the window is not added to the unmanaged stack. This can leave things out of sync when we have multiple fullscreen unmanaged windows, which is the case of the lockscreen. M +50 -0autotests/integration/x11_window_test.cpp M +3-1src/events.cpp M +3-6src/layers.cpp M +1-0src/workspace.cpp M +1-1src/workspace.h https://invent.kde.org/plasma/kwin-x11/-/commit/94b33d380a0cf3e39f3cecd9069c660d10446cac -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 David Edmundson changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/kscreenlocker/-/commit/2 |ma/kwin/-/commit/4ce5756a53 |d258e6c72d4c08d5ff01c92ff6e |08a74daa51fae7c1894a78fb33a |954b34b3ebe6|ce0 --- Comment #134 from David Edmundson --- Git commit 4ce5756a5308a74daa51fae7c1894a78fb33ace0 by David Edmundson. Committed on 06/03/2025 at 13:45. Pushed by davidedmundson into branch 'master'. x11: Update XStacking order when adding override-redirect windows Kwin uses it's own stacking order for managed windows and X11's stacking order directly for unmanaged windows. The X11 stacking order is updated only in resonse to XCB_CONFIGURE_NOTIFY on the root window, but if this fires before the window is mapped by kwin the window is not added to the unmanaged stack. This can leave things out of sync when we have multiple fullscreen unmanaged windows, which is the case of the lockscreen. M +50 -0autotests/integration/x11_window_test.cpp M +3-1src/events.cpp M +3-6src/layers.cpp M +1-0src/workspace.cpp M +1-1src/workspace.h https://invent.kde.org/plasma/kwin/-/commit/4ce5756a5308a74daa51fae7c1894a78fb33ace0 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 Nate Graham changed: What|Removed |Added Version Fixed In|6.3.2 |6.3.3 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 David Edmundson changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/kwin/-/commit/4ce5756a53 |ma/kwin/-/commit/f3452076a7 |08a74daa51fae7c1894a78fb33a |e710e1d165ed3d759a2cb17bad1 |ce0 |366 --- Comment #135 from David Edmundson --- Git commit f3452076a7e710e1d165ed3d759a2cb17bad1366 by David Edmundson, on behalf of David Edmundson. Committed on 06/03/2025 at 14:08. Pushed by davidedmundson into branch 'Plasma/6.3'. x11: Update XStacking order when adding override-redirect windows Kwin uses it's own stacking order for managed windows and X11's stacking order directly for unmanaged windows. The X11 stacking order is updated only in resonse to XCB_CONFIGURE_NOTIFY on the root window, but if this fires before the window is mapped by kwin the window is not added to the unmanaged stack. This can leave things out of sync when we have multiple fullscreen unmanaged windows, which is the case of the lockscreen. (cherry picked from commit 4ce5756a5308a74daa51fae7c1894a78fb33ace0) Co-authored-by: David Edmundson M +50 -0autotests/integration/x11_window_test.cpp M +3-1src/events.cpp M +3-6src/layers.cpp M +1-0src/workspace.cpp M +1-1src/workspace.h https://invent.kde.org/plasma/kwin/-/commit/f3452076a7e710e1d165ed3d759a2cb17bad1366 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 Nate Graham changed: What|Removed |Added Version Fixed In||6.3.2 Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #133 from Nate Graham --- It sounds to me like this is fixed, and people still experiencing issues are hitting slightly different ones — perhaps only after lock plus suspend, for example. If you're still experiencing any such issues, please open new bug reports for them. Thanks a lot! -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #132 from Fushan Wen --- (In reply to Roman from comment #123) > I am on latest Arch, Plasma 6.3.1.1, and still have black screen with cursor > after resuming from sleep on x11 session. (does not happen on wayland). If you run `DISPLAY=:0 xrefresh` from the ssh, will the lock screen show up? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 [email protected] changed: What|Removed |Added CC|[email protected] | -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #131 from Craig Howard --- Prior to 6.3.0, I had a ~15% success rate. After 6.3.0, and including 6.3.1, I've had a 100% success rate so far. I'm on a desktop, I lock my screen frequently, but don't ever suspend the machine. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 TraceyC changed: What|Removed |Added Keywords||X11-only --- Comment #130 from TraceyC --- Adding the x11-only keyword -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 Claus-Justus Heine changed: What|Removed |Added CC|himself@claus-justus-heine. | |de | -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #129 from Roman --- (In reply to Nate Graham from comment #128) > (In reply to Roman from comment #123) > > I am on latest Arch, Plasma 6.3.1.1, and still have black screen with cursor > > after resuming from sleep on x11 session. (does not happen on wayland). > > Roman, do you have fingerprint unlocking set up? If so, your issue is likely > Bug 500478. Nope. Using normal password login. But as I've mentioned before, I only have this issue after waking from sleep, not after just locking screen. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #128 from Nate Graham --- (In reply to Roman from comment #123) > I am on latest Arch, Plasma 6.3.1.1, and still have black screen with cursor > after resuming from sleep on x11 session. (does not happen on wayland). Roman, do you have fingerprint unlocking set up? If so, your issue is likely Bug 500478. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #127 from Nicole Schoebel --- For me the bug was gone in 6.3.0 and remains fixed in 6.3.1. This is on Arch Linux. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #126 from Daniel Duris --- Updated to 6.3.1 and the bug seems to be fixed. There is no flashing of the content "behind" the lock screen. Operating System: Ubuntu 24.04.2 LTS (Noble Numbat) KDE Plasma Version: 6.3.1 KDE Frameworks Version: 6.11.0 Qt Version: 6.8.2 Kernel Version: 6.11.0-17-generic (64-bit) Graphics Platform: X11 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 Fushan Wen changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=500478 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #125 from nucleo --- The bug doesn't show up for me anymore. Operating System: Fedora Linux 41 KDE Plasma Version: 6.3.1 KDE Frameworks Version: 6.11.0 Qt Version: 6.8.2 Kernel Version: 6.12.15-200.fc41.x86_64 (64-bit) Graphics Platform: X11 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #124 from Guido --- (In reply to Roman from comment #123) > I am on latest Arch, Plasma 6.3.1.1, and still have black screen with cursor > after resuming from sleep on x11 session. (does not happen on wayland). Me too. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #123 from Roman --- I am on latest Arch, Plasma 6.3.1.1, and still have black screen with cursor after resuming from sleep on x11 session. (does not happen on wayland). -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #122 from Nate Graham --- Is anyone who was experiencing this in the past unable to reproduce the issue with Plasma 6.3.1 now? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #121 from Fushan Wen --- (In reply to nucleo from comment #120) > (In reply to Fushan Wen from comment #118) > > I didn't see the problem in 6.3 on X11 with or without multiscreen. > Also no problem for me in Fedora 41 with Plasma 6.3.0 and Qt 6.8.2. Please test again when you upgrade Plasma to 6.3.1. If you still can't reproduce then the bug is finally fixed. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #120 from nucleo --- (In reply to Fushan Wen from comment #118) > I didn't see the problem in 6.3 on X11 with or without multiscreen. Also no problem for me in Fedora 41 with Plasma 6.3.0 and Qt 6.8.2. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #119 from nurali --- (In reply to Fushan Wen from comment #118) > I didn't see the problem in 6.3 on X11 with or without multiscreen. I loved 5.27.11,it was stable enough, but gentoo dropped it since Plasma:6 stable release published, I had to use DWM, waiting for bug get fixed and change it to plasma. I also have problems with sddm on Plasma:6(X11). Scaling on 4K screen is not working anymore, sddm ui elememts are tiny Anyway, thank you 老铁 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #118 from Fushan Wen --- I didn't see the problem in 6.3 on X11 with or without multiscreen. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #117 from nurali --- What is the current status of this bug?Anyone using pasma 6.3? Is this fixed in 6.3? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #116 from nucleo --- If I apply only this patch https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/264 then black screen still appears randomly. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #115 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/264 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #114 from [email protected] --- I also experience this bug on Arch (Plasma 6.2.5, X11), with a Lenovo IdeaPad with 16 × AMD Ryzen 7 5800H with Radeon Graphics. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 [email protected] changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #113 from nucleo --- Black screen still appears randomly after applying patches https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/259 https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/260 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #111 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/260 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #112 from Fushan Wen --- (In reply to nucleo from comment #106) > (In reply to Fushan Wen from comment #105) > > Can anyone test > > https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/257 ? > > Unfortunately this patch does not change anything and a black screen appears > randomly. Can you also test https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/260 ? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 Fushan Wen changed: What|Removed |Added Status|NEEDSINFO |CONFIRMED Resolution|WAITINGFORINFO |--- --- Comment #107 from Fushan Wen --- (In reply to nucleo from comment #106) > (In reply to Fushan Wen from comment #105) > > Can anyone test > > https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/257 ? > > Unfortunately this patch does not change anything and a black screen appears > randomly. There might be other causes but I need to merge the fix to find out more possible causes. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #110 from Fushan Wen --- Git commit 4706bfbce425335dbc4deae23c735ba7d2e040f9 by Fushan Wen. Committed on 30/01/2025 at 09:13. Pushed by fusionfuture into branch 'Plasma/6.3'. X11Locker: always call stayOnTop when receiving XCB_MAP_NOTIFY to fix black screen If a window was shown up previously and is hidden for now with the background window together, m_allowedWindows will contain the window. When the window shows up again, it will also raise the background window. But when handling XCB_MAP_NOTIFY event from the background window, stayOnTop is not called, so the background window becomes the top window. (cherry picked from commit 0b208d59e86445f1a102c3e934dbd774d08c0714) Co-authored-by: Fushan Wen M +3-2x11locker.cpp https://invent.kde.org/plasma/kscreenlocker/-/commit/4706bfbce425335dbc4deae23c735ba7d2e040f9 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #108 from Fushan Wen --- Git commit 0b208d59e86445f1a102c3e934dbd774d08c0714 by Fushan Wen. Committed on 30/01/2025 at 09:08. Pushed by fusionfuture into branch 'master'. X11Locker: always call stayOnTop when receiving XCB_MAP_NOTIFY to fix black screen If a window was shown up previously and is hidden for now with the background window together, m_allowedWindows will contain the window. When the window shows up again, it will also raise the background window. But when handling XCB_MAP_NOTIFY event from the background window, stayOnTop is not called, so the background window becomes the top window. M +3-2x11locker.cpp https://invent.kde.org/plasma/kscreenlocker/-/commit/0b208d59e86445f1a102c3e934dbd774d08c0714 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #109 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/259 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #106 from nucleo --- (In reply to Fushan Wen from comment #105) > Can anyone test > https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/257 ? Unfortunately this patch does not change anything and a black screen appears randomly. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 Fushan Wen changed: What|Removed |Added Status|ASSIGNED|NEEDSINFO Resolution|--- |WAITINGFORINFO --- Comment #105 from Fushan Wen --- Can anyone test https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/257 ? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #104 from nucleo --- kscreenlocker-6.2.5 with patch from Comment 101 built for Fedora 41 fixes bug for me https://koji.fedoraproject.org/koji/taskinfo?taskID=128000736 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #103 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/254 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 Nate Graham changed: What|Removed |Added Version Fixed In|6.2.5 | -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #102 from [email protected] --- Unfortunately it's not fixed on my system either. I'm running an up-to-date arch OS: Arch Linux x86_64 DE: Plasma 6.2.5 WM: KWin Theme: Breeze-Dark [GTK2], Breeze [GTK3] -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 Stephan Diestelhorst changed: What|Removed |Added CC||stephan.diestelhorst@gmail. ||com -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163
--- Comment #101 from Philip Müller ---
The idea was to use the hide / lower function, as this was the case reported.
Sure, the show function seems to fix it properly, but it was not clear if that
regressed in other places. Did those who are affected tried the original fix
proposed here?
Based on the feedback we went with:
https://invent.kde.org/plasma/kscreenlocker/-/commit/2d258e6c72d4c08d5ff01c92ff6e954b34b3ebe6
Proposed fix on current feedback:
```
--- a/x11locker.cpp 2025-01-05 09:38:34.380078537 +0700
+++ b/x11locker.cpp 2025-01-05 09:39:17.740078945 +0700
@@ -85,8 +85,7 @@ void X11Locker::initialize()
void X11Locker::showLockWindow()
{
-m_background->hide();
-m_background->lower();
+m_background->show();
// Some xscreensaver hacks check for this property
const char *version = "KDE 4.0";
```
--
You are receiving this mail because:
You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 nucleo changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 nucleo changed: What|Removed |Added Ever confirmed|1 |0 Status|RESOLVED|REPORTED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #100 from Mario --- One more, the bug is not fixed. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #99 from Nicole Schoebel --- Count me in as another one for whom 6.2.5 does NOT fix this bug. I vote to reopen this bug. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #98 from nucleo --- So, this bug should be reopened? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #97 from branon --- I believe I am still experiencing this after updating to Plasma 6.2.5 - when on the "Breeze (follows color scheme)" style, my screenlocker is a blank black screen with cursor visible. Unlocking blindly works fine. Switching to "Breeze Dark" style mostly avoids the issue. On either style the issue is not reproducible 100% consistently but it's much more common on "Breeze (follows color scheme)". Operating System: Void KDE Plasma Version: 6.2.5 KDE Frameworks Version: 6.9.0 Qt Version: 6.8.1 Kernel Version: 6.12.7_1 (64-bit) Graphics Platform: X11 Processors: 16 × AMD Ryzen 7 8700G w/ Radeon 780M Graphics Memory: 30.4 GiB of RAM Graphics Processor: AMD Radeon Graphics -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163
--- Comment #96 from nucleo ---
Changes between kscreenlocker-6.2.4/x11locker.cpp and
kscreenlocker-6.2.5/x11locker.cpp are not the same as patch from comment 62:
void X11Locker::showLockWindow()
{
m_background->hide();
+m_background->lower();
.
// Some xscreensaver hacks check for this property
const char *version = "KDE 4.0";
patch from comment 62:
void X11Locker::showLockWindow()
{
-m_background->hide();
+m_background->show();
// Some xscreensaver hacks check for this property
const char *version = "KDE 4.0";
--
You are receiving this mail because:
You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #95 from Nate Graham --- kscreenlocker-6.2.5 is identical to kscreenlocker-6.2.4 with the patch applied; there are no other changes apart from translations. I suspect what you're seeing is in fact a different issue. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #94 from nucleo --- With kscreenlocker-6.2.5 black screen still appears randomly. With kscreenlocker-6.2.4 and patch from comment 62 black screen never showed up. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 Fushan Wen changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/plas ||ma/kscreenlocker/-/commit/2 ||d258e6c72d4c08d5ff01c92ff6e ||954b34b3ebe6 Version Fixed In||6.2.5 Status|CONFIRMED |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #93 from Fushan Wen --- Git commit 2b798ffdce47a5175c67b4e7dfca4e3a7b57385d by Fushan Wen. Committed on 12/12/2024 at 07:07. Pushed by fusionfuture into branch 'master'. x11locker: lower m_background when hiding X11Locker::m_background window was for some reason stacked above the lockscreen, even though it did't had focus. Bug seems to be introduced by Qt6. (cherry picked from commit 2d258e6c72d4c08d5ff01c92ff6e954b34b3ebe6) 02f5059c x11locker: lower m_bacckground when hiding Co-authored-by: Philip Müller M +1-0x11locker.cpp https://invent.kde.org/plasma/kscreenlocker/-/commit/2b798ffdce47a5175c67b4e7dfca4e3a7b57385d -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #91 from Fushan Wen --- Git commit 2d258e6c72d4c08d5ff01c92ff6e954b34b3ebe6 by Fushan Wen, on behalf of Philip Müller. Committed on 12/12/2024 at 07:07. Pushed by fusionfuture into branch 'Plasma/6.2'. x11locker: lower m_background when hiding X11Locker::m_background window was for some reason stacked above the lockscreen, even though it did't had focus. Bug seems to be introduced by Qt6. M +1-0x11locker.cpp https://invent.kde.org/plasma/kscreenlocker/-/commit/2d258e6c72d4c08d5ff01c92ff6e954b34b3ebe6 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #92 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/247 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 Andreas Sturmlechner changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #90 from Philip Müller --- Hmm, via the 'X11Locker::hideLockWindow()' function m_background gets lowered. Maybe the 'X11Locker::showLockWindow()' needs the same treatment with Qt6? https://invent.kde.org/philmmanjaro/kscreenlocker/-/commit/02f5059c1eeb27038a138374ae52517c30eb2c27 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #89 from Philip Müller --- So what will happen when 'm_background->lower();' from the function 'void X11Locker::hideLockWindow()' gets removed? 'm_background->shown' we have in 'bool X11Locker::nativeEventFilter' and 'void X11Locker::addAllowedWindow'. So if we don't lower it we also don't need to raise it. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #88 from Nate Graham --- If it works, we should consider it upstreaming it. Andrii, would you be interested in submitting it at https://invent.kde.org/plasma/kscreenlocker/-/merge_requests? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 Andrew changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #87 from nucleo --- Patched kscreenlocker-6.2.4 for Fedora 41 https://koji.fedoraproject.org/koji/taskinfo?taskID=126540135 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 Adem changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #86 from nucleo --- (In reply to Andrii R. from comment #85) > (In reply to David Edmundson from comment #80) > > When I was with someone who could reproduce it was determined that the > > window from X11Locker::m_background window was for some reason stacked above > > the lockscreen even though it did not have focus. > > I also found this behavior. I made patched version of kscreenlocker for my > usage(patch included in comment 62, or you can just call raise() on > m_background in x11locker.cpp when background window is shown). It works for > me. Seems like bug was introduced somewhere inside Qt6. Patch also works for me on Fedora 41. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #85 from Andrii R. --- (In reply to David Edmundson from comment #80) > When I was with someone who could reproduce it was determined that the > window from X11Locker::m_background window was for some reason stacked above > the lockscreen even though it did not have focus. I also found this behavior. I made patched version of kscreenlocker for my usage(patch included in comment 62, or you can just call raise() on m_background in x11locker.cpp when background window is shown). It works for me. Seems like bug was introduced somewhere inside Qt6. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 nucleo changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 Aaron McCarthy changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #84 from Attila --- (In reply to Attila from comment #83) > (In reply to Nate Graham from comment #74) > > That's right. Almost no core Plasma developers use X11 anymore. Speaking > > personally, I'm in the same boat as Jakob: whenever I log into an X11 > > session to try to reproduce this, it doesn't happen. I've never had it > > happen, in fact. > > > > We need a 100% reproducible case that makes the issue happen for a > > developer. > > I can always confirm and reproduce this bug on Fedora 41. The lock screen > always turns black when I set the Plasma style to Breeze. > If I change the style from Breeze to Breeze dark or another style, the lock > screen works as expected. Oh, sorry, I forgot to say that I am on X11. I think this is important. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 Attila changed: What|Removed |Added CC||[email protected] --- Comment #83 from Attila --- (In reply to Nate Graham from comment #74) > That's right. Almost no core Plasma developers use X11 anymore. Speaking > personally, I'm in the same boat as Jakob: whenever I log into an X11 > session to try to reproduce this, it doesn't happen. I've never had it > happen, in fact. > > We need a 100% reproducible case that makes the issue happen for a developer. I can always confirm and reproduce this bug on Fedora 41. The lock screen always turns black when I set the Plasma style to Breeze. If I change the style from Breeze to Breeze dark or another style, the lock screen works as expected. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 Mario changed: What|Removed |Added CC||[email protected] --- Comment #82 from Mario --- (In reply to Andreas from comment #70) > A temporary solution is to choose a Breeze Twilight, change the color of the > windows and the plasma style, turning the theme into light or dark. This works for me on Arch Linux, thank's. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #81 from AnneMarie Kerr --- my problem is my profile on Gentoo is invalid how do i fix my profile thanks AnneMarie Kerr -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 AnneMarie Kerr changed: What|Removed |Added CC||[email protected] Platform|Arch Linux |Gentoo Packages -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 David Edmundson changed: What|Removed |Added CC||[email protected] --- Comment #80 from David Edmundson --- When I was with someone who could reproduce it was determined that the window from X11Locker::m_background window was for some reason stacked above the lockscreen even though it did not have focus. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #78 from Roman --- @Joshua I've just re-checked it again now just to be sure, and let me rephrase my answer: Blindly typing my password does not solve the issue, but *something* does happen. On login screen, everything is black except mouse cursor, and I can blindly find password box and cursor changes to text-input cursor. After I type in password and press enter, everything stays black, cursor is no longer text-input in that area - so I am on desktop. I can blindly type [Meta]kwrite[enter] and on large part of screen, cursor is again text-input, indicating that indeed kwrite is open. Also, for example, it works when I press volume up/down keys on keyboard, there is sound response indicating volume being set. I can even blindly find volume tray icon and scroll over it to set volume. So whole plasma is "there", just nothing except mouse cursor is visible. PC responds to ping from other machine whole time (login screen, and after). -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #79 from Daniel Duris --- (In reply to Roman from comment #78) > @Joshua > I've just re-checked it again now just to be sure, and let me rephrase my > answer: Blindly typing my password does not solve the issue, but *something* > does happen. On login screen, everything is black except mouse cursor, and I > can blindly find password box and cursor changes to text-input cursor. After > I type in password and press enter, everything stays black, cursor is no > longer text-input in that area - so I am on desktop. I can blindly type > [Meta]kwrite[enter] and on large part of screen, cursor is again text-input, > indicating that indeed kwrite is open. Also, for example, it works when I > press volume up/down keys on keyboard, there is sound response indicating > volume being set. I can even blindly find volume tray icon and scroll over > it to set volume. So whole plasma is "there", just nothing except mouse > cursor is visible. PC responds to ping from other machine whole time (login > screen, and after). That's a different bug then. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #77 from TraceyC --- I'm also unable to reproduce this with git-master or a regular X11 session on that same machine Both with locking and sleeping the system, the unlock screen works correctly after multiple tests I don't think I've had this happen anytime on this install -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #75 from Roman --- @Joshua "Have you tried entering your password blind?" - Yes, it does nothing. "Also, since I changed themes, I haven not experienced this bug, so that is a possible work-around as well." - I've tried all Breeze themes and Oxygen, happens on all of them @Nate thanks for replying. I would love to switch to Wayland too, but can't for now (for the life of me, I just can't get RDP to windows machines work on wayland without horrible lag/stutter/blur; and that is big part of my work) I am software engineer too (unfortunately far from stack used in plasma), and few times we have reports from wild of issues we just could not reproduce locally, we just gave the client custom build with absurdly detailed logging/tracing, and have him send back logs/dumps. Isn't something like that possible with plasma? I am willing to be guinea pig for this, if it won't break my system. Or is it X11 "unofficialy" unsupported yet, so you don't want to invest in it anymore? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 --- Comment #76 from Joshua J. Kugler --- (In reply to Roman from comment #75) > "Have you tried entering your password blind?" - Yes, it does nothing. That's interesting. That may be a different bug, or related to this, but hitting another area in code, then, as I *think* all the conversation in this ticket has been talking about a bug that could be worked around via blind-typing. Another check, just to be sure: when your screen is blank, is your machine still reachable (ssh, or some such). Just want to rule out a full lock-up on resume, which is another bug I've seen before. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 483163] Sometimes on X11 with compositing turned on, black lock screen when using Breeze Plasma style, but controls are all there and remain interactive
https://bugs.kde.org/show_bug.cgi?id=483163 Nate Graham changed: What|Removed |Added Summary|On X11 with compositing |Sometimes on X11 with |turned on, black lock |compositing turned on, |screen when using Breeze|black lock screen when |Plasma style, but controls |using Breeze Plasma style, |are all there and remain|but controls are all there |interactive |and remain interactive --- Comment #74 from Nate Graham --- That's right. Almost no core Plasma developers use X11 anymore. Speaking personally, I'm in the same boat as Jakob: whenever I log into an X11 session to try to reproduce this, it doesn't happen. I've never had it happen, in fact. We need a 100% reproducible case that makes the issue happen for a developer. -- You are receiving this mail because: You are watching all bug changes.
