[plasmashell] [Bug 504343] Adding blank "System Monitor Sensor" widgets via click (not drag-and-drop) is broken

2025-05-16 Thread cwo
https://bugs.kde.org/show_bug.cgi?id=504343

cwo  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/libplasma/-/commit/0db46 |ma/libplasma/-/commit/21302
   |b7c5cc3e429b293daa1d12036ce |cc897723992e964123d073641f7
   |ddb90d79|ecc642ae

--- Comment #7 from cwo  ---
Git commit 21302cc897723992e964123d073641f7ecc642ae by Christoph Wolk.
Committed on 16/05/2025 at 21:18.
Pushed by cwo into branch 'Plasma/6.4'.

plasma/pluginloader: actually use pluginName when loading plugins

loadApplet takes the plugin name either as an applet name or as a full
path, but KPluginMetaData only wants the actual name. So we save the
plugin name in pluginName, then ignore it and use the original argument
anyway. WidgetExplorer, when clicking the applet, sends the path, so all
Kpackage + plugin widgets added this way are considered qml-only plugins
and their applet code isn't started (unless they have a parent plugin,
as the rootpath metadata is the name, or Plasma is restarted and the
name is read from appletsrc).

Instead we actually use the variable we computed and everything works
again.


(cherry picked from commit 0db46b7c5cc3e429b293daa1d12036ceddb90d79)

Co-authored-by: Christoph Wolk 

M  +1-1src/plasma/pluginloader.cpp

https://invent.kde.org/plasma/libplasma/-/commit/21302cc897723992e964123d073641f7ecc642ae

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 504343] Adding blank "System Monitor Sensor" widgets via click (not drag-and-drop) is broken

2025-05-16 Thread cwo
https://bugs.kde.org/show_bug.cgi?id=504343

cwo  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/plas
   ||ma/libplasma/-/commit/0db46
   ||b7c5cc3e429b293daa1d12036ce
   ||ddb90d79
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #6 from cwo  ---
Git commit 0db46b7c5cc3e429b293daa1d12036ceddb90d79 by Christoph Wolk.
Committed on 16/05/2025 at 20:59.
Pushed by cwo into branch 'master'.

plasma/pluginloader: actually use pluginName when loading plugins

loadApplet takes the plugin name either as an applet name or as a full
path, but KPluginMetaData only wants the actual name. So we save the
plugin name in pluginName, then ignore it and use the original argument
anyway. WidgetExplorer, when clicking the applet, sends the path, so all
Kpackage + plugin widgets added this way are considered qml-only plugins
and their applet code isn't started (unless they have a parent plugin,
as the rootpath metadata is the name, or Plasma is restarted and the
name is read from appletsrc).

Instead we actually use the variable we computed and everything works
again.

M  +1-1src/plasma/pluginloader.cpp

https://invent.kde.org/plasma/libplasma/-/commit/0db46b7c5cc3e429b293daa1d12036ceddb90d79

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 504343] Adding blank "System Monitor Sensor" widgets via click (not drag-and-drop) is broken

2025-05-16 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=504343

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #5 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/libplasma/-/merge_requests/1311

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 504343] Adding blank "System Monitor Sensor" widgets via click (not drag-and-drop) is broken

2025-05-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=504343

Nate Graham  changed:

   What|Removed |Added

   See Also|https://bugs.kde.org/show_b |
   |ug.cgi?id=504335|

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 504343] Adding blank "System Monitor Sensor" widgets via click (not drag-and-drop) is broken

2025-05-16 Thread cwo
https://bugs.kde.org/show_bug.cgi?id=504343

--- Comment #4 from cwo  ---
(In reply to cwo from comment #2)
> Note that only adding them by clicking in the WidgetExplorer is broken, if I
> drag&drop them there, it works as usual.

Don't try it with a panel, it won't show up at all.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 504343] Adding blank "System Monitor Sensor" widgets via click (not drag-and-drop) is broken

2025-05-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=504343

Nate Graham  changed:

   What|Removed |Added

Summary|Adding blank "System|Adding blank "System
   |Monitor Sensor" widgets is  |Monitor Sensor" widgets via
   |broken  |click (not drag-and-drop)
   ||is broken

--- Comment #3 from Nate Graham  ---
Fascinating. I can reproduce that too.

-- 
You are receiving this mail because:
You are watching all bug changes.