D7948: Only match real MIME types, not e.g. "raw CD image"

ngraham added reviewers: Frameworks, nicolasfella, dfaure, kossebau, vhanda. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D7948 To: ngraham, #frameworks, nicolasfella, dfaure, kossebau, vhanda Cc: #frameworks

D7948: Only match real MIME types, not e.g. "raw CD image"

ngraham created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY BUG: 364884 Only match real MIME types when doing string matching to prevent pulling in unrelated files whose types match the string.

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

ngraham added a comment. It seems odd to have all of these special KIO URLs that we don't actually want to use because they're rough and underdeveloped. They're rough and underdeveloped because they're hidden by default, so nobody sees them, and nobody files bugs or submits patches for them.

D7944: Pre-select navigation bar URL when clicking on it to enter edit mode

ngraham added a comment. Opps, I've corrected the bug number. You're right that this improves one workflow and impairs another, but the way I see it, the patch simply brings consistency with the behavior you get if you hit ctrl-L/Replace Location. Though you're right that it also ta

D7944: Pre-select navigation bar URL when clicking on it to enter edit mode

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7944 To: ngraham, #kde_applications, #frameworks, broulik, dfaure Cc: elvisangelaccio, #frameworks

D7580: Support loading by stream and restoring state on reload

This revision was automatically updated to reflect the committed changes. Closed by commit R383:d1ee5a0e3908: Support loading by stream and restoring state on reload (authored by kossebau). REPOSITORY R383 SVGPart CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7580?vs=19446&id=19814

D7580: Support loading by stream and restoring state on reload

kossebau edited the summary of this revision. kossebau edited the test plan for this revision. REPOSITORY R383 SVGPart BRANCH supportstreamandreload REVISION DETAIL https://phabricator.kde.org/D7580 To: kossebau, #frameworks, dfaure

D7580: Support loading by stream and restoring state on reload

kossebau added a comment. Thanks for quick reaction :) Will push now, even if we discovered another item which needs some more clarification. Would do a follow-up fix then if we find one is needed, INLINE COMMENTS > dfaure wrote in svgpart.cpp:191 > When I reload in konqueror (with KHTML or

D7944: Pre-select navigation bar URL when clicking on it to enter edit mode

elvisangelaccio added a comment. The linked bug looks wrong. I'm not sure I agree with this change. We save a click if we want to go from `/home/foo` to e.g. `/usr`, but we add an additional click if we just want to append something to `/home/foo`. I do this all the time (to go in the hi

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

markg added a comment. In https://phabricator.kde.org/D7446#148070, @elvisangelaccio wrote: > Yeah I also find weird to see weblinks in there. Maybe if we call it "History" would be a bit better (and it would also match the History tab in Kickoff). Perhaps, but then we'd still mi

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

elvisangelaccio added a comment. Yeah I also find weird to see weblinks in there. Maybe if we call it "History" would be a bit better (and it would also match the History tab in Kickoff). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin, #kde_

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

markg added a comment. In https://phabricator.kde.org/D7446#148059, @ngraham wrote: > I don't think this is "semi-useful". " A Recent Documents feature in the file manager and open/save dialogs is IMHO really important, especially for lesst-technical users who use features like this on o

D7944: Pre-select navigation bar URL when clicking on it to enter edit mode

ngraham added reviewers: KDE Applications, Frameworks, broulik, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7944 To: ngraham, #kde_applications, #frameworks, broulik, dfaure Cc: #frameworks

D7944: Pre-select navigation bar URL when clicking on it to enter edit mode

ngraham created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY BUG: 333219 When the user clicks on a non-editable navigation bar to enter edit mode, always pre-select the URL. We mimic the beha

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

ngraham added a comment. I don't think this is "semi-useful". " A Recent Documents feature in the file manager and open/save dialogs is IMHO really important, especially for lesst-technical users who use features like this on other platforms expensively instead of making extensive use of fol

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

markg added a comment. You could continue and add about a dozen more "semi-useful" protocol links (ftp, settings, programs, bluetooth, and much more) ;) . I don't think that's the route for the places panel to go. Not by default that is. If the user wants it, it can be added just like any

D7580: Support loading by stream and restoring state on reload

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > svgpart.cpp:191 > +// we can't tell if caller has explicitely set xOffset/yOffset of > OpenUrlArguments > +// so in case of same url we just assume a reload and

D7167: Ignore default mark in icon border for single selectable mark

croick marked an inline comment as done. croick added a comment. In https://phabricator.kde.org/D7167#146752, @dhaumann wrote: > I think the patch makes sense, but I would prefer using a Qt function qPopulationCount to count the bits instead of doing own bitmask magic. Could you provide

D7167: Ignore default mark in icon border for single selectable mark

croick updated this revision to Diff 19807. croick added a comment. - use qPopulationCount to count editable marks REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7167?vs=17786&id=19807 BRANCH defaultmarker REVISION DETAIL https://phabricator.kde.or

D7884: - Increase size of trailing mark

dhaumann added a comment. Kate already has many options, so we try to be careful with adding even more options. What I would like to clarify first is the use case: If I understand correctly, the trailing space visualization is too decent for you. The decency is indeed intended, since th

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

ngraham added a comment. Anybody object? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, emmanuelp Cc: alexeymin, #frameworks, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, #

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 107 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/107/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Fri, 22 Sep 2017 15:28:19 + Build duration: 13 min and counting JUnit Tests Name: (root) F

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 108 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/108/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 22 Sep 2017 15:28:19 + Build duration: 11 min and counting JUnit Tests Name: (root)

D7580: Support loading by stream and restoring state on reload

kossebau added a comment. In https://phabricator.kde.org/D7580#145144, @kossebau wrote: > With the latest update then this patch would represent the blue-print for KParts plugins as I see it when it comes to supporting both state restoring and support for streams, at least for what is po

D7891: expose the colorset for the stylesheet

mart edited the test plan for this revision. mart added reviewers: Frameworks, Plasma, hein. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D7891 To: mart, #frameworks, #plasma, hein Cc: #frameworks

D7891: expose the colorset for the stylesheet

mart added a reviewer: dfaure. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D7891 To: mart, #frameworks, #plasma, hein, dfaure Cc: #frameworks

D7891: expose the colorset for the stylesheet

mart updated this revision to Diff 19787. mart added a comment. - make it work REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7891?vs=19701&id=19787 BRANCH mart/colorSet REVISION DETAIL https://phabricator.kde.org/D7891 AFFECTED FILES src/CMake

D7884: - Increase size of trailing mark

helio added a comment. F3921383: configsize.png REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc: sars, #frameworks, cullmann, dhaumann

D7884: - Increase size of trailing mark

helio updated this revision to Diff 19786. helio added a comment. - Make size configurable keeping the original default REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7884?vs=19686&id=19786 BRANCH big_trailing REVISION DETAIL https://phabricator.kd

D7929: [WIP] Add new Column View option to KDirOperator

fvogt added a comment. In https://phabricator.kde.org/D7929#147784, @ngraham wrote: > I'll just leave this here: ;-) https://bugs.kde.org/show_bug.cgi?id=290747 In https://phabricator.kde.org/D7929#147806, @dhaumann wrote: > Since this adds the column view again, how doe

KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/28/ Project: Frameworks baloo kf5-qt5 XenialQt5.7 Date of build: Fri, 22 Sep 2017 10:13:41 + Build duration: 5 min 9 sec and counting JUnit Tests Name:

D7855: Fix tags KIO-slave protocol description

This revision was automatically updated to reflect the committed changes. Closed by commit R293:8d7db8710ed6: Fix tags KIO-slave protocol description (authored by nicolasfella). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7855?vs=19598&id=19782 REVISION DETA

D7660: Fix a regression caused by changing backspace key behavior

safaalfulaij updated this revision to Diff 19781. safaalfulaij added a comment. - Typos and better if statement structure REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7660?vs=19370&id=19781 BRANCH master REVISION DETAIL https://phabricator.kde.or

D7929: [WIP] Add new Column View option to KDirOperator

cfeck added a comment. Exactly because of this confusion (file dialog vs. Dolphin) I would not add columns to the file dialog unless they are also implemented in Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7929 To: fvogt, #frameworks Cc: cfeck, dhaumann, ng

D7929: [WIP] Add new Column View option to KDirOperator

dhaumann added a comment. Since this adds the column view again, how does this relate to the decision of dropping the column view back in 2012, see comment in this blog: http://ppenz.blogspot.fr/2012/01/dolphin-20-status-update.html?showComment=1325669619833&m=1 Are the issues of maint