D7929: [WIP] Add new Column View option to KDirOperator

fvogt added a comment. In https://phabricator.kde.org/D7929#148679, @dhaumann wrote: > Ok. What about licensing? The copied Qt code says LGPLv3 only, while the kio frameworks uses LGPLv2 (and maybe later). Those two licenses are incompatible - we cannot mix LGPLv3 only with an LGPLv2+ li

D7909: Add syntax support for Crystal Programming Language

faguilar added a reviewer: Kate. faguilar added a subscriber: Kate. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7909 To: faguilar, dhaumann, vkrause, #framework_syntax_highlighting, #kate Cc: #kate, #frameworks, faguilar, cullmann, vkrause, dhaumann

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 108 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/108/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Mon, 25 Sep 2017 02:50:25 + Build duration: 23 min and counting JUnit Tests Name: (root) F

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 109 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/109/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 25 Sep 2017 02:50:25 + Build duration: 22 min and counting JUnit Tests Name: (root)

D7977: KSqueezedTextLabel: Squeeze text when changing indent or margin

cfeck added a comment. > Qt does not send a resize event But does it send QEvent::ContentsRectChange? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D7977 To: rkflx, #frameworks, dhaumann, cfeck

Re: Buddies/Tabstops in designer for aggregated KDE widgets?

El diumenge, 24 de setembre de 2017, a les 14:55:37 CEST, Milian Wolff va escriure: > Hey all, > > I'm trying to get set a sane tabstop order for the record page of hotspot. BTW I could not fint any "hotspot" in https://cgit.kde.org/ Cheers, Albert

Re: Buddies/Tabstops in designer for aggregated KDE widgets?

El diumenge, 24 de setembre de 2017, a les 14:55:37 CEST, Milian Wolff va escriure: > Hey all, > > I'm trying to get set a sane tabstop order for the record page of hotspot. > To reproduce: > > designer hotspot/src/recordpage.ui > Ctrl + R to preview > -> tab through the form > > It's horrible.

D7977: KSqueezedTextLabel: Squeeze text when changing indent or margin

dhaumann added a comment. Ok, now we are back to the initial patch, which is probably fine. @cfeck Do you have any issues with this, or would you also agree with this patch? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D7977 To: rkflx, #frameworks, dha

D7929: [WIP] Add new Column View option to KDirOperator

dhaumann added a comment. Ok. What about licensing? The copied Qt code says LGPLv3 only, while the kio frameworks uses LGPLv2 (and maybe later). Those two licenses are incompatible - we cannot mix LGPLv3 only with an LGPLv2+ library, except if we make it LGPLv3 only as well. I don't wan

D7977: KSqueezedTextLabel: Squeeze text when changing indent or margin

rkflx added a comment. F3924355: compat_report.html REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D7977 To: rkflx, #frameworks, dhaumann, cfeck

D7977: KSqueezedTextLabel: Squeeze text when changing indent or margin

rkflx created this revision. rkflx added reviewers: Frameworks, dhaumann, cfeck. Restricted Application added a project: Frameworks. REVISION SUMMARY When the label is not able to resize in a given layout and calls to `setIndent` or `setMargin` further reduce the space available, the text sh

D7976: Highlighting indexer: factor out checks for smaller while loop

dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Reduce while loop that iterates over the XML elements. This helps to reduce the logic in the loop, mak

D7951: ContextChecker: support '!' context switchting and fallthroughContext

This revision was automatically updated to reflect the committed changes. Closed by commit R216:2c3571fcd091: ContextChecker: support '!' context switchting and fallthroughContext (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D7966: KComboBox: Reuse the existing completion object on new line edit

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Just to be sure, your unittest could also test the case of setEditable(false). REPOSITORY R284 KCompletion BRANCH master REVISION DETAIL https://phabricator.kde.org/D7966 To: mwolff

D7841: kioexec: Do not start to watch a temporary copy until after the copy is complete

dfaure accepted this revision. dfaure added a comment. Perfect, thanks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7841 To: marten, #frameworks, dfaure Cc: elvisangelaccio, dfaure

D7841: kioexec: Do not start to watch a temporary copy until after the copy is complete

marten updated this revision to Diff 19864. marten added a comment. Updated in accordance with review comments. Go easy - it's the first lambda that I've submitted... REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7841?vs=19565&id=19864 REVISION DETAIL htt

D7841: kioexec: Do not start to watch a temporary copy until after the copy is complete

marten marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7841 To: marten, #frameworks, dfaure Cc: elvisangelaccio, dfaure

Re: Buddies/Tabstops in designer for aggregated KDE widgets?

On Sonntag, 24. September 2017 14:55:37 CEST Milian Wolff wrote: > Hey all, > > I'm trying to get set a sane tabstop order for the record page of hotspot. > To reproduce: > > designer hotspot/src/recordpage.ui > Ctrl + R to preview > -> tab through the form > > It's horrible... For me, the first

Buddies/Tabstops in designer for aggregated KDE widgets?

Hey all, I'm trying to get set a sane tabstop order for the record page of hotspot. To reproduce: designer hotspot/src/recordpage.ui Ctrl + R to preview -> tab through the form It's horrible... For me, the first to have focus is the output file's file dialog button. I also notice that I can't

D7968: WIP: Forward QComboBox signals instead of QComboBox lineedit signals

mwolff created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The QComboBox may not be editable when we connect the signals. When we change the editable flag later on, the signals wouldn't be connecte

D7967: KComboBox: Return early when setting editable to previous value

mwolff created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Instead of creating a new line edit, keep the previous one intact. This ensures we don't set a new line edit for code such as the followin

D7966: KComboBox: Reuse the existing completion object on new line edit

mwolff created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY When a KComboBox was created and a completion object configured on it, that setting was lost once the combo box was set to be editable. To

D7884: - Increase size of trailing mark

cullmann added a comment. I would rather go with the "make the markers much larger but less contrast" solution than a setting for their size. Perhaps we really just need to look at how other editors do that. Eye-cancer like markers are no solution either, but I agree that if people turn t

D7841: kioexec: Do not start to watch a temporary copy until after the copy is complete

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Makes sense. INLINE COMMENTS > main.cpp:151 > +for (; it != fileList.end(); ++it) { > +if (it->path == path) { > +break; (pre-existing) std:

D7750: fix crash when more than one instances of ExtractorCollection are destructed

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > mgallien wrote in extractor.cpp:34 > If the Extractor is built using the move constructor, the other instance will > have a null d pointer. As far as I know,

D7884: - Increase size of trailing mark

anthonyfieroni added inline comments. INLINE COMMENTS > katerenderer.cpp:272 > + > +pen.setWidthF(spaceWidth() / (3.5 - (m_markerSize * 0.5))); > pen.setCapStyle(Qt::RoundCap); You can move width calculation in setmarkersize to safe unwanted calculations. > katerenderer.h:406 > bo

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 118 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/118/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 24 Sep 2017 09:57:52 + Build duration: 11 min and counting JUni

KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 114 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/114/ Project: Frameworks plasma-framework kf5-qt5 XenialQt5.7 Date of build: Sun, 24 Sep 2017 09:57:52 + Build duration: 9 min 40 sec and counting

D7680: Fix build without KDocTools

This revision was automatically updated to reflect the committed changes. Closed by commit R242:18d04e9b4142: Fix build without KDocTools (authored by vkrause). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7680?vs=19144&id=19854 REVISION

D7884: - Increase size of trailing mark

helio added a comment. Is not that simple. Change only the color is fine, but then the effect is almost imperceptible, Right now from home i'm using a 25' 2560x1440 resolution with fonts in size 10. Is a regular monitor, not the most expensive. Even changing the color a single pixel is

D7678: Fix compilation on Linux without X11

This revision was automatically updated to reflect the committed changes. Closed by commit R303:9a3ec9f1e546: Fix compilation on Linux without X11 (authored by vkrause). REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7678?vs=19141&id=19853 REVISION DETAIL htt

D7951: ContextChecker: support '!' context switchting and fallthroughContext

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH contextchecker (branched from master) REVISION DETAIL https://phabricator.kde.org/D7951 To: dhaumann, cullmann, vkrause Cc: #frameworks

D6709: [RFC] Add support for sharing file descriptor between KIO slave and KAuth helper

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Yes `isListening()` would make sense. The kauth subdir for fdsender.* is ok, it matches what you then do in https://phabricator.kde.org/D6197 where you actually use that file (well, yo

D7699: Add support for custom search paths for application-specific syntax and theme definitions

vkrause accepted this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7699 To: zrax, #kate, #framework_syntax_highlighting, dhaumann, vkrause Cc: dhaumann, vkrause, cullmann, #framework_syntax_highlighting, #frameworks

D7891: expose the colorset for the stylesheet

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kiconloader.h:465 > + > +//TODO: do an own colorset enum to not export publicly ConfigWidgets? > +/** I guess this is OK as is, so remove the comment (it's not

D7954: Fix repaint loop in KToolBar

dfaure added a comment. Uploaded my patch, now with unittest: https://phabricator.kde.org/D7964 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D7954 To: mardelle, #frameworks, ilic, dfaure

D7964: KAcceleratorManager: set icon text on actions to remove CJK markers

dfaure created this revision. dfaure added reviewers: mardelle, ilic, sandsmark. REVISION SUMMARY This replaces the KToolBar event filter hack to solve the same issue: when an action text appears in a menu we want the & accelerator, while in toolbars wewant that removed. Qt takes care of it,

KDE CI: Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20XenialQt5.7/42/ Project: Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7 Date of build: Sun, 24 Sep 2017 08:24:38 + Build duration: 5 min 44 sec and counting JUnit

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.7/42/ Project: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 24 Sep 2017 08:24:38 + Build duration: 4 min 38 sec and counting JUn