KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 75 - Still Unstable!

2017-09-25 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/75/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 26 Sep 2017 02:55:45 + Build duration: 21 min and counting JUnit Tests

D7750: fix crash when more than one instances of ExtractorCollection are destructed

2017-09-25 Thread Matthieu Gallien
mgallien marked an inline comment as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D7750 To: mgallien, #frameworks, dfaure Cc: dfaure, anthonyfieroni

D7750: fix crash when more than one instances of ExtractorCollection are destructed

2017-09-25 Thread Matthieu Gallien
mgallien added a comment. Reverted most of my changes and only use a private method with two parameters to set the ExtractorPlugin in Extractor class. The second parameter should indicate if the Extractor instance is owner of the plugin or not. The private class is no longer included in extr

D7750: fix crash when more than one instances of ExtractorCollection are destructed

2017-09-25 Thread Matthieu Gallien
mgallien updated this revision to Diff 19918. mgallien marked 6 inline comments as done. mgallien added a comment. add missing noexcept REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7750?vs=19917&id=19918 BRANCH fixPluginDelete REVISION DETAIL

D7750: fix crash when more than one instances of ExtractorCollection are destructed

2017-09-25 Thread Matthieu Gallien
mgallien updated this revision to Diff 19917. mgallien added a comment. reduce the scope of modifications, use an enum to indicate if the plugin should be deleted and use private methods instead of direct access to private class REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE h

D7976: Highlighting indexer: factor out checks for smaller while loop

2017-09-25 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:4b6a5d89aa77: Highlighting indexer: factor out checks for smaller while loop (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7976

D7977: KSqueezedTextLabel: Squeeze text when changing indent or margin

2017-09-25 Thread Henrik Fehlauer
rkflx edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D7977 To: rkflx, #frameworks, dhaumann, cfeck

D7977: KSqueezedTextLabel: Squeeze text when changing indent or margin

2017-09-25 Thread Henrik Fehlauer
rkflx added a comment. In https://phabricator.kde.org/D7977#148689, @cfeck wrote: > > Qt does not send a resize event > > But does it send QEvent::ContentsRectChange? No, because this one is only emitted by `setContentsMargin`, but not by `setMargin` (read https://phabricator.

[kglobalaccel] src/runtime/plugins/xcb: Revert "KGlobalAccel: port to KKeyServer's new method symXModXToKeyQt, to fix numpad keys"

2017-09-25 Thread Martin Flöser
Git commit 68e35f234ca7d866bcb54442d22892450d871848 by Martin Flöser. Committed on 25/09/2017 at 15:30. Pushed by graesslin into branch 'master'. Revert "KGlobalAccel: port to KKeyServer's new method symXModXToKeyQt, to fix numpad keys" This reverts commit 2c20ddff034e4958bf0536ca91ae9e444955305

D7976: Highlighting indexer: factor out checks for smaller while loop

2017-09-25 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH refactorindexer REVISION DETAIL https://phabricator.kde.org/D7976 To: dhaumann, vkrause Cc: #frameworks

D7884: - Increase size of trailing mark

2017-09-25 Thread Helio Castro
helio added a comment. In https://phabricator.kde.org/D7884#148489, @cullmann wrote: > I would rather go with the "make the markers much larger but less contrast" solution than a setting for their size. > Perhaps we really just need to look at how other editors do that. > Eye-cancer

D7884: - Increase size of trailing mark

2017-09-25 Thread Helio Castro
helio added a comment. Fixed requests REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc: cullmann, anthonyfieroni, dhaumann, sars, #frameworks

D7884: - Increase size of trailing mark

2017-09-25 Thread Helio Castro
helio updated this revision to Diff 19888. helio marked 3 inline comments as done. helio added a comment. - Moved calc logic to updateMarkerSize - Fix identation - Make value properly float - Update view when apply pressed REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https:/

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 110 - Still Unstable!

2017-09-25 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/110/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 25 Sep 2017 07:59:29 + Build duration: 19 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 109 - Still Unstable!

2017-09-25 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/109/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Mon, 25 Sep 2017 07:59:29 + Build duration: 17 min and counting JUnit Tests Name: (root) F

D7841: kioexec: Do not start to watch a temporary copy until after the copy is complete

2017-09-25 Thread Jonathan Marten
This revision was automatically updated to reflect the committed changes. Closed by commit R241:c76c1486ec79: kioexec: Watch the file when it has finished copying (authored by marten). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7841?vs=19864&id=19885 REVISION