D8243: Implement support for categories on KfilesPlacesView

ervin added a comment. One more thing, the way the sections are currently done, if I drag the first item of a section the visual feedback I get also includes the section itself giving the feeling that the section itself is being moved. Also I can drag from the section title itself which is a

D8243: Implement support for categories on KfilesPlacesView

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Note that the summary part of the commit is now wrong (it still refers to KCategorizedView). Also, KFilePlacesModelTest needs to be adjusted to take into account the new behavi

D8243: Implement support for categories on KfilesPlacesView

anthonyfieroni added inline comments. INLINE COMMENTS > kfileplacesview.cpp:104 > + > +int m_sectionRole; > + const > kfileplacesview.cpp:1065-1066 > const int maxWidth = q->viewport()->width() - textWidth - 4 * margin - 1; > -const int maxHeight = ((q->height() - (fm.height() / 2)

D8254: Make file ioslave backend on removeables are user-frendly on linux

ngraham added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8254 To: vova7890, #frameworks Cc: alexeymin, #frameworks

D8256: Add _XOPEN_SOURCE to C definitions

awilcox added a comment. Please do note that `_XOPEN_SOURCE` must be `600` and not `700` because some components of KDE still use `rindex` which is no longer supported in X/Open 7 . REPOSITORY R240 Extra CMake Modules

D8256: Add _XOPEN_SOURCE to C definitions

awilcox created this revision. awilcox added a reviewer: alexmerry. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY (This was reported on the KDE bug tracker as Bug 373175

D7130: KMoreTools: Update and fix desktopfiles

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I'm afraid this doesn't merge cleanly onto master. @gregormi, can you rebase it against current master so that I can merge it? REPOSITORY R304 KNewStuff REVISION DETAIL htt

D8064: Correct installation of start_kdeinit when DESTDIR and libcap are used together

awilcox updated this revision to Diff 20619. awilcox added a comment. This diff was created with `git diff`. REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8064?vs=20125&id=20619 REVISION DETAIL https://phabricator.kde.org/D8064 AFFECTED FILES src/star

D8254: Make file ioslave backend on removeables are user-frendly on linux

vova7890 created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Currently on linux copying file on the flash drive is showing momental progress 0 -> 100% and at the end of 100% is waiting while file are

D7130: KMoreTools: Update and fix desktopfiles

ngraham added a comment. My brain knows that, but apparently my fingers didn't. :p REPOSITORY R304 KNewStuff BRANCH mydev REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, ngraham Cc: ngraham, ltoscano, #fram

D7130: KMoreTools: Update and fix desktopfiles

ngraham edited the summary of this revision. REPOSITORY R304 KNewStuff BRANCH mydev REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, ngraham Cc: ngraham, ltoscano, #frameworks

D7130: KMoreTools: Update and fix desktopfiles

ltoscano added a comment. BUG: n REPOSITORY R304 KNewStuff BRANCH mydev REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, ngraham Cc: ngraham, ltoscano, #frameworks

D7130: KMoreTools: Update and fix desktopfiles

ngraham edited the summary of this revision. REPOSITORY R304 KNewStuff BRANCH mydev REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, ngraham Cc: ngraham, ltoscano, #frameworks

D7130: KMoreTools: Update and fix desktopfiles

elvisangelaccio accepted this revision as: elvisangelaccio. elvisangelaccio added a comment. I had tested the patch and it was fixing the bug. I'm fine with this as long as @gregormi volunteers to maintain this code updated (and eventually to switch to a better design, if possible). REPOSIT

D7369: Wayland foreign protocol

graesslin added a comment. There is still quite some documentation missing. Especially the server side is not yet documented enough that I would know how to use the new API and what it does. It's totally fine to copy and adapt the documentation from the Wayland xml protocol. INLINE COMMENTS

D8243: Implement support for categories on KfilesPlacesView

renatoo updated this revision to Diff 20613. renatoo added a comment. Does not use KCategorizedView Instead of use KCategorizedView, draw the section over the first item area REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8243?vs=20587&id=20613 BRANCH m

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 117 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/117/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Wed, 11 Oct 2017 17:47:39 + Build duration: 6 min 40 sec and counting JUnit Tests Name: (r

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 118 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/118/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 11 Oct 2017 17:47:39 + Build duration: 3 min 3 sec and counting CONSOLE OUTPUT [...t

D6829: Add ability to use the new kauth helper in file ioslave

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c4726e843e42: Add ability to use the new kauth helper in file ioslave (authored by chinmoyr). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6829?vs=20311&id=20610#toc REPOSITORY R241 KIO C

D7130: KMoreTools: Update and fix desktopfiles

ltoscano added a comment. The line `update desktop files including fix for PartitionManager and KDiskFree (https://bugs.kde.org/show_bug.cgi?id=369646)` should be fixed to have BUG:... REPOSITORY R304 KNewStuff BRANCH mydev REVISION DETAIL https://phabricator.kde.org/D7130 To: grego

D7130: KMoreTools: Update and fix desktopfiles

ltoscano resigned from this revision. ltoscano added a comment. This revision is now accepted and ready to land. I still disagree in the way this is done, as it means manually periodically updating the information and it's definitely not the right thing to do. That said, if @elvisangelacc

D7130: KMoreTools: Update and fix desktopfiles

ngraham added a comment. @ltoscano, can we commit this? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, ngraham Cc: ngraham, ltoscano, #frameworks

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 116 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/116/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Wed, 11 Oct 2017 16:48:31 + Build duration: 17 min and counting JUnit Tests Name: (root) F

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 117 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/117/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 11 Oct 2017 16:45:43 + Build duration: 7 min 24 sec and counting CONSOLE OUTPUT [...

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 115 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/115/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Wed, 11 Oct 2017 16:31:13 + Build duration: 17 min and counting JUnit Tests Name: (root) F

KCModuleContainer

Hi, I'm trying to use KCModuleContainer to show 3 kcm modules, however this class constantly crashes when switching tabs. checking the sourcecode, I see the reason: void KCModuleContainer::tabSwitched(int index) ... setAboutData(mod->aboutData()); but since the base class KCModule always de

D6197: Add kauth helper to file ioslave

This revision was automatically updated to reflect the committed changes. Closed by commit R241:29a741982fe5: Add kauth helper to file ioslave (authored by chinmoyr). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6197?vs=20310&id=20608#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDAT

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added a comment. In https://phabricator.kde.org/D8050#154356, @davidedmundson wrote: > I'm not resubmitting something just for the purpose of you two winding each other up. Eh, it was not meant like that. I just wanted to point out that this does not need any changes in

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 116 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/116/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Wed, 11 Oct 2017 16:31:13 + Build duration: 7 min 39 sec and counting CONSOLE OUTPUT [...

D8050: Expose wl_display_set_global_filter as a virtual method

davidedmundson added a comment. I'm not resubmitting something just for the purpose of you two winding each other up. We're in no rush for this. I'll check what suse has and go from there. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8050 To: davidedmundson

D6709: [RFC] Add support for sharing file descriptor between KIO slave and KAuth helper

This revision was automatically updated to reflect the committed changes. Closed by commit R241:0c2a6811dc50: Add support for sharing file descriptor between file ioslave and it's KAuth… (authored by chinmoyr). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6709?vs=20232&id=20607#toc REP

KDE CI: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20XenialQt5.7/35/ Project: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 Date of build: Wed, 11 Oct 2017 15:39:26 + Build duration: 13 min and counting JUnit Tests

D8224: Support flatpak platform

This revision was automatically updated to reflect the committed changes. Closed by commit R278:ec3c59e535fa: Support flatpak platform (authored by graesslin). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8224?vs=20524&id=20603 REVISION DETAIL https

D8250: [client] Drop the checks for platformName being "wayland"

graesslin created this revision. graesslin added reviewers: Frameworks, KWin, Flatpak. Restricted Application added a subscriber: plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. REVISION SUMMARY There are also QPA's which are "wayland" but have a different nam

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin accepted this revision. graesslin added a comment. I'm accepting this revision again. The CI system needs to have the PPA activated again as the old CI system had. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8050 To: davidedmundson, #plasma, graesslin

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added a comment. In https://phabricator.kde.org/D8050#154207, @bcooksley wrote: > Please remedy the Wayland dependency incompatibility. > > In the event the relevant package is not available in the distribution in question, you'll need to contact it's packagers and make the

D8243: Implement support for categories on KfilesPlacesView

anthonyfieroni added a reviewer: dfaure. anthonyfieroni added inline comments. INLINE COMMENTS > kfileplacesview.h:37 > */ > -class KIOFILEWIDGETS_EXPORT KFilePlacesView : public QListView > +class KIOFILEWIDGETS_EXPORT KFilePlacesView : public KCategorizedView > { You cannot do that, you hav

D8243: Implement support for categories on KfilesPlacesView

cfeck added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8243 To: renatoo, #frameworks Cc: cfeck, #frameworks

D8243: Implement support for categories on KfilesPlacesView

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Make use of KCategorizedView on file dialogs to classify the entries in groups, most similar as possible with dolphin TEST PLAN From a

D7884: - Increase size of trailing mark

sars added a comment. I'm OK with an option for this. The only problem, with the option in the screen-shot, is that it could be interpreted as also effecting the tabulator mark. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc: cu

D7660: Fix a regression caused by changing backspace key behavior

anthonyfieroni added inline comments. INLINE COMMENTS > katedocument.cpp:3169-3223 > if (!(config()->backspaceIndents())) { > // ordinary backspace > -KTextEditor::Cursor beginCursor(line, > view->textLayout(c)->previousCursorPosition(c.column())); > +

D7660: Fix a regression caused by changing backspace key behavior

cullmann added a comment. All issues addressed, or? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7660 To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann Cc: cullmann, jgrulich, dhaumann, hein, kwrite-devel, #frameworks

D7884: - Increase size of trailing mark

cullmann added a comment. Given it seems Atom even has the option to choose the sign for that, we can live with an option I assume (and the code for it is already written anyways). Others ok with that, too? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884

D8050: Expose wl_display_set_global_filter as a virtual method

davidedmundson added a comment. This was reverted since yesterday when we noticed CI failed. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8050 To: davidedmundson, #plasma, graesslin, bcooksley Cc: bcooksley, graesslin, plasma-devel, #frameworks, ZrenBot, progwolf

D8050: Expose wl_display_set_global_filter as a virtual method

bcooksley requested changes to this revision. bcooksley added a comment. This revision now requires changes to proceed. Please remedy the Wayland dependency incompatibility. In the event the relevant package is not available in the distribution in question, you'll need to contact it's pac

D8050: Expose wl_display_set_global_filter as a virtual method

bcooksley reopened this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8050 To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreu

D7369: Wayland foreign protocol

mart added a comment. In https://phabricator.kde.org/D7369#154153, @graesslin wrote: > In https://phabricator.kde.org/D7369#153978, @mart wrote: > > > In https://phabricator.kde.org/D7369#152358, @graesslin wrote: > > > > > Documentation is still missing, Unstable suffix is still i

D7369: Wayland foreign protocol

mart updated this revision to Diff 20584. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - update to the upstream xml protocol REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7369?vs=20553&id=20584 BR

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 55 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/55/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Wed, 11 Oct 2017 06:56:21 + Build duration: 9 min 4 sec and counting JUnit Tests