jbbgameich closed this revision.
REPOSITORY
R307 KPeople
REVISION DETAIL
https://phabricator.kde.org/D22425
To: jbbgameich, #plasma:_mobile, #kde_pim, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Thanks!
REPOSITORY
R307 KPeople
BRANCH
personsmodel-phoneNumber (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D22425
To: jbbgameich, #plasma:_mobile, #kde_pim, apol
jbbgameich added a comment.
Does that mean it's ready to land now?
REPOSITORY
R307 KPeople
REVISION DETAIL
https://phabricator.kde.org/D22425
To: jbbgameich, #plasma:_mobile, #kde_pim, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
jbbgameich updated this revision to Diff 61686.
jbbgameich added a comment.
Put PhoneNumberRole after GroupsRole
REPOSITORY
R307 KPeople
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22425?vs=61671&id=61686
BRANCH
personsmodel-phoneNumber (branched from master)
REVISION DETAI
apol added a comment.
Other than that LGTM
INLINE COMMENTS
> personsmodel.h:60
> +UserRole = Qt::UserRole + 0x1000, ///< in case it's needed to
> extend, use this one to start from
> +PhoneNumberRole
> };
Put it after GroupsRole
REPOSITORY
R307 KPeople
REVISION DETA
bshah added a reviewer: apol.
REPOSITORY
R307 KPeople
REVISION DETAIL
https://phabricator.kde.org/D22425
To: jbbgameich, #plasma:_mobile, #kde_pim, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
jbbgameich added a reviewer: KDE PIM.
REPOSITORY
R307 KPeople
REVISION DETAIL
https://phabricator.kde.org/D22425
To: jbbgameich, #plasma:_mobile, #kde_pim
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
jbbgameich added a reviewer: Plasma: Mobile.
REPOSITORY
R307 KPeople
REVISION DETAIL
https://phabricator.kde.org/D22425
To: jbbgameich, #plasma:_mobile
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
jbbgameich updated this revision to Diff 61671.
jbbgameich added a comment.
fix indentation
REPOSITORY
R307 KPeople
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22425?vs=61670&id=61671
BRANCH
personsmodel-phoneNumber (branched from master)
REVISION DETAIL
https://phabricat
jbbgameich created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jbbgameich requested review of this revision.
REVISION SUMMARY
This is intended to provide shared code for plasma-phone-components and
spacebar.
TEST PLAN
The phoneNumber ca
10 matches
Mail list logo