broulik added a comment.
I now have runner queries never "finish". I type "plasmashell", get the
results I expect, and the busy indicator keeps spinning forever.
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D29050
To: alex, meven, ngraham, broulik
Cc: davidedmunds
alex closed this revision.
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D29050
To: alex, meven, ngraham, broulik
Cc: davidedmundson, cfeck, kde-frameworks-devel, Orage, LeGast00n,
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, michaelh,
ZrenBot, n
alex added a comment.
Now I understand where it is called and how it works exactly.
May I ship this?
REPOSITORY
R308 KRunner
BRANCH
krunner_signal_bugfix (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29050
To: alex, meven, ngraham, broulik
Cc: davidedmundson, c
alex edited the summary of this revision.
REPOSITORY
R308 KRunner
BRANCH
krunner_signal_bugfix (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29050
To: alex, meven, ngraham, broulik
Cc: davidedmundson, cfeck, kde-frameworks-devel, Orage, LeGast00n,
The-Feren-OS-Dev,
alex added a comment.
> Repo is called milou
Thanks!
REPOSITORY
R308 KRunner
BRANCH
krunner_signal_bugfix (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29050
To: alex, meven, ngraham, broulik
Cc: davidedmundson, cfeck, kde-frameworks-devel, Orage, LeGast00n,
davidedmundson added a comment.
> the runner "backend" is used (from the QML side of things).
Repo is called milou
REPOSITORY
R308 KRunner
BRANCH
krunner_signal_bugfix (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29050
To: alex, meven, ngraham, broulik
Cc:
alex added a comment.
But can you please explain, where in the QML code the actual KRunner backend
is used?
Maybe then I can understand it better 🙃.
REPOSITORY
R308 KRunner
BRANCH
krunner_signal_bugfix (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29050
To: al
broulik added a comment.
I'm sorry, I don't really know how this teardown stuff all works :/
REPOSITORY
R308 KRunner
BRANCH
krunner_signal_bugfix (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29050
To: alex, meven, ngraham, broulik
Cc: cfeck, kde-frameworks-devel
alex added a comment.
Thanks and I get why it is hard to review.
Could @broulik please help/have a look at this.
A issue I have with understanding some of the KRunner stuff is that I don't
know where exactly
the runner "backend" is used (from the QML side of things).
Thanks 😃
RE
meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.
It is hard to understand why it was wrongly placed here, that makes this hard
to review and approve.
But you are getting familiar with KRunner internals, so since it does seem
benign and yo
alex edited the summary of this revision.
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D29050
To: alex, meven, ngraham, broulik
Cc: cfeck, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, ragreen, michaelh, ZrenBot, ngr
alex retitled this revision from "WIP KRunner fix prepare/teardown signals" to
"KRunner fix prepare/teardown signals".
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D29050
To: alex, meven, ngraham, broulik
Cc: cfeck, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS
12 matches
Mail list logo
