[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190
Bug 10190 depends on bug 36641, which changed state.

Bug 36641 Summary: Add an endpoint to list circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36641

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

GIT URL||https://github.com/openfift
   ||h/koha/tree/bug_10190_submi
   ||ssion-rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #173 from Martin Renvoize (ashimema) 
 ---
Koha's been moving so fast.. probably best to use the public branch for this:
https://github.com/openfifth/koha/tree/bug_10190_submission-rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #172 from Caroline Cyr La Rose  
---
I wanted to see what it looked like, but unfortunately, the patch doesn't apply
anymore...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||francois.charbonnier@inlibr
   ||o.com

--- Comment #171 from Caroline Cyr La Rose  
---
*** Bug 12772 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Marion Durand  changed:

   What|Removed |Added

 CC||marion.dur...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

   Keywords||Hackfest

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Michaela Sieber  changed:

   What|Removed |Added

 CC||clemens.tub...@kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #170 from Martin Renvoize (ashimema) 
 ---
(In reply to Victor Grousset/tuxayo from comment #169)
> Comment on attachment 178648 [details] [review]
> Bug 10190: Add a vue app for circulation triggers
> 
> Review of attachment 178648 [details] [review]:
> -
> 
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/circulation_triggers.tt
> @@ +25,5 @@
> > +
> > +
> > +[% MACRO jsinclude BLOCK %]
> > +[% INCLUDE 'calendar.inc' %]
> > +
> 
> Is the FIXME for calendar.inc above or datatables.inc bellow or the 4
> includes below?

It was for calendar.inc and if you look at the other vue apps, it's consistent
throughout them so far.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #169 from Victor Grousset/tuxayo  ---
Comment on attachment 178648
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178648
Bug 10190: Add a vue app for circulation triggers

Review of attachment 178648:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10190&attachment=178648)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/circulation_triggers.tt
@@ +25,5 @@
> +
> +
> +[% MACRO jsinclude BLOCK %]
> +[% INCLUDE 'calendar.inc' %]
> +

Is the FIXME for calendar.inc above or datatables.inc bellow or the 4 includes
below?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Signed Off  |Failed QA

--- Comment #167 from Victor Grousset/tuxayo  ---
updatedatabase doesn't work:
(have a koha on main, apply the patches and update)

$ updatedatabase
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $itemtype in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 229.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 240.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 251.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $itemtype in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 229.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 240.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 251.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $itemtype in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 229.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 240.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 251.
DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl  [23:24:08]:
Bug 10190 - Migrate overduerules to circulation_rules
Inserting :undef: default most frequent delay for overdue_1:
Inserting :undef:undef default most frequent notice for overdue_1:
Inserting :undef:undef default most frequent mtt for overdue_1:
Inserting :undef:undef default most frequent restrict for overdue_1: 0
Inserting :undef: default most frequent delay for overdue_2:
Inserting :undef:undef default most frequent notice for overdue_2:
Inserting :undef:undef default most frequent mtt for overdue_2:
Inserting :undef:undef default most frequent restrict for overdue_2: 0
Inserting :undef: default most frequent delay for overdue_3:
Inserting :undef:undef default most frequent notice for overdue_3:
Inserting :undef:undef default most frequent mtt for overdue_3:
Inserting :undef:undef default most frequent restrict for overdue_3: 0
ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot
delete or update a parent row: a foreign key constraint fails at
/kohadevbox/koha/C4/Installer.pm line 771

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #168 from Victor Grousset/tuxayo  ---
MariaDB 10.5.26 in case that matters.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #166 from Victor Grousset/tuxayo  ---
Comment on attachment 178644
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178644
Bug 10190: DBIC Schema update

Review of attachment 178644:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10190&attachment=178644)
-

::: Koha/Schema/Result/MessageTransportType.pm
@@ +133,5 @@
>  );
>  
>  
> +# Created by DBIx::Class::Schema::Loader v0.07051 @ 2024-08-15 11:53:13
> +# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:Bx96QiqHxZ9SNbgK8dSwMg

There are no manual changes to split in separate commit. Whole commit should be
marked as [DO NOT PUSH]
https://wiki.koha-community.org/wiki/Database_updates#Files_to_change

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172663|0   |1
is obsolete||

--- Comment #165 from Martin Renvoize (ashimema) 
 ---
Created attachment 178675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178675&action=edit
Bug 10190: Display value of OverdueNoticeFrom in note

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172662|0   |1
is obsolete||

--- Comment #164 from Martin Renvoize (ashimema) 
 ---
Created attachment 178674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178674&action=edit
Bug 10190: Only display default and library specific letters

This patch filters the list of letter templates available to use by only
those available for the context the rule is being added for (i.e. the
correct library relation)

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172661|0   |1
is obsolete||

--- Comment #163 from Martin Renvoize (ashimema) 
 ---
Created attachment 178673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178673&action=edit
Bug 10190: Take DefaultToLoggedInLibraryOverdueTriggers into account

This updates the logic for the default page load to take account of
DefaultToLoggedInLibraryOverdueTriggers.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172660|0   |1
is obsolete||

--- Comment #162 from Martin Renvoize (ashimema) 
 ---
Created attachment 178672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178672&action=edit
Bug 10190: Rename 'All *' to 'Default rule for *'

Try to clarify that the 'All' rules are actually fallback/default rules
for when there's not a more specific rule for the context.

We need to expose these clearly for each 'Library' view too which we're
not currently doing.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172659|0   |1
is obsolete||

--- Comment #161 from Martin Renvoize (ashimema) 
 ---
Created attachment 178671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178671&action=edit
Bug 10190: Rebase for rspack

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172658|0   |1
is obsolete||

--- Comment #160 from Martin Renvoize (ashimema) 
 ---
Created attachment 178670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178670&action=edit
Bug 10190: Update for bootstrap 5

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172657|0   |1
is obsolete||

--- Comment #159 from Martin Renvoize (ashimema) 
 ---
Created attachment 178669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178669&action=edit
Bug 10190: Clarify workflow

This patch re-arranges the edit/add modal form to clarify the
need to select context, then decide on editing an existing trigger or
adding a new one and then, and only then, exposes the actual rule inputs

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172656|0   |1
is obsolete||

--- Comment #158 from Martin Renvoize (ashimema) 
 ---
Created attachment 178668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178668&action=edit
Bug 10190: Add custom input for delay

This custom input allows for dynamic min/max rules and it updates the
input styling to match other inputs on the page including a 'clear'
button.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172655|0   |1
is obsolete||

--- Comment #157 from Martin Renvoize (ashimema) 
 ---
Created attachment 178667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178667&action=edit
Bug 10190: Modal form improvements

We now fetch all rules on modal open and the effective rule on context
selection.

This allows us to compare the specific values of the rule we're
adding/editing to the fallback values present in the all rules set.

We use the fallback rule values as placeholders in the input boxes to
highlight to the end user what value will be used should they choose to
wipe the input.  We also allow wiping inputs and pass 'null' to the API
appropriately.

Finally, we set a minimum value for delay when adding a new rule to
highlight to the user that the new trigger will be added after existing
triggers.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172654|0   |1
is obsolete||

--- Comment #156 from Martin Renvoize (ashimema) 
 ---
Created attachment 178666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178666&action=edit
Bug 10190: Restore 'edit' from 'Add/Edit' Modal

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172653|0   |1
is obsolete||

--- Comment #155 from Martin Renvoize (ashimema) 
 ---
Created attachment 178665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178665&action=edit
Bug 10190: Display effective values and highlight them

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172650|0   |1
is obsolete||

--- Comment #152 from Martin Renvoize (ashimema) 
 ---
Created attachment 178662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178662&action=edit
Bug 10190: Update itiva script to reflect move to circ_rules

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172652|0   |1
is obsolete||

--- Comment #154 from Martin Renvoize (ashimema) 
 ---
Created attachment 178664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178664&action=edit
Bug 10190: Rework logic of overdue_notices

The original logic for digesting overdues in the overdue notices script
was flawed given the additional itemtype handling introduced in this
patchset and the way in which it handles effective fallbacks for rules.

This patch tidies the file and reworks the logic so that we fetch
overdues by patron category and branch and then iterate through those
comparing to the correct effective rules and combing them into digest
groups based on notice + trigger level.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172651|0   |1
is obsolete||

--- Comment #153 from Martin Renvoize (ashimema) 
 ---
Created attachment 178663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178663&action=edit
Bug 10190: Add comments to overdue_notices and rename variable

Trying to fully understand how this script operates.. this patch adds
some notes to the script for developers and also renames a variable that
I found was being re-used.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172649|0   |1
is obsolete||

--- Comment #151 from Martin Renvoize (ashimema) 
 ---
Created attachment 178661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178661&action=edit
Bug 10190: Remove old overduerules interface

This patch updates the link from the tools homepage to open the new
circulation triggers administration page.

We then remove the old overduerules controller and template, and finally
we drop the no longer referenced
C4::Overdues::GetOverdueMessageTransportTypes method and associated unit
tests.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172648|0   |1
is obsolete||

--- Comment #150 from Martin Renvoize (ashimema) 
 ---
Created attachment 178660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178660&action=edit
Bug 10190: Migrate MarkIssueReturned test to circulation rules

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172647|0   |1
is obsolete||

--- Comment #149 from Martin Renvoize (ashimema) 
 ---
Created attachment 178659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178659&action=edit
Bug 10190: Add fallback to 'Default' text for notice

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172646|0   |1
is obsolete||

--- Comment #148 from Martin Renvoize (ashimema) 
 ---
Created attachment 178658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178658&action=edit
Bug 10190: Set tab based on trigger edited/created

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172645|0   |1
is obsolete||

--- Comment #147 from Martin Renvoize (ashimema) 
 ---
Created attachment 178657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178657&action=edit
Bug 10190: Add letter names to tables

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172644|0   |1
is obsolete||

--- Comment #146 from Martin Renvoize (ashimema) 
 ---
Created attachment 178656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178656&action=edit
Bug 10190: Update has_restricting_overdues to refer to circulation rules

This patch updates the Koha::Patron->has_restriction_overdues method to
refer to the migrated overdue rules.

We also correct an oversight in the method prior to this patch that
meant that not all overdues were being correctly checked for a
restriction.. we were incorrectly filtering to only overdues at the
current checkin branch.

Finally, we also take account of the itemtype level addition here too.

NOTE: There weren't any unit tests for this Koha::Patron method.. we
should add some here!

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172642|0   |1
is obsolete||

--- Comment #144 from Martin Renvoize (ashimema) 
 ---
Created attachment 178654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178654&action=edit
Bug 10190: Update overdue_notices script to refer to circ rules

This patch updates the overdue_notices cron script to refer to the new
location for overdue rules found in the circulation rules table now.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172643|0   |1
is obsolete||

--- Comment #145 from Martin Renvoize (ashimema) 
 ---
Created attachment 178655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178655&action=edit
Bug 10190: Add itemtype handling to overdue_notices script

This patch enhances the overdue_notices script to understand the newly
introduced itemtype level for overdue rules.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172641|0   |1
is obsolete||

--- Comment #143 from Martin Renvoize (ashimema) 
 ---
Created attachment 178653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178653&action=edit
Bug 10190: Update GetBranchcodesWithOverdueRules to use CirculationRules

This patch updates the C4::Overdues method
GetBranchecodesWithOverdueRules to refer to the new location of these
rules in the circulation rules table. We also update the unit tests to
move the mocked data into the right location.

We could perhaps migrate this method in Koha::CirculationRules at a
later date?

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172640|0   |1
is obsolete||

--- Comment #142 from Martin Renvoize (ashimema) 
 ---
Created attachment 178652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178652&action=edit
Bug 10190: Let the circulation_rules endpoint accept query parameters

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172639|0   |1
is obsolete||

--- Comment #141 from Martin Renvoize (ashimema) 
 ---
Created attachment 178651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178651&action=edit
Bug 10190: Add itemtypes and patron categories to the item/patron api clients

This patch adds patron and itemtype api clients for the Vue ecosystem

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172638|0   |1
is obsolete||

--- Comment #140 from Martin Renvoize (ashimema) 
 ---
Created attachment 178650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178650&action=edit
Bug 10190: Add a library API client

This patch adds a library api client to the vue ecosystem for later use
in the Circulation triggers page.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172637|0   |1
is obsolete||

--- Comment #139 from Martin Renvoize (ashimema) 
 ---
Created attachment 178649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178649&action=edit
Bug 10190: Add components to list/add and edit circulation triggers

These new components are used by the new 'Circulation triggers'
administration page to display existing trigger rules and add the
ability to add new rules and edit existing ones.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172636|0   |1
is obsolete||

--- Comment #138 from Martin Renvoize (ashimema) 
 ---
Created attachment 178648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178648&action=edit
Bug 10190: Add a vue app for circulation triggers

This patch adds a new vue based page for administering circulation
triggers.  This aims to replace the 'Overdue notice/status triggers'
page available from Tools.

The new page is available from Koha administration > Circulation triggers

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172634|0   |1
is obsolete||

--- Comment #136 from Martin Renvoize (ashimema) 
 ---
Created attachment 178646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178646&action=edit
Bug 10190: Fix unit test to exclude _X_ rules

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172635|0   |1
is obsolete||

--- Comment #137 from Martin Renvoize (ashimema) 
 ---
Created attachment 178647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178647&action=edit
Bug 10190: Add support for incrementable circulation rules

This patch adds support for _X_ grouped circulation rules to both the
internal and external API's for handling circulation rules.

This allows us to group overdue_X_rulename rules by an 'X' integer so we
can have triggers incremented and grouped together.

We also add the new overdue_x_* rule definition here for overdue trigger
rules.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172633|0   |1
is obsolete||

--- Comment #135 from Martin Renvoize (ashimema) 
 ---
Created attachment 178645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178645&action=edit
Bug 10190: Remove OverdueRule Koha Objects

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172632|0   |1
is obsolete||

--- Comment #134 from Martin Renvoize (ashimema) 
 ---
Created attachment 178644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178644&action=edit
Bug 10190: DBIC Schema update

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172631|0   |1
is obsolete||

--- Comment #133 from Martin Renvoize (ashimema) 
 ---
Created attachment 178643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178643&action=edit
Bug 10190: DB migration for overduerules

This patch adds the data migration for overduerules to circulation
rules.

We attempt to create the default rules based on most commonly occuring
rule values and then add overrides for all other rule values we find.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Michael Adamyk  changed:

   What|Removed |Added

 CC||michael.adamyk@bywatersolut
   ||ions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

he...@bywatersolutions.com changed:

   What|Removed |Added

 CC||he...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Lisette Scheer  changed:

   What|Removed |Added

 CC||lise...@bywatersolutions.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Michaela Sieber  changed:

   What|Removed |Added

 CC||michaela.sie...@kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

   Keywords||roadmap_24_11,
   ||roadmap_25_05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Matt Blenkinsop  changed:

   What|Removed |Added

 CC||matt.blenkinsop@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #132 from Martin Renvoize (ashimema) 
 ---
(In reply to Martin Renvoize (ashimema) from comment #65)
> Notes from Nick Clemens at KohaCon24
> * Use syspref for 'All libraries' or 'Logged in library' by default -
> DefaultToLoggedInLibraryOverdueTriggers

DONE

> * Note about whether we're talking aobut 'patrons home library' or 'items
> home library'

DONE

> * If a notice template is only set up for one library only display it in the
> notice dropdown when in that context

DONE

> * Can we expose somewhere the list of all notice trigger context
> combinations..

In a follow-up bug I reckon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172630|0   |1
is obsolete||

--- Comment #131 from Martin Renvoize (ashimema) 
 ---
Created attachment 172663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172663&action=edit
Bug 10190: Display value of OverdueNoticeFrom in note

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172626|0   |1
is obsolete||

--- Comment #130 from Martin Renvoize (ashimema) 
 ---
Created attachment 172662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172662&action=edit
Bug 10190: Only display default and library specific letters

This patch filters the list of letter templates available to use by only
those available for the context the rule is being added for (i.e. the
correct library relation)

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172625|0   |1
is obsolete||

--- Comment #129 from Martin Renvoize (ashimema) 
 ---
Created attachment 172661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172661&action=edit
Bug 10190: Take DefaultToLoggedInLibraryOverdueTriggers into account

This updates the logic for the default page load to take account of
DefaultToLoggedInLibraryOverdueTriggers.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172624|0   |1
is obsolete||

--- Comment #128 from Martin Renvoize (ashimema) 
 ---
Created attachment 172660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172660&action=edit
Bug 10190: Rename 'All *' to 'Default rule for *'

Try to clarify that the 'All' rules are actually fallback/default rules
for when there's not a more specific rule for the context.

We need to expose these clearly for each 'Library' view too which we're
not currently doing.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172623|0   |1
is obsolete||

--- Comment #127 from Martin Renvoize (ashimema) 
 ---
Created attachment 172659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172659&action=edit
Bug 10190: Rebase for rspack

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172622|0   |1
is obsolete||

--- Comment #126 from Martin Renvoize (ashimema) 
 ---
Created attachment 172658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172658&action=edit
Bug 10190: Update for bootstrap 5

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172621|0   |1
is obsolete||

--- Comment #125 from Martin Renvoize (ashimema) 
 ---
Created attachment 172657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172657&action=edit
Bug 10190: Clarify workflow

This patch re-arranges the edit/add modal form to clarify the
need to select context, then decide on editing an existing trigger or
adding a new one and then, and only then, exposes the actual rule inputs

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172619|0   |1
is obsolete||

--- Comment #124 from Martin Renvoize (ashimema) 
 ---
Created attachment 172656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172656&action=edit
Bug 10190: Add custom input for delay

This custom input allows for dynamic min/max rules and it updates the
input styling to match other inputs on the page including a 'clear'
button.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172617|0   |1
is obsolete||

--- Comment #123 from Martin Renvoize (ashimema) 
 ---
Created attachment 172655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172655&action=edit
Bug 10190: Modal form improvements

We now fetch all rules on modal open and the effective rule on context
selection.

This allows us to compare the specific values of the rule we're
adding/editing to the fallback values present in the all rules set.

We use the fallback rule values as placeholders in the input boxes to
highlight to the end user what value will be used should they choose to
wipe the input.  We also allow wiping inputs and pass 'null' to the API
appropriately.

Finally, we set a minimum value for delay when adding a new rule to
highlight to the user that the new trigger will be added after existing
triggers.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172614|0   |1
is obsolete||

--- Comment #122 from Martin Renvoize (ashimema) 
 ---
Created attachment 172654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172654&action=edit
Bug 10190: Restore 'edit' from 'Add/Edit' Modal

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172612|0   |1
is obsolete||

--- Comment #121 from Martin Renvoize (ashimema) 
 ---
Created attachment 172653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172653&action=edit
Bug 10190: Display effective values and highlight them

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172609|0   |1
is obsolete||

--- Comment #120 from Martin Renvoize (ashimema) 
 ---
Created attachment 172652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172652&action=edit
Bug 10190: Rework logic of overdue_notices

The original logic for digesting overdues in the overdue notices script
was flawed given the additional itemtype handling introduced in this
patchset and the way in which it handles effective fallbacks for rules.

This patch tidies the file and reworks the logic so that we fetch
overdues by patron category and branch and then iterate through those
comparing to the correct effective rules and combing them into digest
groups based on notice + trigger level.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172608|0   |1
is obsolete||

--- Comment #119 from Martin Renvoize (ashimema) 
 ---
Created attachment 172651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172651&action=edit
Bug 10190: Add comments to overdue_notices and rename variable

Trying to fully understand how this script operates.. this patch adds
some notes to the script for developers and also renames a variable that
I found was being re-used.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172607|0   |1
is obsolete||

--- Comment #118 from Martin Renvoize (ashimema) 
 ---
Created attachment 172650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172650&action=edit
Bug 10190: Update itiva script to reflect move to circ_rules

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172606|0   |1
is obsolete||

--- Comment #117 from Martin Renvoize (ashimema) 
 ---
Created attachment 172649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172649&action=edit
Bug 10190: Remove old overduerules interface

This patch updates the link from the tools homepage to open the new
circulation triggers administration page.

We then remove the old overduerules controller and template, and finally
we drop the no longer referenced
C4::Overdues::GetOverdueMessageTransportTypes method and associated unit
tests.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172605|0   |1
is obsolete||

--- Comment #116 from Martin Renvoize (ashimema) 
 ---
Created attachment 172648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172648&action=edit
Bug 10190: Migrate MarkIssueReturned test to circulation rules

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172604|0   |1
is obsolete||

--- Comment #115 from Martin Renvoize (ashimema) 
 ---
Created attachment 172647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172647&action=edit
Bug 10190: Add fallback to 'Default' text for notice

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172603|0   |1
is obsolete||

--- Comment #114 from Martin Renvoize (ashimema) 
 ---
Created attachment 172646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172646&action=edit
Bug 10190: Set tab based on trigger edited/created

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172602|0   |1
is obsolete||

--- Comment #113 from Martin Renvoize (ashimema) 
 ---
Created attachment 172645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172645&action=edit
Bug 10190: Add letter names to tables

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172601|0   |1
is obsolete||

--- Comment #112 from Martin Renvoize (ashimema) 
 ---
Created attachment 172644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172644&action=edit
Bug 10190: Update has_restricting_overdues to refer to circulation rules

This patch updates the Koha::Patron->has_restriction_overdues method to
refer to the migrated overdue rules.

We also correct an oversight in the method prior to this patch that
meant that not all overdues were being correctly checked for a
restriction.. we were incorrectly filtering to only overdues at the
current checkin branch.

Finally, we also take account of the itemtype level addition here too.

NOTE: There weren't any unit tests for this Koha::Patron method.. we
should add some here!

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172600|0   |1
is obsolete||

--- Comment #111 from Martin Renvoize (ashimema) 
 ---
Created attachment 172643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172643&action=edit
Bug 10190: Add itemtype handling to overdue_notices script

This patch enhances the overdue_notices script to understand the newly
introduced itemtype level for overdue rules.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172599|0   |1
is obsolete||

--- Comment #110 from Martin Renvoize (ashimema) 
 ---
Created attachment 172642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172642&action=edit
Bug 10190: Update overdue_notices script to refer to circ rules

This patch updates the overdue_notices cron script to refer to the new
location for overdue rules found in the circulation rules table now.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172597|0   |1
is obsolete||

--- Comment #108 from Martin Renvoize (ashimema) 
 ---
Created attachment 172640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172640&action=edit
Bug 10190: Let the circulation_rules endpoint accept query parameters

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172598|0   |1
is obsolete||

--- Comment #109 from Martin Renvoize (ashimema) 
 ---
Created attachment 172641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172641&action=edit
Bug 10190: Update GetBranchcodesWithOverdueRules to use CirculationRules

This patch updates the C4::Overdues method
GetBranchecodesWithOverdueRules to refer to the new location of these
rules in the circulation rules table. We also update the unit tests to
move the mocked data into the right location.

We could perhaps migrate this method in Koha::CirculationRules at a
later date?

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172596|0   |1
is obsolete||

--- Comment #107 from Martin Renvoize (ashimema) 
 ---
Created attachment 172639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172639&action=edit
Bug 10190: Add itemtypes and patron categories to the item/patron api clients

This patch adds patron and itemtype api clients for the Vue ecosystem

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172595|0   |1
is obsolete||

--- Comment #106 from Martin Renvoize (ashimema) 
 ---
Created attachment 172638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172638&action=edit
Bug 10190: Add a library API client

This patch adds a library api client to the vue ecosystem for later use
in the Circulation triggers page.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172594|0   |1
is obsolete||

--- Comment #105 from Martin Renvoize (ashimema) 
 ---
Created attachment 172637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172637&action=edit
Bug 10190: Add components to list/add and edit circulation triggers

These new components are used by the new 'Circulation triggers'
administration page to display existing trigger rules and add the
ability to add new rules and edit existing ones.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172593|0   |1
is obsolete||

--- Comment #104 from Martin Renvoize (ashimema) 
 ---
Created attachment 172636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172636&action=edit
Bug 10190: Add a vue app for circulation triggers

This patch adds a new vue based page for administering circulation
triggers.  This aims to replace the 'Overdue notice/status triggers'
page available from Tools.

The new page is available from Koha administration > Circulation triggers

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172592|0   |1
is obsolete||

--- Comment #103 from Martin Renvoize (ashimema) 
 ---
Created attachment 172635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172635&action=edit
Bug 10190: Add support for incrementable circulation rules

This patch adds support for _X_ grouped circulation rules to both the
internal and external API's for handling circulation rules.

This allows us to group overdue_X_rulename rules by an 'X' integer so we
can have triggers incremented and grouped together.

We also add the new overdue_x_* rule definition here for overdue trigger
rules.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172591|0   |1
is obsolete||

--- Comment #102 from Martin Renvoize (ashimema) 
 ---
Created attachment 172634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172634&action=edit
Bug 10190: Fix unit test to exclude _X_ rules

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172590|0   |1
is obsolete||

--- Comment #101 from Martin Renvoize (ashimema) 
 ---
Created attachment 172633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172633&action=edit
Bug 10190: Remove OverdueRule Koha Objects

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172589|0   |1
is obsolete||

--- Comment #100 from Martin Renvoize (ashimema) 
 ---
Created attachment 172632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172632&action=edit
Bug 10190: DBIC Schema update

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172588|0   |1
is obsolete||

--- Comment #99 from Martin Renvoize (ashimema) 
 ---
Created attachment 172631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172631&action=edit
Bug 10190: DB migration for overduerules

This patch adds the data migration for overduerules to circulation
rules.

We attempt to create the default rules based on most commonly occuring
rule values and then add overrides for all other rule values we find.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #98 from Martin Renvoize (ashimema) 
 ---
Created attachment 172630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172630&action=edit
Bug 10190: Display value of OverdueNoticeFrom in note

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #97 from Martin Renvoize (ashimema) 
 ---
Created attachment 172626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172626&action=edit
Bug 10190: Only display default and library specific letters

This patch filters the list of letter templates available to use by only
those available for the context the rule is being added for (i.e. the
correct library relation)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #96 from Martin Renvoize (ashimema) 
 ---
Created attachment 172625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172625&action=edit
Bug 10190: Take DefaultToLoggedInLibraryOverdueTriggers into account

This updates the logic for the default page load to take account of
DefaultToLoggedInLibraryOverdueTriggers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #95 from Martin Renvoize (ashimema) 
 ---
Created attachment 172624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172624&action=edit
Bug 10190: Rename 'All *' to 'Default rule for *'

Try to clarify that the 'All' rules are actually fallback/default rules
for when there's not a more specific rule for the context.

We need to expose these clearly for each 'Library' view too which we're
not currently doing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #171755|0   |1
is obsolete||

--- Comment #94 from Martin Renvoize (ashimema) 
 ---
Created attachment 172623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172623&action=edit
Bug 10190: Rebase for rspack

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #171754|0   |1
is obsolete||

--- Comment #93 from Martin Renvoize (ashimema) 
 ---
Created attachment 172622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172622&action=edit
Bug 10190: Update for bootstrap 5

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #171753|0   |1
is obsolete||

--- Comment #92 from Martin Renvoize (ashimema) 
 ---
Created attachment 172621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172621&action=edit
Bug 10190: Clarify workflow

This patch re-arranges the edit/add modal form to clarify the
need to select context, then decide on editing an existing trigger or
adding a new one and then, and only then, exposes the actual rule inputs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #171752|0   |1
is obsolete||

--- Comment #91 from Martin Renvoize (ashimema) 
 ---
Created attachment 172619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172619&action=edit
Bug 10190: Add custom input for delay

This custom input allows for dynamic min/max rules and it updates the
input styling to match other inputs on the page including a 'clear'
button.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #171751|0   |1
is obsolete||

--- Comment #90 from Martin Renvoize (ashimema) 
 ---
Created attachment 172617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172617&action=edit
Bug 10190: Modal form improvements

We now fetch all rules on modal open and the effective rule on context
selection.

This allows us to compare the specific values of the rule we're
adding/editing to the fallback values present in the all rules set.

We use the fallback rule values as placeholders in the input boxes to
highlight to the end user what value will be used should they choose to
wipe the input.  We also allow wiping inputs and pass 'null' to the API
appropriately.

Finally, we set a minimum value for delay when adding a new rule to
highlight to the user that the new trigger will be added after existing
triggers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/