subject:"\[Koha\-bugs\] \[Bug 10190\] Overdue notice triggers based on item type"

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-12-12 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #204 from Jonathan Druart  ---
In the last patch:
-min;
+`${min}`;

Why this kind of changes exactly?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-11-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-11-26 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 CC||[email protected]
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=41315

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-11-21 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Chloé Zermatten  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-11-21 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Chloé Zermatten  changed:

   What|Removed |Added

 Attachment #189345|0   |1
is obsolete||

--- Comment #203 from Chloé Zermatten  ---
Created attachment 189868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189868&action=edit
Bug 10190: (follow-up) Complete Vue.js rewrite of Circulation Triggers
administration interface

This patch aims to resolve the following issues as reported by comment 193:

- missing atomic update for overde_X_has_rules:
- existing delays being overwritten by the client when a rule set is displayed
- inability to save circulation overdue rule sets for context for which
circulations rules where already set

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-11-21 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Chloé Zermatten  changed:

   What|Removed |Added

 Attachment #188088|0   |1
is obsolete||

--- Comment #202 from Chloé Zermatten  ---
Created attachment 189867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189867&action=edit
Bug 10190: Comprehensive Cypress tests for Circulation Triggers UI

This patch significantly enhances the Cypress test coverage for the new
Circulation Triggers administration interface, expanding from basic
breadcrumb checks to comprehensive end-to-end testing.

Test Coverage:
- Initial page load and API error handling
- Context filtering (library, patron category, item type)
- View toggling between explicit and all applicable rules
- Tab navigation between multiple triggers
- Full CRUD operations (Create, Read, Update, Delete)
- Rule set reset functionality
- Letter template filtering by library context
- Form validation and constraint checking
- Loading states and empty states
- Error handling for all operations
- Browser navigation (back/forward buttons)
- Complex scenarios with inheritance hierarchies

New Features:
- Mock data helper functions for test fixtures
- Comprehensive API interception for all endpoints
- Tests for both success and error paths
- Placeholder value testing for fallback rules
- Increment/decrement button testing
- Multi-step form workflow validation
- Confirmation dialog testing for destructive operations

The tests follow Koha's Cypress testing patterns established in the
ERM module, using proper API mocking, clear test descriptions, and
organized test suites.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-11-21 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Chloé Zermatten  changed:

   What|Removed |Added

 Attachment #188087|0   |1
is obsolete||

--- Comment #201 from Chloé Zermatten  ---
Created attachment 189866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189866&action=edit
Bug 10190: Update itiva script to reflect move to circ_rules

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-11-21 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Chloé Zermatten  changed:

   What|Removed |Added

 Attachment #188086|0   |1
is obsolete||

--- Comment #200 from Chloé Zermatten  ---
Created attachment 189865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189865&action=edit
Bug 10190: Remove old overduerules interface

This patch updates the link from the tools homepage to open the new
circulation triggers administration page.

We then remove the old overduerules controller and template, and finally
we drop the no longer referenced
C4::Overdues::GetOverdueMessageTransportTypes method and associated unit
tests.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-11-21 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Chloé Zermatten  changed:

   What|Removed |Added

 Attachment #188085|0   |1
is obsolete||

--- Comment #199 from Chloé Zermatten  ---
Created attachment 189864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189864&action=edit
Bug 10190: Migrate MarkIssueReturned test to circulation rules

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-11-21 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Chloé Zermatten  changed:

   What|Removed |Added

 Attachment #188084|0   |1
is obsolete||

--- Comment #198 from Chloé Zermatten  ---
Created attachment 189863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189863&action=edit
Bug 10190: Update has_restricting_overdues to refer to circulation rules

This patch updates the Koha::Patron->has_restriction_overdues method to
refer to the migrated overdue rules.

We also correct an oversight in the method prior to this patch that
meant that not all overdues were being correctly checked for a
restriction.. we were incorrectly filtering to only overdues at the
current checkin branch.

Finally, we also take account of the itemtype level addition here too.

NOTE: There weren't any unit tests for this Koha::Patron method.. we
should add some here!

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-11-10 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-11-09 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Clemens Tubach  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #197 from Clemens Tubach  ---
Unfortunately, the patch doesn't apply:

Applying: Bug 10190: Update has_restricting_overdues to refer to circulation
rules
Using index info to reconstruct a base tree...
M   Koha/Patron.pm
Falling back to patching base and 3-way merge...
Auto-merging Koha/Patron.pm
CONFLICT (content): Merge conflict in Koha/Patron.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 10190: Update has_restricting_overdues to refer to
circulation rules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-11-07 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Chloé Zermatten  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #196 from Chloé Zermatten  ---
(In reply to Chloé Zermatten from comment #194)
> (In reply to Michaela Sieber from comment #193)
> > We tested several hours and I will provide more feedback this week but here
> > are the most relevant Bugs we found:
> > 
> > 1.) Migration scenario
> > 
> > have some overdue rule, then apply the patch and do updatabase and yarn buid
> > 
> > Error 404 in staff interface 
> > 
> > Please see Pedros comment 192 
> > 
> > In your testplan in comment 183 you write in
> > 
> > Part 11: Data Integrity & Persistence
> > 5. Check the database circulation_rules table:
> >  - Verify the overdue_X_has_rules rule kind is present
> > 
> > Is this the missing piece for the migrated data ?
> > 
> > 
> > 2.) Adding a trigger for a combination that exists in circ rules
> > 
> > it is not possible to configure an overdue trigger with a combination that
> > already exists as a circulation rule.
> > 
> > Example to reproduce in ktd with test data:
> > 
> > - Go to circ rules (/cgi-bin/koha/admin/smart-rules.pl) 
> >  - Set a rule for All Libraries / All patron categories / Itemtype Books
> >  - Check via SQL: select * from circulation_rules
> > - Go to overdue rules (/cgi-bin/koha/admin/circulation_triggers )
> >  - Set a rule for All Libraries / All patron categories / All Itemtype
> >  - Now try to edit the delay for the applied rule 
> >with combination All Libraries / All patron categories / Itemtype Books
> >--> Message in blue box "Your changes could not be saved as this
> > circulation
> >trigger was updated elsewhere. Please see the updated trigger below."
> >It is not possible to save / submit
> >  - Now edit the delay for the applied rule 
> >with combination All Libraries / Patron category Homebound / Itemtype
> > Books
> >--> You can save without problems, if this combination does not exist in
> > the database table circulation_rules
> > 
> > 
> > 3.) Permissions Error if you are not an admin
> > 
> > The Overlay rules are part of the tools and also the permission is part of
> > the tools section. That means that it was enough to give users the
> > edit_notice_status_triggers permission, it was not neccessary to give any
> > administration permission (parameters) .
> > Now you moved the overdue triggers to administration.
> > 
> > If you now log in as a person with edit_notice_status_triggers permission
> > you can see the tools module and click on the menu for overdue triggers but
> > then you get the error message "Something went wrong: Error: Authorization
> > failure. Missing required permission(s)."
> > 
> > 
> > 4.) Edit an existing trigger does not pull delay from database
> > 
> > Edit an existing trigger and check that the delay value is 0 , it is not
> > pulled from the database. This is confusing and dangerous because you see
> > the delay value just a few centimeters above in the table.
> > If you save the form, the value in the database is overwritten with 0.
> > 
> > To reproduce: follow testplan in comment 183 Part 4.3
> 
> Thank you for the testing and feedback, much appreciated!
> 
> 
> Re - 1.) overdue_X_has_rules is a property indicating that some rule(s)
> exist for a given context/trigger number combination. The most recent
> version of the integration ensure it is created whenever any rule is created
> for a given context/trigger number combination. The staff clients relies on
> this to ascertain whether a rule set exists efficiently.
> I think the solution might be to have it added to each existing
> context/trigger number combination - would that be sensible?
> 
> 2., 3., and 4.: I will do some debugging and put patches together for those,
> many thanks for reporting them!

Quick update on this: The latest commit (Attachment #189345) intends to address
point 1, 2, and 4 from the QA feedback. 3 is, to my knowledge, one for
discussion as it looks to me like expected behaviour.

In the meantime, if any other bugs are found, I'll be happy to look at
addressing them!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-11-07 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #195 from Chloé Zermatten  ---
Created attachment 189345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189345&action=edit
Bug 10190: (follow-up) Complete Vue.js rewrite of Circulation Triggers
administration interface

This patch aims to resolve the following issues as reported by comment 193:

- missing atomic update for overde_X_has_rules:
- existing delays being overwritten by the client when a rule set is displayed
- inability to save circulation overdue rule sets for context for which
circulations rules where already set

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-11-05 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #194 from Chloé Zermatten  ---
(In reply to Michaela Sieber from comment #193)
> We tested several hours and I will provide more feedback this week but here
> are the most relevant Bugs we found:
> 
> 1.) Migration scenario
> 
> have some overdue rule, then apply the patch and do updatabase and yarn buid
> 
> Error 404 in staff interface 
> 
> Please see Pedros comment 192 
> 
> In your testplan in comment 183 you write in
> 
> Part 11: Data Integrity & Persistence
> 5. Check the database circulation_rules table:
>  - Verify the overdue_X_has_rules rule kind is present
> 
> Is this the missing piece for the migrated data ?
> 
> 
> 2.) Adding a trigger for a combination that exists in circ rules
> 
> it is not possible to configure an overdue trigger with a combination that
> already exists as a circulation rule.
> 
> Example to reproduce in ktd with test data:
> 
> - Go to circ rules (/cgi-bin/koha/admin/smart-rules.pl) 
>  - Set a rule for All Libraries / All patron categories / Itemtype Books
>  - Check via SQL: select * from circulation_rules
> - Go to overdue rules (/cgi-bin/koha/admin/circulation_triggers )
>  - Set a rule for All Libraries / All patron categories / All Itemtype
>  - Now try to edit the delay for the applied rule 
>with combination All Libraries / All patron categories / Itemtype Books
>--> Message in blue box "Your changes could not be saved as this
> circulation
>trigger was updated elsewhere. Please see the updated trigger below."
>It is not possible to save / submit
>  - Now edit the delay for the applied rule 
>with combination All Libraries / Patron category Homebound / Itemtype
> Books
>--> You can save without problems, if this combination does not exist in
> the database table circulation_rules
> 
> 
> 3.) Permissions Error if you are not an admin
> 
> The Overlay rules are part of the tools and also the permission is part of
> the tools section. That means that it was enough to give users the
> edit_notice_status_triggers permission, it was not neccessary to give any
> administration permission (parameters) .
> Now you moved the overdue triggers to administration.
> 
> If you now log in as a person with edit_notice_status_triggers permission
> you can see the tools module and click on the menu for overdue triggers but
> then you get the error message "Something went wrong: Error: Authorization
> failure. Missing required permission(s)."
> 
> 
> 4.) Edit an existing trigger does not pull delay from database
> 
> Edit an existing trigger and check that the delay value is 0 , it is not
> pulled from the database. This is confusing and dangerous because you see
> the delay value just a few centimeters above in the table.
> If you save the form, the value in the database is overwritten with 0.
> 
> To reproduce: follow testplan in comment 183 Part 4.3

Thank you for the testing and feedback, much appreciated!


Re - 1.) overdue_X_has_rules is a property indicating that some rule(s) exist
for a given context/trigger number combination. The most recent version of the
integration ensure it is created whenever any rule is created for a given
context/trigger number combination. The staff clients relies on this to
ascertain whether a rule set exists efficiently.
I think the solution might be to have it added to each existing context/trigger
number combination - would that be sensible?

2., 3., and 4.: I will do some debugging and put patches together for those,
many thanks for reporting them!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-28 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Michaela Sieber  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #193 from Michaela Sieber  ---
We tested several hours and I will provide more feedback this week but here are
the most relevant Bugs we found:

1.) Migration scenario

have some overdue rule, then apply the patch and do updatabase and yarn buid

Error 404 in staff interface 

Please see Pedros comment 192 

In your testplan in comment 183 you write in

Part 11: Data Integrity & Persistence
5. Check the database circulation_rules table:
 - Verify the overdue_X_has_rules rule kind is present

Is this the missing piece for the migrated data ?


2.) Adding a trigger for a combination that exists in circ rules

it is not possible to configure an overdue trigger with a combination that
already exists as a circulation rule.

Example to reproduce in ktd with test data:

- Go to circ rules (/cgi-bin/koha/admin/smart-rules.pl) 
 - Set a rule for All Libraries / All patron categories / Itemtype Books
 - Check via SQL: select * from circulation_rules
- Go to overdue rules (/cgi-bin/koha/admin/circulation_triggers )
 - Set a rule for All Libraries / All patron categories / All Itemtype
 - Now try to edit the delay for the applied rule 
   with combination All Libraries / All patron categories / Itemtype Books
   --> Message in blue box "Your changes could not be saved as this circulation
   trigger was updated elsewhere. Please see the updated trigger below."
   It is not possible to save / submit
 - Now edit the delay for the applied rule 
   with combination All Libraries / Patron category Homebound / Itemtype Books
   --> You can save without problems, if this combination does not exist in the
database table circulation_rules


3.) Permissions Error if you are not an admin

The Overlay rules are part of the tools and also the permission is part of the
tools section. That means that it was enough to give users the
edit_notice_status_triggers permission, it was not neccessary to give any
administration permission (parameters) .
Now you moved the overdue triggers to administration.

If you now log in as a person with edit_notice_status_triggers permission you
can see the tools module and click on the menu for overdue triggers but then
you get the error message "Something went wrong: Error: Authorization failure.
Missing required permission(s)."


4.) Edit an existing trigger does not pull delay from database

Edit an existing trigger and check that the delay value is 0 , it is not pulled
from the database. This is confusing and dangerous because you see the delay
value just a few centimeters above in the table.
If you save the form, the value in the database is overwritten with 0.

To reproduce: follow testplan in comment 183 Part 4.3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #192 from Pedro Amorim  ---
To have it working on a upgrade, I had to run the following:
Apply patches
$ updatabase
$ yarn js:build
$ sudo perl /kohadevbox/misc4dev/cp_debian_files.pl --instance=kohadev
--koha_dir=/kohadevbox/koha --gitify_dir=/kohadevbox/gitify
$ restart_all

The cp_debian_files.pl is required or else the URL always returns 404:
http://localhost:8081/cgi-bin/koha/admin/circulation_triggers

I believe this is why applying patches and doing reset_all, but applying
patches and doing restart_all does not, it's missing the cp_debian_files part,
which I believe copies debian/templates/apache-shared-intranet.conf‎ among
other files.

It is now producing a JavaScript error on the console though, which may or may
not highlight an issue with the data migration script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #191 from Pedro Amorim  ---
(In reply to Pedro Amorim from comment #190)
> Created attachment 188476 [details] [review]
> Bug 10190: (QA follow-up): Fix removal of tables

This fixes the database error but does not address the undef warnings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #190 from Pedro Amorim  ---
Created attachment 188476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188476&action=edit
Bug 10190: (QA follow-up): Fix removal of tables

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Pedro Amorim  changed:

   What|Removed |Added

 CC||[email protected]
   ||k
 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-27 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Michaela Sieber  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #189 from Michaela Sieber  ---
As  Victor Grousset/tuxayo wrote  in Comment 167 (2025-02-26) 

updatedatabase doesn't work:
(have a koha on main, apply the patches and update)

$ updatedatabase

Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $itemtype in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 229.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 240.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 251.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $itemtype in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 229.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 240.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 251.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $itemtype in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 229.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 240.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 251.
DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl [08:57:11]: Bug
10190 - Migrate overduerules to circulation_rules
Inserting :undef: default most frequent delay for overdue_1:
Inserting :undef:undef default most frequent notice for overdue_1:
Inserting :undef:undef default most frequent mtt for overdue_1:
Inserting :undef:undef default most frequent restrict for overdue_1: 0
Inserting :undef: default most frequent delay for overdue_2:
Inserting :undef:undef default most frequent notice for overdue_2:
Inserting :undef:undef default most frequent mtt for overdue_2:
Inserting :undef:undef default most frequent restrict for overdue_2: 0
Inserting :undef: default most frequent delay for overdue_3:
Inserting :undef:undef default most frequent notice for overdue_3:
Inserting :undef:undef default most frequent mtt for overdue_3:
Inserting :undef:undef default most frequent restrict for overdue_3: 0

ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot delete or
update a parent row: a foreign key constraint fails at
/kohadevbox/koha/C4/Installer.pm line 825

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #188 from Martin Renvoize (ashimema) 
 ---
Created attachment 188088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188088&action=edit
Bug 10190: Comprehensive Cypress tests for Circulation Triggers UI

This patch significantly enhances the Cypress test coverage for the new
Circulation Triggers administration interface, expanding from basic
breadcrumb checks to comprehensive end-to-end testing.

Test Coverage:
- Initial page load and API error handling
- Context filtering (library, patron category, item type)
- View toggling between explicit and all applicable rules
- Tab navigation between multiple triggers
- Full CRUD operations (Create, Read, Update, Delete)
- Rule set reset functionality
- Letter template filtering by library context
- Form validation and constraint checking
- Loading states and empty states
- Error handling for all operations
- Browser navigation (back/forward buttons)
- Complex scenarios with inheritance hierarchies

New Features:
- Mock data helper functions for test fixtures
- Comprehensive API interception for all endpoints
- Tests for both success and error paths
- Placeholder value testing for fallback rules
- Increment/decrement button testing
- Multi-step form workflow validation
- Confirmation dialog testing for destructive operations

The tests follow Koha's Cypress testing patterns established in the
ERM module, using proper API mocking, clear test descriptions, and
organized test suites.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

   Assignee|[email protected] |[email protected]
   |o.uk|o.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #183 from Martin Renvoize (ashimema) 
 ---
Created attachment 188083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188083&action=edit
Bug 10190: Complete Vue.js rewrite of Circulation Triggers administration
interface

This patch introduces a modern Vue.js-based interface for managing circulation
triggers (overdue notice/status triggers), replacing the legacy Tools-based
interface with a more intuitive, feature-rich administration page.

New Features

Enhanced Visibility & Navigation
- Exhaustive effective rule lists showing all rules that apply to each context
- Toggle between "all exhaustive rules" and "explicitly set rules" views
- Advanced filtering by patron category and/or item type
- Clear display of fallback/default rules for each context

Rule Management Actions
- Delete triggers (last trigger in a sequence for any given library)
- Reset entire rule sets for a given context (with safeguards)
- Edit existing triggers with improved context awareness
- Add new triggers with intelligent delay constraints

Improved User Experience
- Multi-step form wizard with clear workflow progression
- Context-aware letter template filtering (only shows applicable templates)
- Placeholder values showing fallback rules when clearing inputs
- Dynamic min/max constraints for delay values based on neighboring triggers
- Real-time form validation and feedback
- Partial page reloads (only reload affected sections, not entire page)
- Specific loading messages for different operations

Technical Improvements
- Centralized Vuex store for state management
- Reusable CirculationTriggersForm component
- API clients for libraries, circulation rules, item types, and patron
categories
- Consistent async/await pattern throughout
- Separation of repositories, utilities, and services
- Improved naming consistency and code maintainability
- "Dumb" TriggersTable component for better separation of concerns

Test Plan

Prerequisites
1. Log in to staff interface with appropriate permissions
(tools_edit_notice_status_triggers)
2. Ensure you have test data: multiple libraries, patron categories, item
types, and notice templates
3. Navigate to Administration > Circulation triggers (new interface)

Part 1: Basic Navigation & Interface
1. Verify the new "Circulation triggers" link appears in Administration home
under the Circulation section
2. Access the new interface and confirm it loads successfully
3. Verify the default view shows either "All libraries" or your logged-in
library based on DefaultToLoggedInLibraryOverdueTriggers system preference
4. Confirm the interface displays a list of triggers organized by context
(library/patron category/item type combinations)

Part 2: Viewing and Filtering Rules
1. Toggle between "All exhaustive rules" and "Explicitly set rules" views
  - Verify "All exhaustive rules" shows inherited/fallback rules
  - Verify "Explicitly set rules" shows only rules you've specifically
configured
2. Test the patron category filter:
  - Select a specific patron category
  - Confirm only rules for that category are displayed
3. Test the item type filter:
  - Select a specific item type
  - Confirm only rules for that item type are displayed
4. Test combined filters (patron category + item type simultaneously)
5. Clear filters and verify all rules display again

Part 3: Adding New Triggers
1. Click "Add trigger" button
2. Step 1 - Confirm Context:
  - Select Library (required)
  - Select Patron category (required)
  - Select Item type (required)
  - Click "Confirm context"
3. Step 2 - Review Existing Triggers:
  - Verify existing triggers for this context are displayed
  - Note the trigger numbers and delays
4. Step 3 - Configure New Trigger:
  - Enter a delay value (should be constrained by neighboring triggers)
  - Try entering an invalid delay (too low or too high) - verify validation
  - Set "Restricts checkouts" (Yes/No/Fallback to default)
  - Note the placeholder showing the fallback value
  - Select a letter template
  - Verify only templates for the selected library context appear
  - Set "Debarring" options if desired
  - Select "Charged notice fees" if applicable
5. Submit the form
6. Verify the new trigger appears in the list without a full page reload
7. Verify success message is displayed

Part 4: Editing Existing Triggers
1. Locate an existing trigger in the list
2. Click the edit icon/button
3. Verify the form pre-populates with existing values
4. Test delay modification:
  - Try changing the delay within valid bounds - should succeed
  - Try changing delay beyond neighboring triggers - should show validation
error
  - Use the increment/decrement buttons to adjust delay
5. Test clearing values:
  - Clear a field (e.g., delay or restrict checkouts)
  - Verify placeholder shows the fallback/default value
  - Submit with cleared value - should save as null and inherit fallback
6. Change the letter template to a di

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

GIT URL|https://github.com/openfift |https://github.com/openfift
   |h/koha/tree/bug_10190_submi |h/koha/tree/bug_10190_submi
   |ssion-rebased   |ssion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #182 from Martin Renvoize (ashimema) 
 ---
Created attachment 188082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188082&action=edit
Bug 10190: Let the circulation_rules endpoint accept query parameters

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #181 from Martin Renvoize (ashimema) 
 ---
Created attachment 188081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188081&action=edit
Bug 10190: Rework logic of overdue_notices

This patch enhances the overdue_notices script to understand the newly
introduced itemtype level for overdue rules.

The original logic for digesting overdues in the overdue notices script
was flawed given the additional itemtype handling introduced in this
patchset and the way in which it handles effective fallbacks for rules.

This patch tidies the file and reworks the logic so that we fetch
overdues by patron category and branch and then iterate through those
comparing to the correct effective rules and combing them into digest
groups based on notice + trigger level.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

   Keywords||roadmap_25_11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #186 from Martin Renvoize (ashimema) 
 ---
Created attachment 188086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188086&action=edit
Bug 10190: Remove old overduerules interface

This patch updates the link from the tools homepage to open the new
circulation triggers administration page.

We then remove the old overduerules controller and template, and finally
we drop the no longer referenced
C4::Overdues::GetOverdueMessageTransportTypes method and associated unit
tests.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #187 from Martin Renvoize (ashimema) 
 ---
Created attachment 188087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188087&action=edit
Bug 10190: Update itiva script to reflect move to circ_rules

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #185 from Martin Renvoize (ashimema) 
 ---
Created attachment 188085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188085&action=edit
Bug 10190: Migrate MarkIssueReturned test to circulation rules

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #184 from Martin Renvoize (ashimema) 
 ---
Created attachment 188084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188084&action=edit
Bug 10190: Update has_restricting_overdues to refer to circulation rules

This patch updates the Koha::Patron->has_restriction_overdues method to
refer to the migrated overdue rules.

We also correct an oversight in the method prior to this patch that
meant that not all overdues were being correctly checked for a
restriction.. we were incorrectly filtering to only overdues at the
current checkin branch.

Finally, we also take account of the itemtype level addition here too.

NOTE: There weren't any unit tests for this Koha::Patron method.. we
should add some here!

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #179 from Martin Renvoize (ashimema) 
 ---
Created attachment 188079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188079&action=edit
Bug 10190: Add support for incrementable circulation rules

This patch adds support for _X_ grouped circulation rules to both the
internal and external API's for handling circulation rules.

This allows us to group overdue_X_rulename rules by an 'X' integer so we
can have triggers incremented and grouped together.

We also add the new overdue_x_* rule definition here for overdue trigger
rules.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #180 from Martin Renvoize (ashimema) 
 ---
Created attachment 188080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188080&action=edit
Bug 10190: Update GetBranchcodesWithOverdueRules to use CirculationRules

This patch updates the C4::Overdues method
GetBranchecodesWithOverdueRules to refer to the new location of these
rules in the circulation rules table. We also update the unit tests to
move the mocked data into the right location.

We could perhaps migrate this method in Koha::CirculationRules at a
later date?

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #176 from Martin Renvoize (ashimema) 
 ---
Created attachment 188076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188076&action=edit
Bug 10190: DBIC Schema update

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #178 from Martin Renvoize (ashimema) 
 ---
Created attachment 188078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188078&action=edit
Bug 10190: Fix unit test to exclude _X_ rules

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #177 from Martin Renvoize (ashimema) 
 ---
Created attachment 188077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188077&action=edit
Bug 10190: Remove OverdueRule Koha Objects

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-10-17 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #178643|0   |1
is obsolete||
 Attachment #178644|0   |1
is obsolete||
 Attachment #178645|0   |1
is obsolete||
 Attachment #178646|0   |1
is obsolete||
 Attachment #178647|0   |1
is obsolete||
 Attachment #178648|0   |1
is obsolete||
 Attachment #178649|0   |1
is obsolete||
 Attachment #178650|0   |1
is obsolete||
 Attachment #178651|0   |1
is obsolete||
 Attachment #178652|0   |1
is obsolete||
 Attachment #178653|0   |1
is obsolete||
 Attachment #178654|0   |1
is obsolete||
 Attachment #178655|0   |1
is obsolete||
 Attachment #178656|0   |1
is obsolete||
 Attachment #178657|0   |1
is obsolete||
 Attachment #178658|0   |1
is obsolete||
 Attachment #178659|0   |1
is obsolete||
 Attachment #178660|0   |1
is obsolete||
 Attachment #178661|0   |1
is obsolete||
 Attachment #178662|0   |1
is obsolete||
 Attachment #178663|0   |1
is obsolete||
 Attachment #178664|0   |1
is obsolete||
 Attachment #178665|0   |1
is obsolete||
 Attachment #178666|0   |1
is obsolete||
 Attachment #178667|0   |1
is obsolete||
 Attachment #178668|0   |1
is obsolete||
 Attachment #178669|0   |1
is obsolete||
 Attachment #178670|0   |1
is obsolete||
 Attachment #178671|0   |1
is obsolete||
 Attachment #178672|0   |1
is obsolete||
 Attachment #178673|0   |1
is obsolete||
 Attachment #178674|0   |1
is obsolete||
 Attachment #178675|0   |1
is obsolete||

--- Comment #175 from Martin Renvoize (ashimema) 
 ---
Created attachment 188075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188075&action=edit
Bug 10190: DB migration for overduerules

This patch adds the data migration for overduerules to circulation
rules.

We attempt to create the default rules based on most commonly occuring
rule values and then add overrides for all other rule values we find.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-09-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #174 from Martin Renvoize (ashimema) 
 ---
We've been reworking this considerably, given live use feedback.  Chloe's taken
over the reins, so I'm updating the assignee, but the reality is Chloe, Matt,
and I have all done a lot of work between us on this one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-08-29 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190
Bug 10190 depends on bug 37256, which changed state.

Bug 37256 Summary: Add an endpoint to allow setting circulation rule sets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37256

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-08-12 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Chloé Zermatten  changed:

   What|Removed |Added

 Blocks||39756


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39756
[Bug 39756] Long overdue cron configuration page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-07-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Kate Wenger  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-06-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-05-30 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190
Bug 10190 depends on bug 36641, which changed state.

Bug 36641 Summary: Add an endpoint to list circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36641

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-05-01 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

GIT URL||https://github.com/openfift
   ||h/koha/tree/bug_10190_submi
   ||ssion-rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-05-01 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #173 from Martin Renvoize (ashimema) 
 ---
Koha's been moving so fast.. probably best to use the public branch for this:
https://github.com/openfifth/koha/tree/bug_10190_submission-rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-04-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #172 from Caroline Cyr La Rose  
---
I wanted to see what it looked like, but unfortunately, the patch doesn't apply
anymore...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-04-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||francois.charbonnier@inlibr
   ||o.com

--- Comment #171 from Caroline Cyr La Rose  
---
*** Bug 12772 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-04-03 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Marion Durand  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-03-20 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

   Keywords||Hackfest

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-03-05 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Michaela Sieber  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-03-03 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #170 from Martin Renvoize (ashimema) 
 ---
(In reply to Victor Grousset/tuxayo from comment #169)
> Comment on attachment 178648 [details] [review]
> Bug 10190: Add a vue app for circulation triggers
> 
> Review of attachment 178648 [details] [review]:
> -
> 
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/circulation_triggers.tt
> @@ +25,5 @@
> > +
> > +
> > +[% MACRO jsinclude BLOCK %]
> > +[% INCLUDE 'calendar.inc' %]
> > +
> 
> Is the FIXME for calendar.inc above or datatables.inc bellow or the 4
> includes below?

It was for calendar.inc and if you look at the other vue apps, it's consistent
throughout them so far.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-26 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #169 from Victor Grousset/tuxayo  ---
Comment on attachment 178648
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178648
Bug 10190: Add a vue app for circulation triggers

Review of attachment 178648:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10190&attachment=178648)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/circulation_triggers.tt
@@ +25,5 @@
> +
> +
> +[% MACRO jsinclude BLOCK %]
> +[% INCLUDE 'calendar.inc' %]
> +

Is the FIXME for calendar.inc above or datatables.inc bellow or the 4 includes
below?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-26 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||[email protected]
 Status|Signed Off  |Failed QA

--- Comment #167 from Victor Grousset/tuxayo  ---
updatedatabase doesn't work:
(have a koha on main, apply the patches and update)

$ updatedatabase
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $itemtype in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 229.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 240.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 251.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $itemtype in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 229.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 240.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 251.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $itemtype in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 218.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 229.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 240.
Use of uninitialized value $branchcode_value in concatenation (.) or string at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl line 251.
DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_10190.pl  [23:24:08]:
Bug 10190 - Migrate overduerules to circulation_rules
Inserting :undef: default most frequent delay for overdue_1:
Inserting :undef:undef default most frequent notice for overdue_1:
Inserting :undef:undef default most frequent mtt for overdue_1:
Inserting :undef:undef default most frequent restrict for overdue_1: 0
Inserting :undef: default most frequent delay for overdue_2:
Inserting :undef:undef default most frequent notice for overdue_2:
Inserting :undef:undef default most frequent mtt for overdue_2:
Inserting :undef:undef default most frequent restrict for overdue_2: 0
Inserting :undef: default most frequent delay for overdue_3:
Inserting :undef:undef default most frequent notice for overdue_3:
Inserting :undef:undef default most frequent mtt for overdue_3:
Inserting :undef:undef default most frequent restrict for overdue_3: 0
ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot
delete or update a parent row: a foreign key constraint fails at
/kohadevbox/koha/C4/Installer.pm line 771

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-26 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #168 from Victor Grousset/tuxayo  ---
MariaDB 10.5.26 in case that matters.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-26 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #166 from Victor Grousset/tuxayo  ---
Comment on attachment 178644
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178644
Bug 10190: DBIC Schema update

Review of attachment 178644:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10190&attachment=178644)
-

::: Koha/Schema/Result/MessageTransportType.pm
@@ +133,5 @@
>  );
>  
>  
> +# Created by DBIx::Class::Schema::Loader v0.07051 @ 2024-08-15 11:53:13
> +# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:Bx96QiqHxZ9SNbgK8dSwMg

There are no manual changes to split in separate commit. Whole commit should be
marked as [DO NOT PUSH]
https://wiki.koha-community.org/wiki/Database_updates#Files_to_change

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172663|0   |1
is obsolete||

--- Comment #165 from Martin Renvoize (ashimema) 
 ---
Created attachment 178675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178675&action=edit
Bug 10190: Display value of OverdueNoticeFrom in note

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172662|0   |1
is obsolete||

--- Comment #164 from Martin Renvoize (ashimema) 
 ---
Created attachment 178674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178674&action=edit
Bug 10190: Only display default and library specific letters

This patch filters the list of letter templates available to use by only
those available for the context the rule is being added for (i.e. the
correct library relation)

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172661|0   |1
is obsolete||

--- Comment #163 from Martin Renvoize (ashimema) 
 ---
Created attachment 178673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178673&action=edit
Bug 10190: Take DefaultToLoggedInLibraryOverdueTriggers into account

This updates the logic for the default page load to take account of
DefaultToLoggedInLibraryOverdueTriggers.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172660|0   |1
is obsolete||

--- Comment #162 from Martin Renvoize (ashimema) 
 ---
Created attachment 178672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178672&action=edit
Bug 10190: Rename 'All *' to 'Default rule for *'

Try to clarify that the 'All' rules are actually fallback/default rules
for when there's not a more specific rule for the context.

We need to expose these clearly for each 'Library' view too which we're
not currently doing.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172659|0   |1
is obsolete||

--- Comment #161 from Martin Renvoize (ashimema) 
 ---
Created attachment 178671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178671&action=edit
Bug 10190: Rebase for rspack

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172658|0   |1
is obsolete||

--- Comment #160 from Martin Renvoize (ashimema) 
 ---
Created attachment 178670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178670&action=edit
Bug 10190: Update for bootstrap 5

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172657|0   |1
is obsolete||

--- Comment #159 from Martin Renvoize (ashimema) 
 ---
Created attachment 178669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178669&action=edit
Bug 10190: Clarify workflow

This patch re-arranges the edit/add modal form to clarify the
need to select context, then decide on editing an existing trigger or
adding a new one and then, and only then, exposes the actual rule inputs

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172656|0   |1
is obsolete||

--- Comment #158 from Martin Renvoize (ashimema) 
 ---
Created attachment 178668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178668&action=edit
Bug 10190: Add custom input for delay

This custom input allows for dynamic min/max rules and it updates the
input styling to match other inputs on the page including a 'clear'
button.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172655|0   |1
is obsolete||

--- Comment #157 from Martin Renvoize (ashimema) 
 ---
Created attachment 178667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178667&action=edit
Bug 10190: Modal form improvements

We now fetch all rules on modal open and the effective rule on context
selection.

This allows us to compare the specific values of the rule we're
adding/editing to the fallback values present in the all rules set.

We use the fallback rule values as placeholders in the input boxes to
highlight to the end user what value will be used should they choose to
wipe the input.  We also allow wiping inputs and pass 'null' to the API
appropriately.

Finally, we set a minimum value for delay when adding a new rule to
highlight to the user that the new trigger will be added after existing
triggers.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172654|0   |1
is obsolete||

--- Comment #156 from Martin Renvoize (ashimema) 
 ---
Created attachment 178666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178666&action=edit
Bug 10190: Restore 'edit' from 'Add/Edit' Modal

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172653|0   |1
is obsolete||

--- Comment #155 from Martin Renvoize (ashimema) 
 ---
Created attachment 178665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178665&action=edit
Bug 10190: Display effective values and highlight them

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172650|0   |1
is obsolete||

--- Comment #152 from Martin Renvoize (ashimema) 
 ---
Created attachment 178662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178662&action=edit
Bug 10190: Update itiva script to reflect move to circ_rules

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172652|0   |1
is obsolete||

--- Comment #154 from Martin Renvoize (ashimema) 
 ---
Created attachment 178664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178664&action=edit
Bug 10190: Rework logic of overdue_notices

The original logic for digesting overdues in the overdue notices script
was flawed given the additional itemtype handling introduced in this
patchset and the way in which it handles effective fallbacks for rules.

This patch tidies the file and reworks the logic so that we fetch
overdues by patron category and branch and then iterate through those
comparing to the correct effective rules and combing them into digest
groups based on notice + trigger level.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172651|0   |1
is obsolete||

--- Comment #153 from Martin Renvoize (ashimema) 
 ---
Created attachment 178663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178663&action=edit
Bug 10190: Add comments to overdue_notices and rename variable

Trying to fully understand how this script operates.. this patch adds
some notes to the script for developers and also renames a variable that
I found was being re-used.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172649|0   |1
is obsolete||

--- Comment #151 from Martin Renvoize (ashimema) 
 ---
Created attachment 178661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178661&action=edit
Bug 10190: Remove old overduerules interface

This patch updates the link from the tools homepage to open the new
circulation triggers administration page.

We then remove the old overduerules controller and template, and finally
we drop the no longer referenced
C4::Overdues::GetOverdueMessageTransportTypes method and associated unit
tests.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172648|0   |1
is obsolete||

--- Comment #150 from Martin Renvoize (ashimema) 
 ---
Created attachment 178660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178660&action=edit
Bug 10190: Migrate MarkIssueReturned test to circulation rules

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172647|0   |1
is obsolete||

--- Comment #149 from Martin Renvoize (ashimema) 
 ---
Created attachment 178659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178659&action=edit
Bug 10190: Add fallback to 'Default' text for notice

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172646|0   |1
is obsolete||

--- Comment #148 from Martin Renvoize (ashimema) 
 ---
Created attachment 178658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178658&action=edit
Bug 10190: Set tab based on trigger edited/created

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172645|0   |1
is obsolete||

--- Comment #147 from Martin Renvoize (ashimema) 
 ---
Created attachment 178657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178657&action=edit
Bug 10190: Add letter names to tables

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172644|0   |1
is obsolete||

--- Comment #146 from Martin Renvoize (ashimema) 
 ---
Created attachment 178656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178656&action=edit
Bug 10190: Update has_restricting_overdues to refer to circulation rules

This patch updates the Koha::Patron->has_restriction_overdues method to
refer to the migrated overdue rules.

We also correct an oversight in the method prior to this patch that
meant that not all overdues were being correctly checked for a
restriction.. we were incorrectly filtering to only overdues at the
current checkin branch.

Finally, we also take account of the itemtype level addition here too.

NOTE: There weren't any unit tests for this Koha::Patron method.. we
should add some here!

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172642|0   |1
is obsolete||

--- Comment #144 from Martin Renvoize (ashimema) 
 ---
Created attachment 178654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178654&action=edit
Bug 10190: Update overdue_notices script to refer to circ rules

This patch updates the overdue_notices cron script to refer to the new
location for overdue rules found in the circulation rules table now.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172643|0   |1
is obsolete||

--- Comment #145 from Martin Renvoize (ashimema) 
 ---
Created attachment 178655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178655&action=edit
Bug 10190: Add itemtype handling to overdue_notices script

This patch enhances the overdue_notices script to understand the newly
introduced itemtype level for overdue rules.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172641|0   |1
is obsolete||

--- Comment #143 from Martin Renvoize (ashimema) 
 ---
Created attachment 178653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178653&action=edit
Bug 10190: Update GetBranchcodesWithOverdueRules to use CirculationRules

This patch updates the C4::Overdues method
GetBranchecodesWithOverdueRules to refer to the new location of these
rules in the circulation rules table. We also update the unit tests to
move the mocked data into the right location.

We could perhaps migrate this method in Koha::CirculationRules at a
later date?

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172640|0   |1
is obsolete||

--- Comment #142 from Martin Renvoize (ashimema) 
 ---
Created attachment 178652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178652&action=edit
Bug 10190: Let the circulation_rules endpoint accept query parameters

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172639|0   |1
is obsolete||

--- Comment #141 from Martin Renvoize (ashimema) 
 ---
Created attachment 178651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178651&action=edit
Bug 10190: Add itemtypes and patron categories to the item/patron api clients

This patch adds patron and itemtype api clients for the Vue ecosystem

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172638|0   |1
is obsolete||

--- Comment #140 from Martin Renvoize (ashimema) 
 ---
Created attachment 178650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178650&action=edit
Bug 10190: Add a library API client

This patch adds a library api client to the vue ecosystem for later use
in the Circulation triggers page.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172637|0   |1
is obsolete||

--- Comment #139 from Martin Renvoize (ashimema) 
 ---
Created attachment 178649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178649&action=edit
Bug 10190: Add components to list/add and edit circulation triggers

These new components are used by the new 'Circulation triggers'
administration page to display existing trigger rules and add the
ability to add new rules and edit existing ones.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172636|0   |1
is obsolete||

--- Comment #138 from Martin Renvoize (ashimema) 
 ---
Created attachment 178648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178648&action=edit
Bug 10190: Add a vue app for circulation triggers

This patch adds a new vue based page for administering circulation
triggers.  This aims to replace the 'Overdue notice/status triggers'
page available from Tools.

The new page is available from Koha administration > Circulation triggers

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172634|0   |1
is obsolete||

--- Comment #136 from Martin Renvoize (ashimema) 
 ---
Created attachment 178646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178646&action=edit
Bug 10190: Fix unit test to exclude _X_ rules

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172635|0   |1
is obsolete||

--- Comment #137 from Martin Renvoize (ashimema) 
 ---
Created attachment 178647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178647&action=edit
Bug 10190: Add support for incrementable circulation rules

This patch adds support for _X_ grouped circulation rules to both the
internal and external API's for handling circulation rules.

This allows us to group overdue_X_rulename rules by an 'X' integer so we
can have triggers incremented and grouped together.

We also add the new overdue_x_* rule definition here for overdue trigger
rules.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172633|0   |1
is obsolete||

--- Comment #135 from Martin Renvoize (ashimema) 
 ---
Created attachment 178645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178645&action=edit
Bug 10190: Remove OverdueRule Koha Objects

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172632|0   |1
is obsolete||

--- Comment #134 from Martin Renvoize (ashimema) 
 ---
Created attachment 178644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178644&action=edit
Bug 10190: DBIC Schema update

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172631|0   |1
is obsolete||

--- Comment #133 from Martin Renvoize (ashimema) 
 ---
Created attachment 178643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178643&action=edit
Bug 10190: DB migration for overduerules

This patch adds the data migration for overduerules to circulation
rules.

We attempt to create the default rules based on most commonly occuring
rule values and then add overrides for all other rule values we find.

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2025-02-21 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2024-12-12 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Michael Adamyk  changed:

   What|Removed |Added

 CC||michael.adamyk@bywatersolut
   ||ions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2024-12-12 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

[email protected] changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2024-12-12 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Lisette Scheer  changed:

   What|Removed |Added

 CC||[email protected]
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2024-11-08 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Michaela Sieber  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2024-10-31 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

   Keywords||roadmap_24_11,
   ||roadmap_25_05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2024-10-30 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Matt Blenkinsop  changed:

   What|Removed |Added

 CC||matt.blenkinsop@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2024-10-23 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

--- Comment #132 from Martin Renvoize (ashimema) 
 ---
(In reply to Martin Renvoize (ashimema) from comment #65)
> Notes from Nick Clemens at KohaCon24
> * Use syspref for 'All libraries' or 'Logged in library' by default -
> DefaultToLoggedInLibraryOverdueTriggers

DONE

> * Note about whether we're talking aobut 'patrons home library' or 'items
> home library'

DONE

> * If a notice template is only set up for one library only display it in the
> notice dropdown when in that context

DONE

> * Can we expose somewhere the list of all notice trigger context
> combinations..

In a follow-up bug I reckon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2024-10-10 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10190] Overdue notice triggers based on item type

2024-10-10 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #172630|0   |1
is obsolete||

--- Comment #131 from Martin Renvoize (ashimema) 
 ---
Created attachment 172663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172663&action=edit
Bug 10190: Display value of OverdueNoticeFrom in note

Sponsored-by: Glasgow Colleges Library Group

Signed-off-by: George Harkins 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 3 >

1 - 100 of 235 matches

Mail list logo