[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Arthur Suzuki changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=41768 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 --- Comment #16 from Marie-Luce Laflamme --- Further notes: If you are modifying the system preference OPACAllowUserToChooseBranch to allow the pick up branch selection, Koha will block the hold by removing the blocked branch name from the menu. Therefore, Koha prevent the patron to place an hold and send it to their branch when the transfer is not allowed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Marie-Luce Laflamme changed: What|Removed |Added CC||marie-luce.laflamme@inlibro ||.com --- Comment #15 from Marie-Luce Laflamme --- Koha seems to correctly apply the transfer limit now, but Koha doesn't warn patron when the hold cannot be placed. Specifications: Koha with at least 2 branches: branch A , branch B Systeme preference: UseBranchTransferLimits ---> Enforce Systeme preference BranchTransferLimitsType ---> item type System preference OPACAllowUserToChooseBranch ---> Don’t allow Configurations – transfer limit 1. Go to Administration › Set Library checkin and transfer limit 2. Select a branch A (top menu) 3. Click on the item type tab to block any transfer 4. Uncheck branch B 5. Save 6. Select branch B (top menu) 7. Click on the item type tab 8. Uncheck branch A to block any transfer 9. Save Test Plan 1. Find a patron from branch B 2. Go on the OPAC, find an item currently checkout from branch A (same item type that should be blocked) 3. Place a hold in the patron account (branch B) 4. Confirm the hold –> notice that Koha doesn’t add the hold in the patron account, but there is no explanation, it is uncleared what just happen. The usual message «There are no items that can be placed on holds» isn’t popping up on screen to confirm that this action cannot be done. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Nick Clemens changed: What|Removed |Added CC||[email protected] See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=7614 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 M. Tompsett changed: What|Removed |Added CC||[email protected] --- Comment #14 from M. Tompsett --- (In reply to Olli-Antti Kivilahti from comment #13) > Sorry, I cannot work on this currently. I will let this slide to the next > one who encounters this issue and wants to fix it. Hopefully using some of > my code :) I felt like fainting getting half way through with no sign of any obvious changes, except for white space. Do you have time to make reading and testing it more feasible? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti changed: What|Removed |Added Assignee|[email protected] |[email protected] ||ity.org --- Comment #13 from Olli-Antti Kivilahti --- Sorry, I cannot work on this currently. I will let this slide to the next one who encounters this issue and wants to fix it. Hopefully using some of my code :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Paul Poulain changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Paul Poulain --- trying to test this patch during hackfest KohaCon14. Unfortunately, it does not apply : fatal: sha1 information is lacking or useless (C4/Circulation.pm). Another problem: you're mixed "real", "new" code and reindent/perlity. This patch cannot be QAed. I encourage you to perltidy/reindent, but in a separate patch please. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #22322|0 |1 is obsolete|| --- Comment #11 from Olli-Antti Kivilahti --- Created attachment 23163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23163&action=edit Bug 10993 - Transfer limits should be checked when placing a hold/reservation in OPAC. Depends on bug 11005, 11020 Prevents a user from placing holds on material whose branch transfer is denied. Displays clear messages that items are unavailable and re-checks in the business layer in case of UI blocks failing. Enables choosing another pickup location. Manual test plan included. Formatted with perltidy and Perl::Critic level 5 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti changed: What|Removed |Added Depends on|11020 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti changed: What|Removed |Added Blocks||11020 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 --- Comment #10 from Olli-Antti Kivilahti --- Fixed tabs to spaces in indentation. Didn't realize my IDE uses tabs instead of spaces until bug 11024/7376. Not sure about templates since they are such a mess regarding indentation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #22000|0 |1 is obsolete|| --- Comment #9 from Olli-Antti Kivilahti --- Created attachment 22322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22322&action=edit Bug 10993 - Transfer limits should be checked when placing a hold/reservation in OPAC. Depends on bug 11005, 11020 Prevents a user from placing holds on material whose branch transfer is denied. Displays clear messages that items are unavailable and re-checks in the business layer in case of UI blocks failing. Enables choosing another pickup location. Manual test plan included. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Paul Poulain changed: What|Removed |Added CC||[email protected] --- Comment #8 from Paul Poulain --- Some QA comments about this patch (I haven't tested, just looking at the code) * you must use 4 spaces and not tabs * +1 for the "manual test case". Note that we use the term "test plan". It could confuse some tester that are not english natives & could search the test plan No other code or patch comment (which does not mean passed QA yet, I haven't tested it either) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti changed: What|Removed |Added Blocks|11024 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #21891|0 |1 is obsolete|| Attachment #21892|0 |1 is obsolete|| --- Comment #7 from Olli-Antti Kivilahti --- Created attachment 22001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22001&action=edit Manual test cases -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 --- Comment #6 from Olli-Antti Kivilahti --- Created attachment 22000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22000&action=edit Bug 10993 - Transfer limits should be checked when placing a hold/reservation in OPAC. Depends on bug 11005, 11020 Prevents a user from placing holds on material whose branch transfer is denied. Displays clear messages that items are unavailable and re-checks in the business layer in case of UI blocks failing. Enables choosing another pickup location. Manual tests included. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti changed: What|Removed |Added Blocks|11020 | Depends on||11020 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 --- Comment #5 from Olli-Antti Kivilahti --- Sponsored by the Joensuu Regional Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti changed: What|Removed |Added Blocks||11024 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti changed: What|Removed |Added Blocks||11020 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 --- Comment #4 from Olli-Antti Kivilahti --- Created attachment 21892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21892&action=edit quickie test document -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 --- Comment #3 from Olli-Antti Kivilahti --- Created attachment 21891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21891&action=edit Bug 10993 [ENH] - Transfer limits should be checked when placing a hold/reservation in OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti changed: What|Removed |Added Summary|Transfer limits should be |Transfer limits should be |checked when placing a |checked when placing a |hold/reservation. |hold/reservation in OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
