[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 David Cook changed: What|Removed |Added Status|Patch doesn't apply |Failed QA CC||dc...@prosentient.com.au --- Comment #20 from David Cook --- (In reply to Fridolin Somers from comment #19) > Looks obsolete since we have Koha/SearchEngine/Zebra Yeah, Koha/SearchEngine/Zebra/Indexer.pm would be the best place to house this code. "./misc/migration_tools/rebuild_zebra.pl" is nearly 1000 lines long, which is not a good idea for a CLI script. I'd say this change has merit, but... it's super old. Personally, I'd be tempted to mark this one as RESOLVED WISHLIST, as it would be nice to have, but with the gradual shift to Elasticsearch... I don't know if it's really worth the time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Fridolin Somers changed: What|Removed |Added Blocks|13706 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 [Bug 13706] Deduping authorities script (dedup_authorities.pl) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #19 from Fridolin Somers --- Looks obsolete since we have Koha/SearchEngine/Zebra -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 --- Comment #18 from Jonathan Druart --- (In reply to Julian Maurice from comment #17) > (In reply to Jonathan Druart from comment #14) > > I would be great to see some tests to cover this new module (even if it's > > not new code). > How can we test code that should modify the Zebra index, without really > modifying it ? Should we create another Zebra instance for tests purpose ? We already do that in t/db_dependent/www/search_utf8.t and we do not care about not modifying the Zebra index. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 --- Comment #17 from Julian Maurice --- (In reply to Jonathan Druart from comment #14) > I would be great to see some tests to cover this new module (even if it's > not new code). How can we test code that should modify the Zebra index, without really modifying it ? Should we create another Zebra instance for tests purpose ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 --- Comment #16 from Julian Maurice --- (In reply to Katrin Fischer from comment #15) > Just a general question: why C4 and not Koha? The first version of this patch was written in 2012 (for bug 7419), that's why :) Should we move the code to Koha::ZebraIndex ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 --- Comment #15 from Katrin Fischer --- Just a general question: why C4 and not Koha? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #14 from Jonathan Druart --- I would be great to see some tests to cover this new module (even if it's not new code). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #35883|0 |1 is obsolete|| --- Comment #10 from Bernardo Gonzalez Kriegel --- Created attachment 49888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49888&action=edit [SIGNED_OFF] Bug 13705: Move indexation subs in C4::ZebraIndex Move indexation-related subs from rebuild_zebra.pl to new module C4::ZebraIndex and create two new subs IndexRecord and DeleteRecordIndex This should allow easier indexation from scripts other than rebuild_zebra.pl Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #40061|0 |1 is obsolete|| --- Comment #13 from Bernardo Gonzalez Kriegel --- Created attachment 49891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49891&action=edit [SIGNED-OFF] Bug 13705 - Fix QA comments Signed-off-by: Bernardo Gonzalez Kriegel Tested using options -v -a -b -x -r -w -z --length --offset -nosanitize No problems found, same results as before. Output slightly different: Old) exporting authority 301 Records exported: 389 REINDEXING zebra New) REINDEXING zebra 100 200 300 . 389 records exported to /tmp/PBlyusIn1Z/exported_records REINDEXING zebra === No errors save for those on comment #8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #40060|0 |1 is obsolete|| --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 49890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49890&action=edit [SIGNED-OFF] Bug 13705 - Update copyright and GPL Licence statement in C4/ZebraIndex.pm Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #35884|0 |1 is obsolete|| --- Comment #11 from Bernardo Gonzalez Kriegel --- Created attachment 49889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49889&action=edit [SIGNED_OFF] Bug 13705: Prevent a warning in _fix_unimarc_100 Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #9 from Katrin Fischer --- I think you can continue - this should be fixed by another patch that passed QA recently. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 --- Comment #8 from Bernardo Gonzalez Kriegel --- Hi, new errors FAIL C4/ZebraIndex.pm OK critic OK forbidden patterns OK pod OK spelling 0 FAIL valid Name "Cache::RemovalStrategy::FIELDS" used only once: possible typo Name "Cache::RemovalStrategy::LRU::FIELDS" used only once: possible typo Name "Tie::Hash::FIELDS" used only once: possible typo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Zeno Tajoli changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Alex Arnaud changed: What|Removed |Added Assignee|julian.maur...@biblibre.com |alex.arn...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Alex Arnaud changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Alex Arnaud changed: What|Removed |Added CC||alex.arn...@biblibre.com Status|Failed QA |Signed Off --- Comment #7 from Alex Arnaud --- The 2 last patch are follow up fixing licence statement and a qa warning. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 --- Comment #6 from Alex Arnaud --- Created attachment 40061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40061&action=edit Bug 13705 - Fix QA comments -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 --- Comment #5 from Alex Arnaud --- Created attachment 40060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40060&action=edit Bug 13705 - Update copyright and GPL Licence statement in C4/ZebraIndex.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||bgkrie...@gmail.com --- Comment #4 from Bernardo Gonzalez Kriegel --- We still add things on C4? Just a question 1) License need to be updated to GPL v3 2) koha-qa complains FAIL C4/ZebraIndex.pm OK pod OK forbidden patterns OK critic FAIL valid "my" variable $string masks earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Julian Maurice changed: What|Removed |Added Blocks||13706 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #3 from Julian Maurice --- To test, run rebuild_zebra.pl trying the different options. The behaviour should remain identical. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 --- Comment #2 from Julian Maurice --- Created attachment 35884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35884&action=edit Bug 13705: Prevent a warning in _fix_unimarc_100 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 --- Comment #1 from Julian Maurice --- Created attachment 35883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35883&action=edit Bug 13705: Move indexation subs in C4::ZebraIndex Move indexation-related subs from rebuild_zebra.pl to new module C4::ZebraIndex and create two new subs IndexRecord and DeleteRecordIndex This should allow easier indexation from scripts other than rebuild_zebra.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
