[Koha-bugs] [Bug 13870] Add warnings about subscriptions and orders when deleting items

2025-01-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13870

Thibaud Guillot (thibaud_g)  changed:

   What|Removed |Added

 Attachment #155576|0   |1
is obsolete||
 Attachment #175440|0   |1
is obsolete||

--- Comment #12 from Thibaud Guillot (thibaud_g)  
---
Created attachment 176858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176858&action=edit
Bug 13870: Add warn about linked order or/and subscription on batch item table

When you try to manage/delete/edit items I added an info about linked
order or/and linked subscription.

Test plan :

1) Apply this patch
2) Restart_all
3) Be sure to have item with order or can concern by a subscription
4) On biblio record page click on Edit -> Manage items
5) See the yellow triangle next to the 'delete' action in 'actions'
dropdown menu (with subscription id or ordernumber hover the symbol)
6) When you edit or delete items (batch mode) you can see two new
columns about orders and subscriptions linked.

Sponsored by: BibLibre

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13870] Add warnings about subscriptions and orders when deleting items

2025-01-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13870

Thibaud Guillot (thibaud_g)  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13870] Add warnings about subscriptions and orders when deleting items

2025-01-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13870

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||vic...@tuxayo.net

--- Comment #11 from Victor Grousset/tuxayo  ---
If I understand correctly a problem was found during testing, so that would be
failed QA. At least this need to be clarified to not make other testers
hesitate whether to test or not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13870] Add warnings about subscriptions and orders when deleting items

2025-01-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13870

Nathalie SAVARIT  changed:

   What|Removed |Added

 CC||nathalie.savarit@univ-amu.f
   ||r

--- Comment #10 from Nathalie SAVARIT  ---
Hi Thibaud,
we tested the patch during Hackathon KohaLa today.
Ok for one item (linked with a subscription) but not for batch delete mode.
I think we can link the patch with BZ 37115 (Add the option to delete linked
serials when deleting items) from items linked with a subscription.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13870] Add warnings about subscriptions and orders when deleting items

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13870

--- Comment #9 from Thibaud Guillot (thibaud_g)  
---
Hello all,

I've just rebased it, thanks Katrin for your review, and Frido too ! 
I've changed my request to use prefetch like Frido said and I also fix the
missing filter.
For the tidiness.. I've tried to found it but maybe a "false positive" ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13870] Add warnings about subscriptions and orders when deleting items

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13870

Thibaud Guillot (thibaud_g)  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13870] Add warnings about subscriptions and orders when deleting items

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13870

Thibaud Guillot (thibaud_g)  changed:

   What|Removed |Added

 Attachment #152235|0   |1
is obsolete||

--- Comment #8 from Thibaud Guillot (thibaud_g)  
---
Created attachment 175440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175440&action=edit
Bug 13870: Added a visual warning message on the item batch form

I add a visual warn on item linked to subscription or concern
by an order. I don't think that pop-up could be the solution so I put a
warn triangle aside the delete action to
I don't think another pop-up is the ideal solution so I chose to integrate a
yellow triangle
right next to the action leading to the deletion of the 'item' with a hover
message
if a subscription or order is linked. I'm looking forward to your feedback :)

Test plan :

1) Apply this patch
2) Be sure to have item with order or can concern by a subscription
3) Edit them to go on the batch form
4) See the yellow triangle next to the 'delete' action in 'actions'
dropdown menu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13870] Add warnings about subscriptions and orders when deleting items

2023-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13870

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #7 from Fridolin Somers  ---
Hi,

my $i_order = GetOrderFromItemnumber($itemnumber);
my $i_serialid = Koha::Serial::Items->search( {itemnumber => $itemnumber}
)->get_column('serialid');

Is there a performance impact ?

Better prefetch linked tables maybe.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13870] Add warnings about subscriptions and orders when deleting items

2023-10-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13870

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35005
Summary|Add subscription and order  |Add warnings about
   |count to new batch record   |subscriptions and orders
   |deletion tool   |when deleting items

--- Comment #6 from Katrin Fischer  ---
Hi Thibaud,

I was excited to see this, but it turned out a little bit different to what I
had expected:

1) The bug was filed for the 'batch record deletion tool'. Your patch deals
with deleting single items. This can be fixed rather easily by changing the bug
description and re-filing (see bug 35005)

2) For orders, I think we need to make some difference between an order that
has been completed and one that is still pending. Deleting an item that is
linked to a pending order would get us in trouble. Throwing out an old item
purchased long ago not.

Concerning order status would be: new, ordered, partial
OK to delete: cancelled, complete

4) This line appears unrelated to the intention of the patch:

+$i->{nomod} = 1 unless $patron->can_edit_items_from($item->homebranch);


5) The warnings messages you created are untranslatable, they need to be moved
into the templates:

cataloguing/additem.pl
+if ($i_order) {
+$warning_messages{$i->{itemnumber}} = sprintf('There is an order
(ordernumber %s) on this item', $i_order->{ordernumber} );
+}
+if ($i_serialid) {
+$warning_messages{$i->{itemnumber}} = 'A subscription is linked to
this item'

6) The subscription count on item batch modification doesn't seem to work
right. I added a subscription and created an item on receiving an issue, so
it's linked to the subscription. But it still said "None" on the batch mod
page.

7) The order count on item batch modification doesn't appear to work either. I
added an order with 'create items on order' and that item to the batch edit -
The column remained at "None".

8) The notes work OK on the normal item editing form. I like the approach with
the little warning sign.

9) QA tools are failing for a missing filter and tidiness.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/