[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Lucas Gass (lukeg) changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #18 from Lucas Gass (lukeg) --- Some stuff leftover in the DBUpdate that should be removed: # Other information say_success( $out, "Use green for success" ); say_warning( $out, "Use yellow for warning/a call to action" ); say_info( $out, "Use blue for further information" ); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 David Flater changed: What|Removed |Added CC||[email protected] Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 David Flater changed: What|Removed |Added Attachment #182922|0 |1 is obsolete|| --- Comment #17 from David Flater --- Created attachment 183907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183907&action=edit Bug 17473: Add void payment permission Signed-off-by: David Flater -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Lucas Gass (lukeg) changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #16 from Lucas Gass (lukeg) --- This has been sitting for almost a yea, resetting to 'Needs Sign off' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Lucas Gass (lukeg) changed: What|Removed |Added QA Contact|[email protected] | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473
--- Comment #15 from Eric Garcia ---
(In reply to Katrin Fischer from comment #11)
> 1) Capitalization
>
> + (10, 'void_payment', 'Voiding Payments'),
>
> +$dbh->do(q{
> +INSERT IGNORE permissions (module_bit, code, description) VALUES
> +(10, 'void_payment', 'Voiding Payments')
>
> Etc.
>
Fixed.
>
> For Koha we have decided to only upper-case names and the first word. Please
> check coding guidelines for more information.
>
> 2) This is missing a server side check.
I believe this should be done in a separate bug because we do not have check
for payout, refund, discount, etc. in boraccount.pl. Thoughts?
>
> I believe we also need to check for this permission server side and maybe in
> the API.
>
> I would be OK to handle the API on a separate bug if there is no veto, but
> would like to see a re-worked patch with fixed capitalization and the server
> side check looked into.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #174944|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Eric Garcia changed: What|Removed |Added Attachment #174943|0 |1 is obsolete|| --- Comment #14 from Eric Garcia --- Created attachment 182922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182922&action=edit Bug 17473: Add void payment permission -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Katrin Fischer changed: What|Removed |Added Text to go in the||RM REVERTED release notes|| --- Comment #13 from Katrin Fischer --- Added a note to the notes fields as I had accidentally pushed this despite setting to failed QA. Reverted for now, if we can't fix before 25.05 (which I don't hope) it will serve as a reminder to fix release notes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473
Katrin Fischer changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #11 from Katrin Fischer ---
1) Capitalization
+ (10, 'void_payment', 'Voiding Payments'),
+$dbh->do(q{
+INSERT IGNORE permissions (module_bit, code, description) VALUES
+(10, 'void_payment', 'Voiding Payments')
Etc.
For Koha we have decided to only upper-case names and the first word. Please
check coding guidelines for more information.
2) This is missing a server side check.
I believe we also need to check for this permission server side and maybe in
the API.
I would be OK to handle the API on a separate bug if there is no veto, but
would like to see a re-worked patch with fixed capitalization and the server
side check looked into.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 --- Comment #12 from Katrin Fischer --- 3) Database update Oh! While you are on it, please update the atomicupate to use the recent template. The success message should be after both SQL statements or they each should have one. They should use say_success. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Katrin Fischer changed: What|Removed |Added Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Lucas Gass (lukeg) changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Lucas Gass (lukeg) changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #169387|0 |1 is obsolete|| --- Comment #10 from Lucas Gass (lukeg) --- Created attachment 174944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174944&action=edit Bug 17473: (follow-up) add semicolon after use Modern::Perl Signed-off-by: Roman Dolny Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #169386|0 |1 is obsolete|| --- Comment #9 from Lucas Gass (lukeg) --- Created attachment 174943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174943&action=edit Bug 17473: Add void payment permission To test: 1. Apply patch, updatedatabase, restart_all 2. Search for staff patron 3. More -> Set permissions 4. Check - Staff access, allows viewing of catalogue in staff interface - Add, modify and view patron information - Manage patrons fines and fee 5. Notice under Manage patrons fines and fee there is a new permission "Voiding Payments" 6. Sign into staff interface as your selected staff patron 7. Search for a non-staff patron -> Accounting 8. Click 'Create manual invoice', add an amount and click 'Save and pay' -> 'Confirm' 9. Go to transactions and notice the option to Void payment appears 10. Go back to your staff patron's permission and unselect 'Voiding Payments' 11. Go to your non-staff patron and notice the option to void payments is gone Signed-off-by: Roman Dolny Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 --- Comment #8 from Lucas Gass (lukeg) --- This all looks right to me. DB update is correct, simple change to templates. I am passing QA here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 --- Comment #7 from Roman Dolny --- Created attachment 169387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169387&action=edit Bug 17473: (follow-up) add semicolon after use Modern::Perl Signed-off-by: Roman Dolny -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Roman Dolny changed: What|Removed |Added Attachment #169310|0 |1 is obsolete|| Attachment #169384|0 |1 is obsolete|| --- Comment #6 from Roman Dolny --- Created attachment 169386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169386&action=edit Bug 17473: Add void payment permission To test: 1. Apply patch, updatedatabase, restart_all 2. Search for staff patron 3. More -> Set permissions 4. Check - Staff access, allows viewing of catalogue in staff interface - Add, modify and view patron information - Manage patrons fines and fee 5. Notice under Manage patrons fines and fee there is a new permission "Voiding Payments" 6. Sign into staff interface as your selected staff patron 7. Search for a non-staff patron -> Accounting 8. Click 'Create manual invoice', add an amount and click 'Save and pay' -> 'Confirm' 9. Go to transactions and notice the option to Void payment appears 10. Go back to your staff patron's permission and unselect 'Voiding Payments' 11. Go to your non-staff patron and notice the option to void payments is gone Signed-off-by: Roman Dolny -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Roman Dolny changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 --- Comment #5 from Lucas Gass --- Created attachment 169384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169384&action=edit Bug 17473: (follow-up) add semicolon after use Modern::Perl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Roman Dolny changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||[email protected] --- Comment #4 from Roman Dolny --- There is error during updatedatabase: ERROR - {UNKNOWN}: Can't use an undefined value as a subroutine reference at /kohadevbox/koha/C4/Installer.pm line 739. at /kohadevbox/koha/C4/Installer.pm line 741 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Eric Garcia changed: What|Removed |Added Attachment #169109|0 |1 is obsolete|| --- Comment #3 from Eric Garcia --- Created attachment 169310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169310&action=edit Bug 17473: Add void payment permission To test: 1. Apply patch, updatedatabase, restart_all 2. Search for staff patron 3. More -> Set permissions 4. Check - Staff access, allows viewing of catalogue in staff interface - Add, modify and view patron information - Manage patrons fines and fee 5. Notice under Manage patrons fines and fee there is a new permission "Voiding Payments" 6. Sign into staff interface as your selected staff patron 7. Search for a non-staff patron -> Accounting 8. Click 'Create manual invoice', add an amount and click 'Save and pay' -> 'Confirm' 9. Go to transactions and notice the option to Void payment appears 10. Go back to your staff patron's permission and unselect 'Voiding Payments' 11. Go to your non-staff patron and notice the option to void payments is gone -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Eric Garcia changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 --- Comment #2 from Eric Garcia --- Created attachment 169109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169109&action=edit Bug 17473: Add void payment permission To test: 1. Apply patch, updatedatabase, restart_all 2. Search for staff patron 3. More -> Set permissions 4. Check - Staff access, allows viewing of catalogue in staff interface - Add, modify and view patron information - Manage patrons fines and fee 5. Notice under Manage patrons fines and fee there is a new permission "Voiding Payments" 6. Sign into staff interface as your selected staff patron 7. Search for a non-staff patron -> Accounting 8. Click 'Create manual invoice', add an amount and click 'Save and pay' -> 'Confirm' 9. Go to transactions and notice the option to Void payment appears 10. Go back to your staff patron's permission and unselect 'Voiding Payments' 11. Go to your non-staff patron and notice the option to void payments is gone -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Eric Garcia changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Lucas Gass changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org | CC||[email protected] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Martin Renvoize changed: What|Removed |Added Keywords||Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Martin Renvoize changed: What|Removed |Added Blocks||24849 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24849 [Bug 24849] Permissions checks are missing in borracount controller -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Depends on||18790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790 [Bug 18790] Add ability to void payments -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17473] Permission for voiding payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17473 Katrin Fischer changed: What|Removed |Added CC||[email protected] Summary|Reverse payment permission |Permission for voiding ||payments --- Comment #1 from Katrin Fischer --- With bug 20629 the option to reverse payments will be gone. I am changing this to be a permission for the replacement: voiding payments. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
