[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 --- Comment #12 from David Cook --- Something is bugging me with this... If it's an item-level hold which we placed with an override, and we have the item in hand, surely we would want to honour the hold. If it were a "next available" hold, then... I could see not honouring it, because we have no way of knowing that the hold placer is authorized to have this item fulfil that hold? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 --- Comment #11 from David Cook --- I'm not sure if anyone is going to have the resources to do this one, and yet it needs to be done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 Phillip Berg changed: What|Removed |Added CC||[email protected] --- Comment #10 from Phillip Berg --- We're definitely interested in this as well. Having it as an option would be hugely helpful when trying to do more complex throttling when it comes to holds fulfillment as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 Michelle Spinney changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 David Cook changed: What|Removed |Added CC||[email protected] --- Comment #9 from David Cook --- It was driving me crazy trying to figure out why the hold wasn't being trapped, and it was because the "Hold policy" was set to "No holds allowed" for the branch library. -- That said, I might agree about the patch not being enough. As Katrin said, there's no way to know that this was an overridden hold. That said, that makes this extremely difficult to fix with the current code. (In reply to rpalermo from comment #8) > This is how we always thought it was supposed to work. If the hold is placed > with an override in Koha staff side, it should be filled at checkin. What > other reason would there be to override and place the hold if not to have it > get trapped? But I also agree with this. I mean if a hold exists, it must mean that it followed the rules at the time of its placement (whether via an override or not), so surely we should trap the hold. But... I guess we're looping through reserves at this point... and the branch with "No holds allowed" shouldn't fill the hold but a different branch could, so it wouldn't make sense to trap the hold in this case. -- Holds are a very challenging area... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 Katie Bliss changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 [email protected] changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 Chip Halvorsen changed: What|Removed |Added CC||Chip.Halvorsen@WestlakeLibr ||ary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27464 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 --- Comment #8 from [email protected] --- This is how we always thought it was supposed to work. If the hold is placed with an override in Koha staff side, it should be filled at checkin. What other reason would there be to override and place the hold if not to have it get trapped? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 [email protected] changed: What|Removed |Added CC||[email protected], ||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 Andrew Fuerste-Henry changed: What|Removed |Added CC||christophe.croullebois@bibl ||ibre.com --- Comment #7 from Andrew Fuerste-Henry --- *** Bug 17884 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 Andrew Fuerste-Henry changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 Chris Rowlands changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 Emily Lamancusa changed: What|Removed |Added Depends on||31169 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31169 [Bug 31169] [OMNIBUS] Problems with forced holds (AllowHoldPolicyOverride) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov Status|ASSIGNED|In Discussion --- Comment #6 from Emily Lamancusa --- +1 for adding a flag - holds violating the holds policy should trap if and only if the hold policy was explicitly overridden. Retaining that information in a flag seems like a good way to enforce that. Even with an override flag, there are some possible side effects with bib level holds, though... For sure I can see problems for consortia that have set-in-stone rules about which branches can and cannot share resources, but allow overrides for other reasons. With a simple true/false override flag, a hold that was placed with an override for other reasons (e.g. patron category, hold limits, etc) could unintentionally override the branch restriction and trigger a transfer that may not be possible or reasonable to actually fulfill. I'm not sure what the solution is here. - Flagging which specific policies were overridden when the hold was placed? (seems messy and with a high potential for side effects) - More granularity in the sysprefs governing which policies are allowed to be overridden at all? (I think this would be great, but not sure if this is the right place) - Apply this enhancement only to item-level holds, or give TriggerForbiddenHolds three settings - All / Item-level only / Off? We at MCPL would definitely like to see something like this go through (our staff often place holds to get their hands on items for workflow reasons, and currently that doesn't work for items that aren't normally holdable). But I think it needs a bit more examination to make sure it isn't unusable for systems that need to keep some things set in stone. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 Emily Lamancusa changed: What|Removed |Added CC||[email protected] --- Comment #5 from Emily Lamancusa --- *** Bug 28788 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 --- Comment #4 from Katrin Fischer --- I feel like this goes a little too far, because it would trigger holds for all items, independent on how the hold was placed - it doesn't check if it was an overridden hold. It feels like we should have a flag or similar on the reserves table when that happens. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 Owen Leonard changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 Martha Fuerst changed: What|Removed |Added CC||[email protected] --- Comment #3 from Martha Fuerst --- This is me being a squeaky wheel. We would love to help test this, as it would greatly benefit how we deal with holds that occasionally come out of our Outreach collection. -Marti Fuerst -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 Margaret changed: What|Removed |Added CC||[email protected] ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 --- Comment #1 from Nick Clemens --- Created attachment 76101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76101&action=edit Bug 20955: Add systempreference to allow triggering forbidden holds To test: 1 - Set a holds policy to allow only holds from homebranch 2 - Place a hold on an item for a patron from another branch 3 - Checkin item 4 - Hold does not trigger 5 - Apply patches and updatedatabase 6 - Check in item 7 - Hold triggers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 --- Comment #2 from Nick Clemens --- Created attachment 76102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76102&action=edit Bug 20955: Unit tests prove -v t/db_dependent/Holds/HoldFulfillmentPolicy.t prove -v t/db_dependent/Reserves.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20955] Add ability to trigger holds that violate holds policies (overridden holds)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20955 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
