[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr changed: What|Removed |Added Attachment #179839|0 |1 is obsolete|| --- Comment #46 from Philip Orr --- Created attachment 180536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180536&action=edit Bug 21272: (follow-up) Terminology and formatting Change warning message to "..missing libraries...". Remove space before colon for the warning message. Signed-off-by: David Nind Signed-off-by: PhilipOrr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele changed: What|Removed |Added Attachment #178928|0 |1 is obsolete|| --- Comment #41 from Hammat wele --- Created attachment 179844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179844&action=edit Bug 21272: (follow-up) tidy code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr changed: What|Removed |Added Attachment #179840|0 |1 is obsolete|| --- Comment #47 from Philip Orr --- Created attachment 180537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180537&action=edit Bug 21272: (follow-up) using List::MoreUtils#any to get rid of %branches and fixing GetImportItemsBranches in ImportBatch.pm Signed-off-by: PhilipOrr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele changed: What|Removed |Added Attachment #178925|0 |1 is obsolete|| --- Comment #38 from Hammat wele --- Created attachment 179841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179841&action=edit Bug 21272: Change warning message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr changed: What|Removed |Added Attachment #179841|0 |1 is obsolete|| --- Comment #48 from Philip Orr --- Created attachment 180538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180538&action=edit Bug 21272: Change warning message Signed-off-by: PhilipOrr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr changed: What|Removed |Added Attachment #179844|0 |1 is obsolete|| --- Comment #51 from Philip Orr --- Created attachment 180541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180541&action=edit Bug 21272: (follow-up) tidy code Signed-off-by: PhilipOrr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr changed: What|Removed |Added Attachment #179842|0 |1 is obsolete|| --- Comment #49 from Philip Orr --- Created attachment 180539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180539&action=edit Bug 21272: Improve warning message To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches --> There is a warning message showing the titles of the wrong items 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored Signed-off-by: PhilipOrr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr changed: What|Removed |Added Attachment #180383|0 |1 is obsolete|| --- Comment #52 from Philip Orr --- Created attachment 180542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180542&action=edit Bug 21272: (follow-up) Fix unit test Signed-off-by: PhilipOrr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #42 from Hammat wele --- Created attachment 180383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180383&action=edit Bug 21272: (follow-up) Fix unit test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr changed: What|Removed |Added Attachment #179838|0 |1 is obsolete|| --- Comment #45 from Philip Orr --- Created attachment 180535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180535&action=edit Bug 21272: Unit test Signed-off-by: David Nind Signed-off-by: PhilipOrr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr changed: What|Removed |Added Attachment #179837|0 |1 is obsolete|| --- Comment #44 from Philip Orr --- Created attachment 180534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180534&action=edit Bug 21272: MARC import should warn about mis-matched branch and item-type fields in 952 during staged import This plugin add a warning message to show missing branches during staged import, it also ignore item with wrong banches. To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches in a link 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored Signed-off-by: David Nind Signed-off-by: PhilipOrr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr changed: What|Removed |Added Attachment #179843|0 |1 is obsolete|| --- Comment #50 from Philip Orr --- Created attachment 180540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180540&action=edit Bug 21272: Unit test for methods GetBadBranchesImportItems and GetTitleImportRecord Signed-off-by: PhilipOrr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr changed: What|Removed |Added CC||philip@lmscloud.de --- Comment #43 from Philip Orr --- First of all: tests worked, will sign off. Secondly I have some minor suggestions for the warning messages. - it would be nice to show the records on newlines and not separated by | on the same line, easier to read. - "One and more": should be "One or more" (or just: "Several" if you know there is more than one) - the warning message is using the dialog alert class. But it's not very easy to visually directly interpret as a warning message if you ask me, it's gray text on gray background, not quickly noticeable. I would have expected it to stand out more from the other content. I will leave it to the QA people though as I'm not experienced enough in this kind of thing.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele changed: What|Removed |Added Attachment #178926|0 |1 is obsolete|| --- Comment #39 from Hammat wele --- Created attachment 179842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179842&action=edit Bug 21272: Improve warning message To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches --> There is a warning message showing the titles of the wrong items 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele changed: What|Removed |Added Attachment #178922|0 |1 is obsolete|| --- Comment #35 from Hammat wele --- Created attachment 179838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179838&action=edit Bug 21272: Unit test Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele changed: What|Removed |Added Attachment #178927|0 |1 is obsolete|| --- Comment #40 from Hammat wele --- Created attachment 179843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179843&action=edit Bug 21272: Unit test for methods GetBadBranchesImportItems and GetTitleImportRecord -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele changed: What|Removed |Added Attachment #178923|0 |1 is obsolete|| --- Comment #36 from Hammat wele --- Created attachment 179839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179839&action=edit Bug 21272: (follow-up) Terminology and formatting Change warning message to "..missing libraries...". Remove space before colon for the warning message. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele changed: What|Removed |Added Attachment #178924|0 |1 is obsolete|| --- Comment #37 from Hammat wele --- Created attachment 179840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179840&action=edit Bug 21272: (follow-up) using List::MoreUtils#any to get rid of %branches and fixing GetImportItemsBranches in ImportBatch.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele changed: What|Removed |Added Attachment #178921|0 |1 is obsolete|| --- Comment #34 from Hammat wele --- Created attachment 179837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179837&action=edit Bug 21272: MARC import should warn about mis-matched branch and item-type fields in 952 during staged import This plugin add a warning message to show missing branches during staged import, it also ignore item with wrong banches. To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches in a link 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele changed: What|Removed |Added Attachment #163648|0 |1 is obsolete|| --- Comment #30 from Hammat wele --- Created attachment 178925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178925&action=edit Bug 21272: Change warning message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #33 from Hammat wele --- Created attachment 178928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178928&action=edit Bug 21272: (follow-up) tidy code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele changed: What|Removed |Added Attachment #158683|0 |1 is obsolete|| --- Comment #29 from Hammat wele --- Created attachment 178924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178924&action=edit Bug 21272: (follow-up) using List::MoreUtils#any to get rid of %branches and fixing GetImportItemsBranches in ImportBatch.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele changed: What|Removed |Added Attachment #164149|0 |1 is obsolete|| --- Comment #32 from Hammat wele --- Created attachment 178927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178927&action=edit Bug 21272: Unit test for methods GetBadBranchesImportItems and GetTitleImportRecord -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele changed: What|Removed |Added Attachment #164148|0 |1 is obsolete|| --- Comment #31 from Hammat wele --- Created attachment 178926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178926&action=edit Bug 21272: Improve warning message To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches --> There is a warning message showing the titles of the wrong items 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele changed: What|Removed |Added Attachment #155525|0 |1 is obsolete|| --- Comment #28 from Hammat wele --- Created attachment 178923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178923&action=edit Bug 21272: (follow-up) Terminology and formatting Change warning message to "..missing libraries...". Remove space before colon for the warning message. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele changed: What|Removed |Added Attachment #155524|0 |1 is obsolete|| --- Comment #27 from Hammat wele --- Created attachment 178922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178922&action=edit Bug 21272: Unit test Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele changed: What|Removed |Added Attachment #155523|0 |1 is obsolete|| --- Comment #26 from Hammat wele --- Created attachment 178921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178921&action=edit Bug 21272: MARC import should warn about mis-matched branch and item-type fields in 952 during staged import This plugin add a warning message to show missing branches during staged import, it also ignore item with wrong banches. To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches in a link 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Miranda Nero changed: What|Removed |Added CC||mn...@oslri.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Caroline Cyr La Rose changed: What|Removed |Added Assignee|matthias.le-...@inlibro.com |hammat.w...@inlibro.com CC|matthias.le-...@inlibro.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #25 from Matthias Le Gac --- I tested with your file and the items that are good imported well and those with bad branches did not. For the record "Working effectively with legacy code" I have the item with homebranch "FPL" but not the item with homebranch "MPAL". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #24 from Matthias Le Gac --- Created attachment 164149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164149&action=edit Bug 21272: Unit test for methods GetBadBranchesImportItems and GetTitleImportRecord Current status: Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #23 from Matthias Le Gac --- (In reply to Esther Melander from comment #20) > I tested again and the error message is improved. It would be nice if the > error message was retained in some way so that it can be referenced again > after the import in the Manage Stage records for the file. > > Hammat's file works and the items with bad codes are ignored and the other > items are brought in. > > My import file contains bibliographic records with multiple items for each. > The error message was triggered correctly for the one item with a bad branch > code. However, none of the items were brought in. Ok I will check with your file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #22 from Matthias Le Gac --- (In reply to Matthias Le Gac from comment #21) > Created attachment 164148 [details] [review] > Bug 21272: Improve warning message > > To test > > Before make sure backgroundjobs process is running > (/misc/workers/background_jobs_worker.pl --queue long_tasks) > > 1- Go to Cataloging -> Stage records for import > 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or > homelibraary set and is not present in your installation > 3- Click on Stage for import > 4- Click on View batch > --> There is no message for the missing branches > 5- Click on "Import this batch into the catalog" > --> The importation failed > 6- Apply the patch > 7- Run prove -t t/db_dependent/ImportBatch.t > 8- Click on "Manage imported batch" > --> There is a warning message showing the missing branches > --> There is a warning message showing the titles of the wrong items > 9- Click on "Import this batch into the catalog" again > --> The records are imported > --> The items with wrong branches are ignored > > > Current status: Failed QA Just make tideness -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac changed: What|Removed |Added Attachment #164143|0 |1 is obsolete|| --- Comment #21 from Matthias Le Gac --- Created attachment 164148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164148&action=edit Bug 21272: Improve warning message To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches --> There is a warning message showing the titles of the wrong items 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored Current status: Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #20 from Esther Melander --- I tested again and the error message is improved. It would be nice if the error message was retained in some way so that it can be referenced again after the import in the Manage Stage records for the file. Hammat's file works and the items with bad codes are ignored and the other items are brought in. My import file contains bibliographic records with multiple items for each. The error message was triggered correctly for the one item with a bad branch code. However, none of the items were brought in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #19 from Esther Melander --- Created attachment 164147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164147&action=edit Import file with an attached items and bad branch code on one Here is the import file I tested with. Only one item on one bibliographic record has a bad branch code. That bibliographic record is Working effectively with legacy code, the first item has a branch code of MPAL instead of MPL. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #18 from Matthias Le Gac --- I have to add tests for the two new methods I added in Import.pm but tell me if the warning is better ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #17 from Matthias Le Gac --- Created attachment 164143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164143&action=edit Bug 21272: Improve warning message To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches --> There is a warning message showing the titles of the wrong items 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #16 from Matthias Le Gac --- Would it be possible for you to make the file you import available? Because when I run the test with the file provided by Hammat, it works correctly. I agree with you, I'll see if I can improve the display. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Esther Melander changed: What|Removed |Added CC||esther.melander@bywatersolu ||tions.com --- Comment #15 from Esther Melander --- I tested this. I had 5 bibliographic records with attached items. Each bibliographic record had multiple copies/items. I edited the first item on the first bibliographic record in the import file to have an incorrect branch code. When staging, I selected the option to always add the items. After staging the file, I received the warning that an item has an incorrect branchcode (nice!). I proceeded to import the file. None of the bibliographic records imported any items. I did not see a link in the warning message? I would have expected the one item with the incorrect branch code to be ignored. I could even expect the bibliographic record that contained this item would not have any items brought in. But I would expect the rest of the bibliographic records would import their items. It would be even more helpful if the warning message was more specific. If this was a large import file with a few hundred items, finding the one item with the bad branch code would be quite time consuming. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac changed: What|Removed |Added Attachment #163646|0 |1 is obsolete|| --- Comment #14 from Matthias Le Gac --- Created attachment 163648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163648&action=edit Bug 21272: Change warning message To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches in a link 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #13 from Matthias Le Gac --- Created attachment 163646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163646&action=edit Bug 21272: Change warning message To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches in a link 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac changed: What|Removed |Added Assignee|hammat.w...@inlibro.com |matthias.le-...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21272] MARC import should warn about mis-matched branch during staged import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac changed: What|Removed |Added Summary|MARC import should warn |MARC import should warn |about mis-matched branch|about mis-matched branch |and item-type fields in 952 |during staged import |during staged import| CC||matthias.le-...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
