[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Aude Charillon changed: What|Removed |Added Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #45 from Aude Charillon --- Koha Manual updated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks||39014 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39014 [Bug 39014] Storing a guarantee fails due to TrackLastPatronActivityTriggers "creating a patron" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Aude Charillon changed: What|Removed |Added CC||[email protected] ||.uk Documentation||Aude Charillon contact|| Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/1046 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Lucas Gass (lukeg) changed: What|Removed |Added Status|Pushed to main |Needs documenting --- Comment #44 from Lucas Gass (lukeg) --- Enhancement, no 24.05.x backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #43 from David Nind --- (In reply to Christofer Zorn from comment #42) > Thank you everyone! Is a backport possible to 24.05? I changed it from a normal bug to an enhancement (see comment #38). Bugs would normally be considered by the Release Maintainer for back porting, generally enhancements aren't. So the question is whether it is an enhancement or not: - Enhancement: adds to or improves a feature, but is not fixing something broken or not working as intended - Bug: something is broken or doesn't work as originally intended I'm not really sure for this one - I can see the case for both! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #42 from Christofer Zorn --- Thank you everyone! Is a backport possible to 24.05? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 David Nind changed: What|Removed |Added Text to go in the|This enhancement adds |This enhancement adds release notes|'Creating a patron' as an |'Creating a patron' as an |option for the |option to the |TrackLastPatronActivityTrig |TrackLastPatronActivityTrig |gers system preference -|gers system preference (for |for updating the last seen |updating the last seen |date. Previously, creating |date). Previously, creating |a patron was not an option |a patron was not an option |for updating the last seen |for updating the last seen |date - this could |date - this could |understate reports about|understate reports about |active patrons. |active patrons. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 David Nind changed: What|Removed |Added Text to go in the|This enhancement adds |This enhancement adds release notes|creating a patron as an |'Creating a patron' as an |option for updating the |option for the |last seen date when using |TrackLastPatronActivityTrig |the |gers system preference - |TrackLastPatronActivityTrig |for updating the last seen |gers system preference. |date. Previously, creating |Previously, creating a |a patron was not an option |patron was not an option|for updating the last seen |for updating the last seen |date - this could |date - this could |understate reports about |understate reports about|active patrons. |active patrons. | Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Katrin Fischer changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #41 from Katrin Fischer --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||24.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Martin Renvoize (ashimema) changed: What|Removed |Added QA Contact|[email protected]|martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #172928|0 |1 is obsolete|| --- Comment #40 from Martin Renvoize (ashimema) --- Created attachment 174081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174081&action=edit Bug 23486: (follow-up) Display text for new option Change display text for creation option from "Patron creation" to "Creating a patron" - for consistency with other values. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486
Martin Renvoize (ashimema) changed:
What|Removed |Added
Attachment #172927|0 |1
is obsolete||
--- Comment #39 from Martin Renvoize (ashimema)
---
Created attachment 174080
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174080&action=edit
Bug 23486: Add creation to TrackLasPatronActivity triggers
Some libraries would like to update the last seen when a patron is created to
avoid NULL
values and ensure new users are marked as 'active'
To test:
1 - Apply patch
2 - Create a new patron, confirm their lastseen date is null
SELECT lastseen FROM borrowers WHERE cardnumber={their cardnumber}
3 - Update preference 'TrackLastPatronActivity' to include 'Patron creation'
4 - Create a second patron, confirm their lastseen is set
5 - Update preference 'TrackLastPatronActivity' to include 'Checking out an
item'
6 - Checkout an item to the second patron
7 - Confirm their lastseen is not updated (We only update once per day)
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 David Nind changed: What|Removed |Added Text to go in the||This enhancement adds release notes||creating a patron as an ||option for updating the ||last seen date when using ||the ||TrackLastPatronActivityTrig ||gers system preference. ||Previously, creating a ||patron was not an option ||for updating the last seen ||date - this could ||understate reports about ||active patrons. Severity|normal |enhancement --- Comment #38 from David Nind --- I updated the display text for the new option to "Creating a patron" (instead of "Patron creation") for consistency with the other options (Checking out an item, Logging in, and so on). Feel free to remove the follow-up patch if you don't agree. I think this is an enhancement/improvement, so changed to an enhancement. But perhaps it should have tracked this from the start, so maybe is a bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #37 from David Nind --- Created attachment 172928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172928&action=edit Bug 23486: (follow-up) Display text for new option Change display text for creation option from "Patron creation" to "Creating a patron" - for consistency with other values. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486
David Nind changed:
What|Removed |Added
Attachment #172820|0 |1
is obsolete||
--- Comment #36 from David Nind ---
Created attachment 172927
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172927&action=edit
Bug 23486: Add creation to TrackLasPatronActivity triggers
Some libraries would like to update the last seen when a patron is created to
avoid NULL
values and ensure new users are marked as 'active'
To test:
1 - Apply patch
2 - Create a new patron, confirm their lastseen date is null
SELECT lastseen FROM borrowers WHERE cardnumber={their cardnumber}
3 - Update preference 'TrackLastPatronActivity' to include 'Patron creation'
4 - Create a second patron, confirm their lastseen is set
5 - Update preference 'TrackLastPatronActivity' to include 'Checking out an
item'
6 - Checkout an item to the second patron
7 - Confirm their lastseen is not updated (We only update once per day)
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #35 from Nick Clemens (kidclamp) --- (In reply to Owen Leonard from comment #33) > I keep getting an error when adding a patron. It seems only happen if I have > "Patron creation" checked under the TrackLastPatronActivity. > > When I fill out the patron creation form and submit I get an error message > at the top of the page, "The following fields are wrong. Please fix them." > But no fields are listed and no fields appear to be filled out incorrectly. updated_on was beign returned as 'current_timestamp', I had to add a refetch of the patron to ensure we got the value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486
Nick Clemens (kidclamp) changed:
What|Removed |Added
Attachment #171829|0 |1
is obsolete||
--- Comment #34 from Nick Clemens (kidclamp) ---
Created attachment 172820
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172820&action=edit
Bug 23486: Add creation to TrackLasPatronActivity triggers
Some libraries would like to update the last seen when a patron is created to
avoid NULL
values and ensure new users are marked as 'active'
To test:
1 - Apply patch
2 - Create a new patron, confirm their lastseen date is null
SELECT lastseen FROM borrowers WHERE cardnumber={their cardnumber}
3 - Update preference 'TrackLastPatronActivity' to include 'Patron creation'
4 - Create a second patron, confirm their lastseen is set
5 - Update preference 'TrackLastPatronActivity' to include 'Checking out an
item'
6 - Checkout an item to the second patron
7 - Confirm their lastseen is not updated (We only update once per day)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens (kidclamp) changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #33 from Owen Leonard --- I keep getting an error when adding a patron. It seems only happen if I have "Patron creation" checked under the TrackLastPatronActivity. When I fill out the patron creation form and submit I get an error message at the top of the page, "The following fields are wrong. Please fix them." But no fields are listed and no fields appear to be filled out incorrectly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23486] TrackLastPatronActivityTriggers should have an option for patron creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens (kidclamp) changed: What|Removed |Added Summary|Date last seen should be|TrackLastPatronActivityTrig |set upon registration |gers should have an option ||for patron creation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
