[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #43 from Jonathan Druart --- Opened bug 38300. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #42 from Katrin Fischer --- (In reply to Jonathan Druart from comment #41) > Why are we storing selected holds in localStorage? > > If we leave the page and come back the checkboxes are selected again, I > don't think it's the expected behaviour. Can someone confirm? I would not expect it to keep the checkboxes if I left the page and came back. To me it sounds a bit dangerous actually as this might get missed for a single checkbox hiding way down in a list for example. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #41 from Jonathan Druart --- Why are we storing selected holds in localStorage? If we leave the page and come back the checkboxes are selected again, I don't think it's the expected behaviour. Can someone confirm? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Katrin Fischer changed: What|Removed |Added CC||david.roberts@ptfs-europe.c ||om --- Comment #40 from Katrin Fischer --- *** Bug 28062 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Katrin Fischer changed: What|Removed |Added Blocks||31394 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31394 [Bug 31394] background hold cancellation causing confusion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Martin Renvoize changed: What|Removed |Added Blocks||30970 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970 [Bug 30970] holdst columns don't match actual columns in 'Holds waiting' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Joy Nelson changed: What|Removed |Added Text to go in the|This developments adds a|This developments adds a release notes|way to choose multiple |way to choose multiple |holds using checkboxes, to |holds using checkboxes, to |cancel them in bulk. |cancel them in bulk. | | |It |It |uses the new background |uses the new background |jobs infrastructure |jobs infrastructure |recently introduced.|recently introduced. || ||Sponsored by: Bedford ||Public Library, ||Hunstville-Madison County ||Library, Los Gatos Public ||Library, and Portsmouth ||Public Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Joy Nelson changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Jonathan Druart changed: What|Removed |Added Blocks||29969 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29969 [Bug 29969] Cannot update hold list after holds cancelled in bulk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Kyle M Hall changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Bug 23678 depends on bug 29149, which changed state. Bug 29149 Summary: Background job detail view needs more flexibility https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #39 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Jonathan Druart changed: What|Removed |Added Attachment #125629|0 |1 is obsolete|| --- Comment #38 from Jonathan Druart --- Created attachment 125631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125631&action=edit Bug 23678: Include file for batch_hold_cancel Use additional_report to retrieve patron and biblio's info. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #37 from Tomás Cohen Arazi --- Created attachment 125629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125629&action=edit Bug 23678: Include file for batch_hold_cancel Use additional_report to retrieve patron and biblio's info. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #36 from Tomás Cohen Arazi --- Created attachment 125628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125628&action=edit Bug 23678: Don't display code of the job type Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #35 from Tomás Cohen Arazi --- Created attachment 125627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125627&action=edit Bug 23678: Allow cancel holds in bulk This patch allows staff patrons to cancel multiple holds in bulk. To test: 1. Apply this patch 2. restart_all 3. In cataloge go to a book and place many holds CHECK => Holds table shows a column of checkboxes 4. Play with checkboxes (have some fun ;-P) CHECK => When you manually check all checkboxes, the checkbox in the header also gets checked. => When you uncheck one of the checkboxes, the one in the header also gets unchecked. => If no checkbox is checked and you check the one in the header, all checkboxes get checked. => If there are some checkboxes that are checked and others are not, when you click on the checkbox in the header all checkboxes get unchecked. => If all checkboxes are checked, when you uncheck the one in the header, all checkboxes get unchecked. => Every time you play with checkboxes, the number in the button "Cancel selected" changes. 5. Check some of the checkboxes and click on cancel selected. SUCCESS => A background job gets fired to cancel all selected holds. => A message should appear with a link to the job. 6. Wait a few seconds and click on the link SUCCESS => A message appears with the report of the execution of the background job. 7. Grab a patron and search to hold 8. Select multiple biblios and click on "place hold for " CHECK => After holds are confirmed, multiple holds table are shown.. one for each record. Checkboxes work exactly the same as before, but scoped for each individual table. Checkboxes from one table will not affect checkboxes from other tables. 9. Repeat steps 4 to 6. 10. Check In some of the items so the get in Waiting state. 11. Update expirationdate os some of those holds and set it to ReservesMaxPickUpDelay + 1 days earlier NOTE => ReservesMaxPickUpDelay = 7 days by default, so sql syntax to update would be => update reserves set expirationdate = date_sub(expirationdate, interval 8 day) where reserve_id in (...) 12. Repeat steps 4 to 6 but in waitingreserves.pl, in both tabs. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Bug 23678: (QA follow-up) Add missing template filter Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Bug 23678: (QA follow-up) Add missing filters Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Bug 23678: (QA follow-up) Use correct indentation Signed-off-by: Tomas Cohen Arazi JD amended patch: also Koha/BackgroundJob/BatchCancelHold.pm JD Amended patch: Full rebase and adjustements made on top of bug 26080. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125590|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125589|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What|Removed |Added Attachment #125600|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.druart+koha@gmail. |agustinmoy...@theke.io |com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Signed Off --- Comment #34 from Jonathan Druart --- Tomas, have a look at the current version and the dependent bugs. I moved code out of bug 28445 to reuse it here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #33 from Jonathan Druart --- Created attachment 125600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125600&action=edit Bug 23678: Include file for batch_hold_cancel Use additional_report to retrieve patron and biblio's info. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #32 from Jonathan Druart --- 99 error=> defined $hold 100 ? ( $@ ? $@ : 0 ) 101 : 'No hold with id ' . $hold_id . ' found', Caught a non translatable error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #31 from Jonathan Druart --- Patches rebased and reworked on top of bug 26080 (PQA for a month already). It refactored some of the background job code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Jonathan Druart changed: What|Removed |Added Attachment #125579|0 |1 is obsolete|| --- Comment #30 from Jonathan Druart --- Created attachment 125590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125590&action=edit Bug 23678: Don't display code of the job type -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Jonathan Druart changed: What|Removed |Added Attachment #125578|0 |1 is obsolete|| --- Comment #29 from Jonathan Druart --- Created attachment 125589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125589&action=edit Bug 23678: Allow cancel holds in bulk This patch allows staff patrons to cancel multiple holds in bulk. To test: 1. Apply this patch 2. restart_all 3. In cataloge go to a book and place many holds CHECK => Holds table shows a column of checkboxes 4. Play with checkboxes (have some fun ;-P) CHECK => When you manually check all checkboxes, the checkbox in the header also gets checked. => When you uncheck one of the checkboxes, the one in the header also gets unchecked. => If no checkbox is checked and you check the one in the header, all checkboxes get checked. => If there are some checkboxes that are checked and others are not, when you click on the checkbox in the header all checkboxes get unchecked. => If all checkboxes are checked, when you uncheck the one in the header, all checkboxes get unchecked. => Every time you play with checkboxes, the number in the button "Cancel selected" changes. 5. Check some of the checkboxes and click on cancel selected. SUCCESS => A background job gets fired to cancel all selected holds. => A message should appear with a link to the job. 6. Wait a few seconds and click on the link SUCCESS => A message appears with the report of the execution of the background job. 7. Grab a patron and search to hold 8. Select multiple biblios and click on "place hold for " CHECK => After holds are confirmed, multiple holds table are shown.. one for each record. Checkboxes work exactly the same as before, but scoped for each individual table. Checkboxes from one table will not affect checkboxes from other tables. 9. Repeat steps 4 to 6. 10. Check In some of the items so the get in Waiting state. 11. Update expirationdate os some of those holds and set it to ReservesMaxPickUpDelay + 1 days earlier NOTE => ReservesMaxPickUpDelay = 7 days by default, so sql syntax to update would be => update reserves set expirationdate = date_sub(expirationdate, interval 8 day) where reserve_id in (...) 12. Repeat steps 4 to 6 but in waitingreserves.pl, in both tabs. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Bug 23678: (QA follow-up) Add missing template filter Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Bug 23678: (QA follow-up) Add missing filters Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Bug 23678: (QA follow-up) Use correct indentation Signed-off-by: Tomas Cohen Arazi JD amended patch: also Koha/BackgroundJob/BatchCancelHold.pm JD Amended patch: Full rebase and adjustements made on top of bug 26080. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Jonathan Druart changed: What|Removed |Added Status|In Discussion |ASSIGNED Depends on||29149 Assignee|agustinmoy...@theke.io |jonathan.druart+koha@gmail. ||com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29149 [Bug 29149] Background job detail view needs more flexibility -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #28 from Jonathan Druart --- Created attachment 125579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125579&action=edit Bug 23678: Don't display code of the job type -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #27 from Jonathan Druart --- Patches squashed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Jonathan Druart changed: What|Removed |Added Attachment #125404|0 |1 is obsolete|| Attachment #125405|0 |1 is obsolete|| Attachment #125406|0 |1 is obsolete|| Attachment #125577|0 |1 is obsolete|| --- Comment #26 from Jonathan Druart --- Created attachment 125578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125578&action=edit Bug 23678: Allow cancel holds in bulk This patch allows staff patrons to cancel multiple holds in bulk. To test: 1. Apply this patch 2. restart_all 3. In cataloge go to a book and place many holds CHECK => Holds table shows a column of checkboxes 4. Play with checkboxes (have some fun ;-P) CHECK => When you manually check all checkboxes, the checkbox in the header also gets checked. => When you uncheck one of the checkboxes, the one in the header also gets unchecked. => If no checkbox is checked and you check the one in the header, all checkboxes get checked. => If there are some checkboxes that are checked and others are not, when you click on the checkbox in the header all checkboxes get unchecked. => If all checkboxes are checked, when you uncheck the one in the header, all checkboxes get unchecked. => Every time you play with checkboxes, the number in the button "Cancel selected" changes. 5. Check some of the checkboxes and click on cancel selected. SUCCESS => A background job gets fired to cancel all selected holds. => A message should appear with a link to the job. 6. Wait a few seconds and click on the link SUCCESS => A message appears with the report of the execution of the background job. 7. Grab a patron and search to hold 8. Select multiple biblios and click on "place hold for " CHECK => After holds are confirmed, multiple holds table are shown.. one for each record. Checkboxes work exactly the same as before, but scoped for each individual table. Checkboxes from one table will not affect checkboxes from other tables. 9. Repeat steps 4 to 6. 10. Check In some of the items so the get in Waiting state. 11. Update expirationdate os some of those holds and set it to ReservesMaxPickUpDelay + 1 days earlier NOTE => ReservesMaxPickUpDelay = 7 days by default, so sql syntax to update would be => update reserves set expirationdate = date_sub(expirationdate, interval 8 day) where reserve_id in (...) 12. Repeat steps 4 to 6 but in waitingreserves.pl, in both tabs. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Bug 23678: (QA follow-up) Add missing template filter Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Bug 23678: (QA follow-up) Add missing filters Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Bug 23678: (QA follow-up) Use correct indentation Signed-off-by: Tomas Cohen Arazi JD amended patch: also Koha/BackgroundJob/BatchCancelHold.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Jonathan Druart changed: What|Removed |Added Attachment #125470|0 |1 is obsolete|| --- Comment #25 from Jonathan Druart --- Created attachment 125577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125577&action=edit Bug 23678: (QA follow-up) Use correct indentation Signed-off-by: Tomas Cohen Arazi JD amended patch: also Koha/BackgroundJob/BatchCancelHold.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail.
||com
Status|Passed QA |In Discussion
--- Comment #24 from Jonathan Druart ---
1. I don't understand why we pass patron_name when we have the patron_id (same
for biblio_title).
If you modify the patron's name, the name won't match.
If you cannot do it now, you may need Koha::BackgroundJob->additional_report
from "Bug 28445: Add the capability to provide more info to the background job
detail view"
2.
+push @messages, {
+type => 'error',
+code => 'hold_not_cancelled',
+patron_id => defined $patron?$patron->borrowernumber:'',
+patron_name => defined
$patron?($patron->firstname?$patron->firstname.', ':'').$patron->surname:'',
+biblio_id => defined $biblio?$biblio->biblionumber:'',
+biblio_title => defined $biblio?$biblio->title:'',
+hold_id => $hold_id,
+error => defined $hold?($@ ? $@ : 0):'No hold with id
'.$hold_id.' found',
+};
Erk, spaces, indentation? I can fix that.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What|Removed |Added Text to go in the||This developments adds a release notes||way to choose multiple ||holds using checkboxes, to ||cancel them in bulk. || ||It ||uses the new background ||jobs infrastructure ||recently introduced. Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 125470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125470&action=edit Bug 23678: (QA follow-up) Use correct indentation Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #22 from Martin Renvoize --- This works as expected and passes QA scripts. I can't see any evidence of previous background jobs having associated tests so the lack of a unit test here seems reasonable.. but it did make me wonder. Passing QA and differing to RM regards tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Martin Renvoize changed: What|Removed |Added Attachment #123187|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 125406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125406&action=edit Bug 23678: (QA follow-up) Add missing filters Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Martin Renvoize changed: What|Removed |Added Attachment #123186|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize --- Created attachment 125405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125405&action=edit Bug 23678: (QA follow-up) Add missing template filter Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Martin Renvoize changed: What|Removed |Added Attachment #123185|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 125404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125404&action=edit Bug 23678: Allow cancel holds in bulk This patch allows staff patrons to cancel multiple holds in bulk. To test: 1. Apply this patch 2. restart_all 3. In cataloge go to a book and place many holds CHECK => Holds table shows a column of checkboxes 4. Play with checkboxes (have some fun ;-P) CHECK => When you manually check all checkboxes, the checkbox in the header also gets checked. => When you uncheck one of the checkboxes, the one in the header also gets unchecked. => If no checkbox is checked and you check the one in the header, all checkboxes get checked. => If there are some checkboxes that are checked and others are not, when you click on the checkbox in the header all checkboxes get unchecked. => If all checkboxes are checked, when you uncheck the one in the header, all checkboxes get unchecked. => Every time you play with checkboxes, the number in the button "Cancel selected" changes. 5. Check some of the checkboxes and click on cancel selected. SUCCESS => A background job gets fired to cancel all selected holds. => A message should appear with a link to the job. 6. Wait a few seconds and click on the link SUCCESS => A message appears with the report of the execution of the background job. 7. Grab a patron and search to hold 8. Select multiple biblios and click on "place hold for " CHECK => After holds are confirmed, multiple holds table are shown.. one for each record. Checkboxes work exactly the same as before, but scoped for each individual table. Checkboxes from one table will not affect checkboxes from other tables. 9. Repeat steps 4 to 6. 10. Check In some of the items so the get in Waiting state. 11. Update expirationdate os some of those holds and set it to ReservesMaxPickUpDelay + 1 days earlier NOTE => ReservesMaxPickUpDelay = 7 days by default, so sql syntax to update would be => update reserves set expirationdate = date_sub(expirationdate, interval 8 day) where reserve_id in (...) 12. Repeat steps 4 to 6 but in waitingreserves.pl, in both tabs. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #18 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #14) > Requires another follow-up: Done, thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 123187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123187&action=edit Bug 23678: (QA follow-up) Add missing filters Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 123186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123186&action=edit Bug 23678: (QA follow-up) Add missing template filter Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 123185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123185&action=edit Bug 23678: Allow cancel holds in bulk This patch allows staff patrons to cancel multiple holds in bulk. To test: 1. Apply this patch 2. restart_all 3. In cataloge go to a book and place many holds CHECK => Holds table shows a column of checkboxes 4. Play with checkboxes (have some fun ;-P) CHECK => When you manually check all checkboxes, the checkbox in the header also gets checked. => When you uncheck one of the checkboxes, the one in the header also gets unchecked. => If no checkbox is checked and you check the one in the header, all checkboxes get checked. => If there are some checkboxes that are checked and others are not, when you click on the checkbox in the header all checkboxes get unchecked. => If all checkboxes are checked, when you uncheck the one in the header, all checkboxes get unchecked. => Every time you play with checkboxes, the number in the button "Cancel selected" changes. 5. Check some of the checkboxes and click on cancel selected. SUCCESS => A background job gets fired to cancel all selected holds. => A message should appear with a link to the job. 6. Wait a few seconds and click on the link SUCCESS => A message appears with the report of the execution of the background job. 7. Grab a patron and search to hold 8. Select multiple biblios and click on "place hold for " CHECK => After holds are confirmed, multiple holds table are shown.. one for each record. Checkboxes work exactly the same as before, but scoped for each individual table. Checkboxes from one table will not affect checkboxes from other tables. 9. Repeat steps 4 to 6. 10. Check In some of the items so the get in Waiting state. 11. Update expirationdate os some of those holds and set it to ReservesMaxPickUpDelay + 1 days earlier NOTE => ReservesMaxPickUpDelay = 7 days by default, so sql syntax to update would be => update reserves set expirationdate = date_sub(expirationdate, interval 8 day) where reserve_id in (...) 12. Repeat steps 4 to 6 but in waitingreserves.pl, in both tabs. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What|Removed |Added Attachment #120265|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What|Removed |Added Attachment #118553|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Katrin Fischer changed: What|Removed |Added Summary|Cancel Holds in bulk|Cancel holds in bulk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #14 from Katrin Fischer --- Requires another follow-up: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt FAIL filters missing_filter at line 180 ( Hold on [% m.biblio_title | html %] for [% m.patron_name %] has successfully been cancelled.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What|Removed |Added QA Contact||testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|k...@bywatersolutions.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #13 from Kyle M Hall --- Created attachment 120265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120265&action=edit Bug 23678: (QA follow-up) Add missing template filter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Barbara Johnson changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #12 from Barbara Johnson --- Everything worked great. Also checked to make sure that if a title had several holds that using the bulk cancel did not impact the rest of the holds queue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #11 from Agustín Moyano --- (In reply to Barbara Johnson from comment #7) > Hi Agustín - I tested this and it works great. However, the functionality > is tied to cancelling holds on a queue for an individual title. I actually > just submitted a bug for that - #27922. > > This bug states that it should allow cancellation of selected holds via > checkboxes from the 'holds waiting over xx days' tab on waitingreserves.pl. > So while the patch works great I don't think it address the original > intention of this bug. Hi Barbara, could you please try once again? Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Agustín Moyano changed: What|Removed |Added Attachment #118338|0 |1 is obsolete|| --- Comment #10 from Agustín Moyano --- Created attachment 118553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118553&action=edit Bug 23678: Allow cancel holds in bulk This patch allows staff patrons to cancel multiple holds in bulk. To test: 1. Apply this patch 2. restart_all 3. In cataloge go to a book and place many holds CHECK => Holds table shows a column of checkboxes 4. Play with checkboxes (have some fun ;-P) CHECK => When you manually check all checkboxes, the checkbox in the header also gets checked. => When you uncheck one of the checkboxes, the one in the header also gets unchecked. => If no checkbox is checked and you check the one in the header, all checkboxes get checked. => If there are some checkboxes that are checked and others are not, when you click on the checkbox in the header all checkboxes get unchecked. => If all checkboxes are checked, when you uncheck the one in the header, all checkboxes get unchecked. => Every time you play with checkboxes, the number in the button "Cancel selected" changes. 5. Check some of the checkboxes and click on cancel selected. SUCCESS => A background job gets fired to cancel all selected holds. => A message should appear with a link to the job. 6. Wait a few seconds and click on the link SUCCESS => A message appears with the report of the execution of the background job. 7. Grab a patron and search to hold 8. Select multiple biblios and click on "place hold for " CHECK => After holds are confirmed, multiple holds table are shown.. one for each record. Checkboxes work exactly the same as before, but scoped for each individual table. Checkboxes from one table will not affect checkboxes from other tables. 9. Repeat steps 4 to 6. 10. Check In some of the items so the get in Waiting state. 11. Update expirationdate os some of those holds and set it to ReservesMaxPickUpDelay + 1 days earlier NOTE => ReservesMaxPickUpDelay = 7 days by default, so sql syntax to update would be => update reserves set expirationdate = date_sub(expirationdate, interval 8 day) where reserve_id in (...) 12. Repeat steps 4 to 6 but in waitingreserves.pl, in both tabs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #9 from Agustín Moyano --- *** Bug 27922 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #8 from Agustín Moyano --- (In reply to Barbara Johnson from comment #7) > Hi Agustín - I tested this and it works great. However, the functionality > is tied to cancelling holds on a queue for an individual title. I actually > just submitted a bug for that - #27922. > > This bug states that it should allow cancellation of selected holds via > checkboxes from the 'holds waiting over xx days' tab on waitingreserves.pl. > So while the patch works great I don't think it address the original > intention of this bug. Thanks Barbara.. I'm such a dummy! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #7 from Barbara Johnson --- Hi Agustín - I tested this and it works great. However, the functionality is tied to cancelling holds on a queue for an individual title. I actually just submitted a bug for that - #27922. This bug states that it should allow cancellation of selected holds via checkboxes from the 'holds waiting over xx days' tab on waitingreserves.pl. So while the patch works great I don't think it address the original intention of this bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #6 from Agustín Moyano --- Created attachment 118338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118338&action=edit Bug 23678: Allow cancel holds in bulk This patch allows staff patrons to cancel multiple holds in bulk. To test: 1. Apply this patch 2. restart_all 3. In cataloge go to a book and place many holds CHECK => Holds table shows a column of checkboxes 4. Play with checkboxes (have some fun ;-P) CHECK => When you manually check all checkboxes, the checkbox in the header also gets checked. => When you uncheck one of the checkboxes, the one in the header also gets unchecked. => If no checkbox is checked and you check the one in the header, all checkboxes get checked. => If there are some checkboxes that are checked and others are not, when you click on the checkbox in the header all checkboxes get unchecked. => If all checkboxes are checked, when you uncheck the one in the header, all checkboxes get unchecked. => Every time you play with checkboxes, the number in the button "Cancel selected" changes. 5. Check some of the checkboxes and click on cancel selected. SUCCESS => A background job gets fired to cancel all selected holds. => A message should appear with a link to the job. 6. Wait a few seconds and click on the link SUCCESS => A message appears with the report of the execution of the background job. 7. Grab a patron and search to hold 8. Select multiple biblios and click on "place hold for " CHECK => After holds are confirmed, multiple holds table are shown.. one for each record. Checkboxes work exactly the same as before, but scoped for each individual table. Checkboxes from one table will not affect checkboxes from other tables. 9. Repeat steps 4 to 6. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Agustín Moyano changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 --- Comment #5 from Benjamin Daeuber --- (In reply to Benjamin Daeuber from comment #4) > Not that I'm opposed to batch action on holds, but is that strictly required > for this development? We'd likely go through and check everything in anyway > since there might be other transfers, materials specified notes or whatever > to deal with. Ah, never mind. I think I see what you mean here. The bulk action for canceling the holds. I was sidetracked by a discussion on triggering multiple holds at one time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Benjamin Daeuber changed: What|Removed |Added CC||bdaeu...@cityoffargo.com --- Comment #4 from Benjamin Daeuber --- Not that I'm opposed to batch action on holds, but is that strictly required for this development? We'd likely go through and check everything in anyway since there might be other transfers, materials specified notes or whatever to deal with. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Cheryl changed: What|Removed |Added CC||clack...@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org --- Comment #3 from Christopher Brannon --- (In reply to Joy Nelson from comment #0) > Allow staff a way to cancel more than one hold at a time. > Provide checkboxes on holds waiting over tab and allow staff to select > multiple holds and cancel those selected holds. +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24599 --- Comment #2 from Tomás Cohen Arazi --- Linking to bug 24599, as we need a spec for batch actions on holds, including cancelling them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |agustinmoy...@theke.io |ity.org | CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Michelle Carrillo changed: What|Removed |Added CC||mcarri...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel Holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Martha Fuerst changed: What|Removed |Added CC||mfue...@hmcpl.org --- Comment #1 from Martha Fuerst --- Chiming in with a YES PLEASE from Huntsville-Madison County Public Library. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
