[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for (scrubbed) HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 David Cook changed: What|Removed |Added CC||[email protected] ||om --- Comment #23 from David Cook --- *** Bug 41529 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for (scrubbed) HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 --- Comment #22 from David Cook --- (In reply to David Nind from comment #21) > (In reply to David Cook from comment #20) > > (In reply to David Nind from comment #18) > > > I had a go at a release note, but I'm not sure that I got what this does > > > right. > > > > > > Some things I noticed - should these be separate bugs? > > > > > > 1. In the table listing saved reports, the HTML code is shown in the notes > > > column. > > > > > > 2. When you view the report (list of reports > Actions > View), the notes > > > text is all over the place: > > >- The "Notes" label is indented > > >- None of the note text is aligned properly, even if you use paragraph > > > tags for every line in the note > > > > > > 3. When you run the report, the notes text is formatted correctly above > > > the > > > report results (as expected). > > > > Just noticed your comments now, David. Are these bugs still valid? > > Just tested, and they still exist. Yeah I think those should probably be separate bug reports. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for (scrubbed) HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 --- Comment #21 from David Nind --- (In reply to David Cook from comment #20) > (In reply to David Nind from comment #18) > > I had a go at a release note, but I'm not sure that I got what this does > > right. > > > > Some things I noticed - should these be separate bugs? > > > > 1. In the table listing saved reports, the HTML code is shown in the notes > > column. > > > > 2. When you view the report (list of reports > Actions > View), the notes > > text is all over the place: > >- The "Notes" label is indented > >- None of the note text is aligned properly, even if you use paragraph > > tags for every line in the note > > > > 3. When you run the report, the notes text is formatted correctly above the > > report results (as expected). > > Just noticed your comments now, David. Are these bugs still valid? Just tested, and they still exist. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for (scrubbed) HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 --- Comment #20 from David Cook --- (In reply to David Nind from comment #18) > I had a go at a release note, but I'm not sure that I got what this does > right. > > Some things I noticed - should these be separate bugs? > > 1. In the table listing saved reports, the HTML code is shown in the notes > column. > > 2. When you view the report (list of reports > Actions > View), the notes > text is all over the place: >- The "Notes" label is indented >- None of the note text is aligned properly, even if you use paragraph > tags for every line in the note > > 3. When you run the report, the notes text is formatted correctly above the > report results (as expected). Just noticed your comments now, David. Are these bugs still valid? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for (scrubbed) HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Lucas Gass (lukeg) changed: What|Removed |Added Keywords|rel_25_11_candidate | CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for (scrubbed) HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Ray Delahunty changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=41529 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for (scrubbed) HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Baptiste Wojtkowski (bwoj) changed: What|Removed |Added CC||baptiste.wojtkowski@biblibr ||e.com Status|Pushed to stable|Needs documenting --- Comment #19 from Baptiste Wojtkowski (bwoj) --- Enhancement, not backported to 24.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for (scrubbed) HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 David Nind changed: What|Removed |Added Text to go in the||This enhancement to the release notes||notes field for saved SQL ||reports now allows the use ||of selected HTML in the ||field. CC||[email protected] --- Comment #18 from David Nind --- I had a go at a release note, but I'm not sure that I got what this does right. Some things I noticed - should these be separate bugs? 1. In the table listing saved reports, the HTML code is shown in the notes column. 2. When you view the report (list of reports > Actions > View), the notes text is all over the place: - The "Notes" label is indented - None of the note text is aligned properly, even if you use paragraph tags for every line in the note 3. When you run the report, the notes text is formatted correctly above the report results (as expected). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for (scrubbed) HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Paul Derscheid changed: What|Removed |Added Status|Pushed to main |Pushed to stable Version(s)|25.11.00|25.11.00,25.05.01 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for (scrubbed) HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 --- Comment #17 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x for 25.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for (scrubbed) HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Mirjam Vantieghem changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=40079 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for (scrubbed) HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 --- Comment #16 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for (scrubbed) HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for (scrubbed) HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Katrin Fischer changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for (scrubbed) HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Katrin Fischer changed: What|Removed |Added Keywords||rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for (scrubbed) HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 David Cook changed: What|Removed |Added QA Contact|[email protected] |[email protected] |o.uk| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for (scrubbed) HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 David Cook changed: What|Removed |Added Attachment #182642|0 |1 is obsolete|| --- Comment #15 from David Cook --- Created attachment 182644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182644&action=edit Bug 23978: (QA follow-up) Use html_scrubber This followup replaces the $raw filter with `scrub_html type => 'note' | $raw`. Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for (scrubbed) HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 David Cook changed: What|Removed |Added Attachment #182627|0 |1 is obsolete|| --- Comment #14 from David Cook --- Created attachment 182643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182643&action=edit Bug 23978: Expose HTML in Reports This patch updates the notes field to a $raw filter to prevent html escaping of the data within it. Signed-off-by: Martin Renvoize Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23978] Notes field in saved reports should allow for (scrubbed) HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 David Cook changed: What|Removed |Added Summary|Notes field in saved|Notes field in saved |reports should allow for|reports should allow for |HTML|(scrubbed) HTML -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
