[Koha-bugs] [Bug 25947] Improve locked account message in brief patron info in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25947 Wainui Witika-Park changed: What|Removed |Added Status|Pushed to stable|Needs documenting --- Comment #56 from Wainui Witika-Park --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25947] Improve locked account message in brief patron info in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25947 Fridolin Somers changed: What|Removed |Added Version(s)|25.05.00|25.05.00,24.11.08 released in|| Status|Pushed to main |Pushed to stable --- Comment #55 from Fridolin Somers --- Nice little enhancement, I backport Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25947] Improve locked account message in brief patron info in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25947 --- Comment #54 from Katrin Fischer --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25947] Improve locked account message in brief patron info in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25947 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25947] Improve locked account message in brief patron info in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25947 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=39686 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25947] Improve locked account message in brief patron info in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25947 Baptiste Wojtkowski (bwoj) changed: What|Removed |Added Attachment #178534|0 |1 is obsolete|| --- Comment #48 from Baptiste Wojtkowski (bwoj) --- Created attachment 179483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179483&action=edit Bug 25947: Improve locked account message When using system preference 'FailedLoginAttempts', a patron's account is blocked after X many failed login attempts on the OPAC. This patch adds, like for "Patron's card has expired" message : * a message "Patron's account has been locked (due to X failed login attempts)" on the patron details and circulation pages * a link to change password Links are only displayed if libarian has permission to edit patrons. For administrative lock, only a message is displayed : "Patron's account has been administratively locked" To test: 1. Change system preference 'FailedLoginAttempts' to a small number, like 2 2. Go to a patron's account and copy their username (while you're there, change the password and add some fines, too) 3. In the OPAC, try to log in with the username and a wrong password 3 times 4. Go back to the patron's account in the staff interface 5. Note that there is a message : "Patron's account has been locked (due to 3 failed login attempts)" 6. Click on "Change password", you go to change password page Signed-off-by: Roman Dolny -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25947] Improve locked account message in brief patron info in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25947 Baptiste Wojtkowski (bwoj) changed: What|Removed |Added Attachment #178536|0 |1 is obsolete|| --- Comment #50 from Baptiste Wojtkowski (bwoj) --- Created attachment 179485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179485&action=edit Bug 25947: (follow-up) Tidiness fix -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25947] Improve locked account message in brief patron info in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25947 Emily Lamancusa (emlam) changed: What|Removed |Added Attachment #179484|0 |1 is obsolete|| --- Comment #52 from Emily Lamancusa (emlam) --- Created attachment 180568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180568&action=edit Bug 25947: (follow-up) Improve locked account message Test plan: To test: 1. Change system preference 'FailedLoginAttempts' to a small number, like 2 2. Go to a patron's account and copy their username (while you're there, change the password and add some fines, too) 3. In the OPAC, try to log in with the username and a wrong password 3 times 4. Go back to the patron's account in the staff interface 5. Note that there is a message : "Patron's account has been locked (due to 3 failed login attempts)". Note there is a tooltip at the right 6. Click on "Change password", you go to change password page Note: the follow-up might be unclear to understand: 1 - it moves the button outside the IF patron.login_attempt < 0 2 - Hence it requires the to be moved out so button remains on the lane 3 - Finally the must be put before the if and changed a bit Signed-off-by: Imani Thomas Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25947] Improve locked account message in brief patron info in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25947 Emily Lamancusa (emlam) changed: What|Removed |Added Status|Signed Off |Passed QA CC||emily.lamancusa@montgomeryc ||ountymd.gov QA Contact|[email protected]|emily.lamancusa@montgomeryc ||ountymd.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25947] Improve locked account message in brief patron info in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25947 Emily Lamancusa (emlam) changed: What|Removed |Added Attachment #179483|0 |1 is obsolete|| --- Comment #51 from Emily Lamancusa (emlam) --- Created attachment 180567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180567&action=edit Bug 25947: Improve locked account message When using system preference 'FailedLoginAttempts', a patron's account is blocked after X many failed login attempts on the OPAC. This patch adds, like for "Patron's card has expired" message : * a message "Patron's account has been locked (due to X failed login attempts)" on the patron details and circulation pages * a link to change password Links are only displayed if libarian has permission to edit patrons. For administrative lock, only a message is displayed : "Patron's account has been administratively locked" To test: 1. Change system preference 'FailedLoginAttempts' to a small number, like 2 2. Go to a patron's account and copy their username (while you're there, change the password and add some fines, too) 3. In the OPAC, try to log in with the username and a wrong password 3 times 4. Go back to the patron's account in the staff interface 5. Note that there is a message : "Patron's account has been locked (due to 3 failed login attempts)" 6. Click on "Change password", you go to change password page Signed-off-by: Roman Dolny Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25947] Improve locked account message in brief patron info in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25947 Emily Lamancusa (emlam) changed: What|Removed |Added Attachment #179485|0 |1 is obsolete|| --- Comment #53 from Emily Lamancusa (emlam) --- Created attachment 180569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180569&action=edit Bug 25947: (follow-up) Tidiness fix Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25947] Improve locked account message in brief patron info in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25947 Baptiste Wojtkowski (bwoj) changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25947] Improve locked account message in brief patron info in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25947 Thibault Keromnès changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||thibault.keromnes@univ-pari ||s8.fr --- Comment #47 from Thibault Keromnès --- error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25947] Improve locked account message in brief patron info in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25947 Baptiste Wojtkowski (bwoj) changed: What|Removed |Added Attachment #179441|0 |1 is obsolete|| --- Comment #49 from Baptiste Wojtkowski (bwoj) --- Created attachment 179484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179484&action=edit Bug 25947: (follow-up) Improve locked account message Test plan: To test: 1. Change system preference 'FailedLoginAttempts' to a small number, like 2 2. Go to a patron's account and copy their username (while you're there, change the password and add some fines, too) 3. In the OPAC, try to log in with the username and a wrong password 3 times 4. Go back to the patron's account in the staff interface 5. Note that there is a message : "Patron's account has been locked (due to 3 failed login attempts)". Note there is a tooltip at the right 6. Click on "Change password", you go to change password page Note: the follow-up might be unclear to understand: 1 - it moves the button outside the IF patron.login_attempt < 0 2 - Hence it requires the to be moved out so button remains on the lane 3 - Finally the must be put before the if and changed a bit Signed-off-by: Imani Thomas -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25947] Improve locked account message in brief patron info in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25947 Baptiste Wojtkowski (bwoj) changed: What|Removed |Added Attachment #178535|0 |1 is obsolete|| --- Comment #45 from Baptiste Wojtkowski (bwoj) --- Created attachment 179441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179441&action=edit Bug 25947: (follow-up) Improve locked account message Test plan: To test: 1. Change system preference 'FailedLoginAttempts' to a small number, like 2 2. Go to a patron's account and copy their username (while you're there, change the password and add some fines, too) 3. In the OPAC, try to log in with the username and a wrong password 3 times 4. Go back to the patron's account in the staff interface 5. Note that there is a message : "Patron's account has been locked (due to 3 failed login attempts)". Note there is a tooltip at the right 6. Click on "Change password", you go to change password page Note: the follow-up might be unclear to understand: 1 - it moves the button outside the IF patron.login_attempt < 0 2 - Hence it requires the to be moved out so button remains on the lane 3 - Finally the must be put before the if and changed a bit Signed-off-by: Imani Thomas -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25947] Improve locked account message in brief patron info in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25947 --- Comment #46 from Baptiste Wojtkowski (bwoj) --- Span without content was incorrectly introduced with , which breaks Bug 37512, I simply removed it and added a , letting in SO status -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25947] Improve locked account message in brief patron info in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25947 Katrin Fischer changed: What|Removed |Added Summary|Improve locked account |Improve locked account |message in the staff|message in brief patron |interface |info in staff interface --- Comment #44 from Katrin Fischer --- I changed it because the message shows on all pages of the patron account, not only the patron detail page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
