[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2025-01-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@gmail.com

--- Comment #26 from Jonathan Druart  ---
Missing tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2024-12-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

--- Comment #25 from Julian Maurice  ---
(In reply to Owen Leonard from comment #20)
> Julian I hope my follow-up works for you and your sponsor.
I think it's okay as we can have the list of late issues by clicking on the
link

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2024-12-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

--- Comment #24 from David Nind  ---
One thought I had when testing, if a library has "hundreds" of late serials,
then this would overwhelm the front page alert - or make it very long.

I'm not sure how realistic this is, but maybe this could with academic
libraries or public libraries with lots of magazines?

I really like this enhancement!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2024-12-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
  Text to go in the||This enhancement to serials
  release notes||adds a "Warn when late"
   ||option for a serial. If
   ||this is enabled for a
   ||serial, an alert is shown
   ||on the main page when
   ||issues are late.

--- Comment #23 from David Nind  ---
Testing notes (using KTD):

1. Step 1: run updatedatabase, dbic, then restart_all

2. Before I could sign off, I had to do a: git checkout
Koha/Schema/Result/Subscription.pm (I don't think I've had to do that in the
past)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2024-12-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

David Nind  changed:

   What|Removed |Added

 Attachment #175468|0   |1
is obsolete||

--- Comment #22 from David Nind  ---
Created attachment 175475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175475&action=edit
Bug 29996: (follow-up) Show count of late issues instead of list

This patch makes two changes:
1. Change the label to "The following serials have late issues:"
2. Show the count of late issues rather than a list of the issue
   numbers. This makes it consistent with the other types of messages
   shown in this area of the page.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2024-12-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

David Nind  changed:

   What|Removed |Added

 Attachment #175467|0   |1
is obsolete||

--- Comment #21 from David Nind  ---
Created attachment 175474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175474&action=edit
Bug 29996: Show an alert on main page when serial issues are late

The alert is disabled by default and can be enabled for each
subscription individually.
Alerts are shown on the main page only for subscriptions that have this
feature enabled and that are of the same library than the connection
library

Test plan:
1. Run `installer/data/mysql/updatedatabase.pl` and
   `misc/devel/update_dbix_class_files.pl --koha-conf`. Restart Koha if
   needed.
2. Create a subscription, set its library to your connection library
   and enable "Warn when late"
3. Verify that you can see the value of "warn when late" setting on
   subscription-detail.pl
4. The automatically generated serial issue should have the status
   "Expected". Change it to "Late".
5. Go back to the main page. You should see an alert with a link to your
   subscription
6. Change your library using the menu in the upper right corner of the
   screen. Now the alert should not appear.
7. Set your library back to its original value to make the alert
   reappear.
8. Edit your subscription and disable "Warn when late". Verify that the
   alert does not appear.

Sponsored-by: Écoles Nationales Supérieures d'Architecture
Signed-off-by: Owen Leonard 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2024-12-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

--- Comment #20 from Owen Leonard  ---
Julian I hope my follow-up works for you and your sponsor.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

--- Comment #19 from Owen Leonard  ---
Created attachment 175468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175468&action=edit
Bug 29996: (follow-up) Show count of late issues instead of list

This patch makes two changes:
1. Change the label to "The following serials have late issues:"
2. Show the count of late issues rather than a list of the issue
   numbers. This makes it consistent with the other types of messages
   shown in this area of the page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Owen Leonard  changed:

   What|Removed |Added

 Attachment #175385|0   |1
is obsolete||

--- Comment #18 from Owen Leonard  ---
Created attachment 175467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175467&action=edit
Bug 29996: Show an alert on main page when serial issues are late

The alert is disabled by default and can be enabled for each
subscription individually.
Alerts are shown on the main page only for subscriptions that have this
feature enabled and that are of the same library than the connection
library

Test plan:
1. Run `installer/data/mysql/updatedatabase.pl` and
   `misc/devel/update_dbix_class_files.pl --koha-conf`. Restart Koha if
   needed.
2. Create a subscription, set its library to your connection library
   and enable "Warn when late"
3. Verify that you can see the value of "warn when late" setting on
   subscription-detail.pl
4. The automatically generated serial issue should have the status
   "Expected". Change it to "Late".
5. Go back to the main page. You should see an alert with a link to your
   subscription
6. Change your library using the menu in the upper right corner of the
   screen. Now the alert should not appear.
7. Set your library back to its original value to make the alert
   reappear.
8. Edit your subscription and disable "Warn when late". Verify that the
   alert does not appear.

Sponsored-by: Écoles Nationales Supérieures d'Architecture
Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2024-12-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Julian Maurice  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2024-12-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #17 from Julian Maurice  ---
Patches rebased and squashed.

(In reply to Owen Leonard from comment #12)
> Now it's working if I save after checking the "warn when late" box but if I
> save a subscription with the box unchecked I get this error:
> 
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
> execute failed: Column 'warn_when_late' cannot be null at
> /kohadevbox/koha/Koha/Object.pm line 170
>  at /usr/share/perl5/DBIx/Class/Exception.pm line 77

This should be fixed now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2024-12-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Julian Maurice  changed:

   What|Removed |Added

 Attachment #175383|0   |1
is obsolete||
 Attachment #175384|0   |1
is obsolete||

--- Comment #16 from Julian Maurice  ---
Created attachment 175385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175385&action=edit
Bug 29996: Show an alert on main page when serial issues are late

The alert is disabled by default and can be enabled for each
subscription individually.
Alerts are shown on the main page only for subscriptions that have this
feature enabled and that are of the same library than the connection
library

Test plan:
1. Run `installer/data/mysql/updatedatabase.pl` and
   `misc/devel/update_dbix_class_files.pl --koha-conf`. Restart Koha if
   needed.
2. Create a subscription, set its library to your connection library and
   enable "Warn when late"
3. Verify that you can see the value of "warn when late" setting on
   subscription-detail.pl
4. The automatically generated serial issue should have the status
   "Expected". Change it to "Late".
5. Go back to the main page. You should see an alert with a link to your
   subscription
6. Change your library using the menu in the upper right corner of the
   screen. Now the alert should not appear.
7. Set your library back to its original value to make the alert
   reappear.
8. Edit your subscription and disable "Warn when late". Verify that the
   alert does not appear.

Sponsored-by: Écoles Nationales Supérieures d'Architecture

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2024-12-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Julian Maurice  changed:

   What|Removed |Added

 Attachment #156795|0   |1
is obsolete||

--- Comment #15 from Julian Maurice  ---
Created attachment 175384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175384&action=edit
Bug 29996: Show "warn when late" on subscription-detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2024-12-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Julian Maurice  changed:

   What|Removed |Added

 Attachment #156794|0   |1
is obsolete||

--- Comment #14 from Julian Maurice  ---
Created attachment 175383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175383&action=edit
Bug 29996: Show an alert on main page when serial issues are late

The alert is disabled by default and can be enabled for each
subscription individually.
Alerts are shown on the main page only for subscriptions that have this
feature enabled and that are of the same library than the connection
library

Test plan:
1. Run `installer/data/mysql/updatedatabase.pl` and
   `misc/devel/update_dbix_class_files.pl --koha-conf`. Restart Koha if
   needed.
2. Create a subscription, set its library to your connection library and
   enable "Warn when late"
3. The automatically generated serial issue should have the status
   "Expected". Change it to "Late".
4. Go back to the main page. You should see an alert with a link to your
   subscription
5. Change your library using the menu in the upper right corner of the
   screen. Now the alert should not appear.
6. Set your library back to its original value to make the alert
   reappear.
7. Edit your subscription and disable "Warn when late". Verify that the
   alert does not appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2023-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

--- Comment #13 from Julian Maurice  ---
That's weird. I cannot reproduce that error... Any idea where it could come
from ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2023-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #12 from Owen Leonard  ---
Now it's working if I save after checking the "warn when late" box but if I
save a subscription with the box unchecked I get this error:

DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Column 'warn_when_late' cannot be null at
/kohadevbox/koha/Koha/Object.pm line 170
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2023-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #11 from Owen Leonard  ---
(In reply to Julian Maurice from comment #10)
> Did you update the DBIx::Class schema files ?

I did but I neglected to restart after that!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2023-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

--- Comment #10 from Julian Maurice  ---
Did you update the DBIx::Class schema files ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2023-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #9 from Owen Leonard  ---
Even after database update and restart_all I'm getting this error:

No property warn_when_late for Koha::Subscription at
/usr/share/perl5/Exception/Class/Base.pm line 88

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2023-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

--- Comment #8 from Julian Maurice  ---
Created attachment 156795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156795&action=edit
Bug 29996: Show "warn when late" on subscription-detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2023-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #7 from Julian Maurice  ---
Patch rebased on master.

I cannot reproduce the issue mentioned in comment 5. Maybe a temporary bug on
master ?
Please test again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2023-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Julian Maurice  changed:

   What|Removed |Added

 Attachment #143631|0   |1
is obsolete||

--- Comment #6 from Julian Maurice  ---
Created attachment 156794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156794&action=edit
Bug 29996: Show an alert on main page when serial issues are late

The alert is disabled by default and can be enabled for each
subscription individually.
Alerts are shown on the main page only for subscriptions that have this
feature enabled and that are of the same library than the connection
library

Test plan:
1. Run `installer/data/mysql/updatedatabase.pl` and
   `misc/devel/update_dbix_class_files.pl --koha-conf`. Restart Koha if
   needed.
2. Create a subscription, set its library to your connection library and
   enable "Warn when late"
3. The automatically generated serial issue should have the status
   "Expected". Change it to "Late".
4. Go back to the main page. You should see an alert with a link to your
   subscription
5. Change your library using the menu in the upper right corner of the
   screen. Now the alert should not appear.
6. Set your library back to its original value to make the alert
   reappear.
7. Edit your subscription and disable "Warn when late". Verify that the
   alert does not appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2023-01-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Aude Charillon  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||aude.charillon@ptfs-europe.
   ||com

--- Comment #5 from Aude Charillon  ---
When I reach step 7 of the test plan and save my subscription after disabling
"Warn when late", I get the following error:

DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Column 'warn_when_late' cannot be null at
/kohadevbox/koha/Koha/Object.pm line 170
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

On another note, it would be nice to have the "Warn when late" status visible
in the subscription details - either the information tab or the summary one. It
would save the librarian having to edit the subscription to know whether it is
already enabled or not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2022-11-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #4 from Julian Maurice  ---
(In reply to Owen Leonard from comment #2)
> The method Koha::Serials->subscriptionid is not covered by tests!

It was caused by the changes of bug 29844. I added the now required 'as_list'
call and it works again :)
Patch rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2022-11-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Julian Maurice  changed:

   What|Removed |Added

 Attachment #130045|0   |1
is obsolete||

--- Comment #3 from Julian Maurice  ---
Created attachment 143631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143631&action=edit
Bug 29996: Show an alert on main page when serial issues are late

The alert is disabled by default and can be enabled for each
subscription individually.
Alerts are shown on the main page only for subscriptions that have this
feature enabled and that are of the same library than the connection
library

Test plan:
1. Run `installer/data/mysql/updatedatabase.pl` and
   `misc/devel/update_dbix_class_files.pl --koha-conf`. Restart Koha if
   needed.
2. Create a subscription, set its library to your connection library and
   enable "Warn when late"
3. The automatically generated serial issue should have the status
   "Expected". Change it to "Late".
4. Go back to the main page. You should see an alert with a link to your
   subscription
5. Change your library using the menu in the upper right corner of the
   screen. Now the alert should not appear.
6. Set your library back to its original value to make the alert
   reappear.
7. Edit your subscription and disable "Warn when late". Verify that the
   alert does not appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2022-05-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Owen Leonard  ---
I did some simple rebasing of this, and I don't *think* I messed it up, but I'm
getting this error when I hit the main page:

The method Koha::Serials->subscriptionid is not covered by tests!

Trace begun at /kohadevbox/koha/Koha/Objects.pm line 572
Koha::Objects::AUTOLOAD('Koha::Serials=HASH(0x5608d16fa198)') called at
/kohadevbox/koha/mainpage.pl line 129
eval {...} at /kohadevbox/koha/mainpage.pl line 2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2022-02-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Julian Maurice  changed:

   What|Removed |Added

 Blocks||30095


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30095
[Bug 30095] Allow to change "warn when late" setting in subscriptions batch
modification tool
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29996] Show an alert on main page when serial issues are late

2022-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29996

--- Comment #1 from Julian Maurice  ---
Created attachment 130045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130045&action=edit
Bug 29996: Show an alert on main page when serial issues are late

The alert is disabled by default and can be enabled for each
subscription individually.
Alerts are shown on the main page only for subscriptions that have this
feature enabled and that are of the same library than the connection
library

Test plan:
1. Run `installer/data/mysql/updatedatabase.pl` and
   `misc/devel/update_dbix_class_files.pl --koha-conf`. Restart Koha if
   needed.
2. Create a subscription, set its library to your connection library and
   enable "Warn when late"
3. The automatically generated serial issue should have the status
   "Expected". Change it to "Late".
4. Go back to the main page. You should see an alert with a link to your
   subscription
5. Change your library using the menu in the upper right corner of the
   screen. Now the alert should not appear.
6. Set your library back to its original value to make the alert
   reappear.
7. Edit your subscription and disable "Warn when late". Verify that the
   alert does not appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/