[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 --- Comment #31 from Katrin Fischer --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #30 from Jonathan Druart --- Passing QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 David Nind changed: What|Removed |Added Attachment #177122|0 |1 is obsolete|| --- Comment #26 from David Nind --- Created attachment 177139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177139&action=edit Bug 30707: Fix cataloguing/z3950_search.tt Signed-off-by: Owen Leonard Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 --- Comment #29 from David Nind --- I wasn't sure exactly how to test - if what I've done isn't sufficient, please change the status back to needs sign off. Testing notes (using KTD): 1. Check a sample of the change sin the patch - check that the templates have a closing div. 2. Check a sample of page sin the staff interface to make sure they continue to work as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 David Nind changed: What|Removed |Added Attachment #177124|0 |1 is obsolete|| --- Comment #28 from David Nind --- Created attachment 177141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177141&action=edit Bug 30707: Fix members/moremember-print.tt Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 David Nind changed: What|Removed |Added Attachment #177123|0 |1 is obsolete|| --- Comment #27 from David Nind --- Created attachment 177140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177140&action=edit Bug 30707: (follow-up) Many more instances Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 David Nind changed: What|Removed |Added Attachment #177121|0 |1 is obsolete|| --- Comment #25 from David Nind --- Created attachment 177138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177138&action=edit Bug 30707: Fix acqui/z3950_search Signed-off-by: Owen Leonard Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 David Nind changed: What|Removed |Added Attachment #177120|0 |1 is obsolete|| --- Comment #24 from David Nind --- Created attachment 177137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177137&action=edit Bug 30707: Move container's closing div tag into template from intranet-bottom.inc For templates which use the intranet-bottom include file, the markup in that template lacks the main container's closing , expecting it to be closed in intranet-bottom.inc. This patch moves that closing into each template. This is intended to make it clearer to anyone trying to maintain the correct structure of the page and hopefully to make it possible to automatically tidy template files. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 --- Comment #23 from Owen Leonard --- Created attachment 177124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177124&action=edit Bug 30707: Fix members/moremember-print.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 --- Comment #21 from Owen Leonard --- Created attachment 177122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177122&action=edit Bug 30707: Fix cataloguing/z3950_search.tt Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 Owen Leonard changed: What|Removed |Added Attachment #175478|0 |1 is obsolete|| Attachment #175611|0 |1 is obsolete|| Attachment #175612|0 |1 is obsolete|| Attachment #175613|0 |1 is obsolete|| Attachment #175766|0 |1 is obsolete|| --- Comment #19 from Owen Leonard --- Created attachment 177120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177120&action=edit Bug 30707: Move container's closing div tag into template from intranet-bottom.inc For templates which use the intranet-bottom include file, the markup in that template lacks the main container's closing , expecting it to be closed in intranet-bottom.inc. This patch moves that closing into each template. This is intended to make it clearer to anyone trying to maintain the correct structure of the page and hopefully to make it possible to automatically tidy template files. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 --- Comment #22 from Owen Leonard --- Created attachment 177123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177123&action=edit Bug 30707: (follow-up) Many more instances -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 --- Comment #20 from Owen Leonard --- Created attachment 177121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177121&action=edit Bug 30707: Fix acqui/z3950_search Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 Lucas Gass (lukeg) changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #17 from Lucas Gass (lukeg) --- I pulled current main this AM and there is 1 file in this patchset not applying cleanly: authorities/searchresultlist-auth.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 --- Comment #18 from Katrin Fischer --- (In reply to Lucas Gass (lukeg) from comment #17) > I pulled current main this AM and there is 1 file in this patchset not > applying cleanly: > > authorities/searchresultlist-auth.tt Yes, same for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #16 from Katrin Fischer --- Can you please fix the conflict in searchresultlist-auth.tt? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 Katrin Fischer changed: What|Removed |Added Keywords||RM_priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #15 from Jonathan Druart --- Ready for testing, but the patches can also be tested with the parent bugs applied. If the patches do not apply retrieve them from the branch of bug 38664. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 --- Comment #14 from Jonathan Druart --- Created attachment 175766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175766&action=edit Bug 30707: Fix members/moremember-print.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 --- Comment #13 from Phil Ringnalda --- And I guess since invalid bib numbers are going to be broken anyway by the STOP in includes/blocking_errors.inc, it doesn't actually matter whether they also are in MARCdetail. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 Phil Ringnalda changed: What|Removed |Added Attachment #175617|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 --- Comment #12 from Jonathan Druart --- (In reply to Phil Ringnalda from comment #11) > Created attachment 175617 [details] [review] > Bug 30707: Fix catalogue/MARCdetail.tt and catalogue/labeledMARCdetail.tt This is not correct. If you have an invalid record you don't want to see the aside. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 --- Comment #11 from Phil Ringnalda --- Created attachment 175617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175617&action=edit Bug 30707: Fix catalogue/MARCdetail.tt and catalogue/labeledMARCdetail.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 Owen Leonard changed: What|Removed |Added Attachment #175489|0 |1 is obsolete|| Attachment #175500|0 |1 is obsolete|| --- Comment #8 from Owen Leonard --- Created attachment 175611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175611&action=edit Bug 30707: Fix acqui/z3950_search Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 --- Comment #10 from Owen Leonard --- Created attachment 175613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175613&action=edit Bug 30707: (follow-up) Many more instances -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 --- Comment #9 from Owen Leonard --- Created attachment 175612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175612&action=edit Bug 30707: Fix cataloguing/z3950_search.tt Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 --- Comment #7 from Jonathan Druart --- Adjusting status as there might be other problems here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 Jonathan Druart changed: What|Removed |Added Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 --- Comment #6 from Jonathan Druart --- Created attachment 175500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175500&action=edit Bug 30707: Fix cataloguing/z3950_search.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 Jonathan Druart changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.dru...@gmail.com |y.org | Blocks||38713 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38713 [Bug 38713] [OMNIBUS] Incorrect HTML structures -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 --- Comment #5 from Jonathan Druart --- Created attachment 175489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175489&action=edit Bug 30707: Fix acqui/z3950_search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 David Nind changed: What|Removed |Added Text to go in the||For templates which use the release notes||intranet-bottom include ||file, the markup in that ||template lacks the main ||container's closing , ||expecting it to be closed ||in intranet-bottom.inc. ||This moves that closing || into each template. || ||This is intended to make it ||clearer to anyone trying to ||maintain the correct ||structure of the page, and ||hopefully to make it ||possible to automatically ||tidy template files. CC||da...@davidnind.com --- Comment #4 from David Nind --- Testing notes (using KTD): 1. I wasn't sure how to test this, so I did these things: - Checked the patch - it makes logical sense to me - Used an HTML validator on a sample of pages (such as About Koha, main page, Cataloguing page, and various others) - no errors because of missing divs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 David Nind changed: What|Removed |Added Attachment #175454|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 175478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175478&action=edit Bug 30707: Move container's closing div tag into template from intranet-bottom.inc For templates which use the intranet-bottom include file, the markup in that template lacks the main container's closing , expecting it to be closed in intranet-bottom.inc. This patch moves that closing into each template. This is intended to make it clearer to anyone trying to maintain the correct structure of the page and hopefully to make it possible to automatically tidy template files. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 Owen Leonard changed: What|Removed |Added Status|CONFIRMED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 --- Comment #2 from Owen Leonard --- Created attachment 175454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175454&action=edit Bug 30707: Move container's closing div tag into template from intranet-bottom.inc For templates which use the intranet-bottom include file, the markup in that template lacks the main container's closing , expecting it to be closed in intranet-bottom.inc. This patch moves that closing into each template. This is intended to make it clearer to anyone trying to maintain the correct structure of the page and hopefully to make it possible to automatically tidy template files. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30707] Move container's closing div tag into template from intranet-bottom.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30707 Owen Leonard changed: What|Removed |Added Summary|Having a closing div in |Move container's closing |intranet-bottom.inc is |div tag into template from |wrong (?) |intranet-bottom.inc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/